Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preparing of POST/PUT requests not taking into account request body #240

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dawiddzhafarov
Copy link

Hi, in our case we are using a POST body to generate an auth header. The problem is that for the retried requests, it is not taken into account. With this change the request is prepared before sending it and enabling us to construct correct payload. I also added a couple of test cases.

Let me know what you think.

Thanks,
Dawid

@dawiddzhafarov dawiddzhafarov requested a review from a team as a code owner September 17, 2024 08:51
Copy link

hashicorp-cla-app bot commented Sep 17, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@dawiddzhafarov
Copy link
Author

Hello,

I already signed the CLA but it seems like it requests the signing again. However when I enter the form, it is already filled up and I cannot sign it again. Could you please verify?

Thanks!
Dawid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant