-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow managing StateVersion and ConfigurationVersion backing data #801
Allow managing StateVersion and ConfigurationVersion backing data #801
Conversation
c80cc10
to
3a0a6ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the interface is fine as it is. I could imagine these types sharing an interface to simplify your example or adding an error to the example if the specified action was not supported, but these are definitely not blocking feedback.
I didn't run the tests but trust you did!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this looks good. Double-checked the action names in atlas, etc. etc. — I don't see API docs for this yet, but I presume your team's on that elsewhere, yeah?
I'll do the red review for that error name mis-paste, but otherwise this is fine. 👍🏼
3a0a6ae
to
70fad6b
Compare
configuration_version.go
Outdated
RestoreBackingData(ctx context.Context, svID string) error | ||
|
||
// PermanentlyDeleteBackingData permanently deletes a soft deleted configuration version's backing data | ||
// **Note: This functionality is only available in Terraform Enterprise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you catch the closing asterisks on the other two of these too? :) Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, not sure how I missed that one! I also changed the formatting to match the beta notes.
70fad6b
to
70dde47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼!
Per conversation in slack, this is ready to merge so I'm merging it. |
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Description
Adds support for managing the backing data for state versions and configuration versions.
Testing plan
Output from tests
Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.
Note: The failing test (
TestConfigurationVersionsCreate/provisional
) also consistently fails on production, so I don't think it's related to these changes.