Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF-9705 Add organizationScoped to oauth_client resource #812

Merged
merged 6 commits into from
Nov 14, 2023
Merged

TF-9705 Add organizationScoped to oauth_client resource #812

merged 6 commits into from
Nov 14, 2023

Conversation

Netra2104
Copy link
Contributor

@Netra2104 Netra2104 commented Nov 8, 2023 •
edited
Loading

Description

In Atlas, new features were added where the user can change the scope for oauth_client to either the entire organization or to projects.

Related atlas PR: https://hashicorp.atlassian.net/browse/TF-9184

Testing plan

CI tests

External links

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.

=== RUN   TestOAuthClientsUpdate_rsaKeyPair
--- PASS: TestOAuthClientsUpdate_rsaKeyPair (1.28s)
=== RUN   TestOAuthClientsUpdate_rsaKeyPair/updates_organization_scoped
    --- PASS: TestOAuthClientsUpdate_rsaKeyPair/updates_organization_scoped (0.39s)
PASS

@Netra2104 Netra2104 requested a review from a team as a code owner November 8, 2023 16:43
@Netra2104 Netra2104 changed the title TF-9705 Add organizatioScoped to oauth_client resource TF-9705 Add organizationScoped to oauth_client resource Nov 8, 2023
@Netra2104 Netra2104 requested a review from a team November 9, 2023 15:29
@Netra2104 Netra2104 force-pushed the Netra2104/TF-9705-organization-scoped-oauth-client branch from aad389d to a3d237e Compare November 9, 2023 15:31
jbonhag
jbonhag reviewed Nov 9, 2023
View reviewed changes
Copy link
Contributor

@jbonhag jbonhag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! I left a couple of things to consider.

oauth_client.go Show resolved Hide resolved
oauth_client_integration_test.go Outdated Show resolved Hide resolved
jbonhag
jbonhag previously approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@jbonhag jbonhag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

sebasslash
sebasslash requested changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@sebasslash sebasslash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🕺 ! Just one minor change to the changelog and we're good to merge

CHANGELOG.md Show resolved Hide resolved
sebasslash
sebasslash requested changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@sebasslash sebasslash left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to do this again, but the entry should be under the # UNRELEASED section and not under # v1.39.2. I would drop the merge and changelog commit, rebase your branch with main and re-commit.

@netramali
parent 09f6c3a
b090084 
author Netra Mali <netra.mali@hashicorp.com> 1699460954 -0500
committer Netra Mali <netra.mali@hashicorp.com> 1699981200 -0500

added organization scoped

Update CHANGELOG.md
@Netra2104 Netra2104 force-pushed the Netra2104/TF-9705-organization-scoped-oauth-client branch from 7937612 to b090084 Compare November 14, 2023 17:05
@Netra2104 Netra2104 merged commit 51a9039 into main Nov 14, 2023
10 checks passed
@Netra2104 Netra2104 deleted the Netra2104/TF-9705-organization-scoped-oauth-client branch November 14, 2023 17:52
@github-actions GitHub Actions
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

This was referenced Nov 16, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebasslash sebasslash sebasslash approved these changes

@jbonhag jbonhag jbonhag left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Netra2104 @jbonhag @sebasslash @netramali