-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TF-9705 Add organizationScoped to oauth_client resource #812
TF-9705 Add organizationScoped to oauth_client resource #812
Conversation
aad389d
to
a3d237e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense! I left a couple of things to consider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 🕺 ! Just one minor change to the changelog and we're good to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to do this again, but the entry should be under the # UNRELEASED
section and not under # v1.39.2
. I would drop the merge and changelog commit, rebase your branch with main
and re-commit.
7937612
to
b090084
Compare
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Description
In Atlas, new features were added where the user can change the scope for oauth_client to either the entire organization or to projects.
Related atlas PR: https://hashicorp.atlassian.net/browse/TF-9184
Testing plan
CI tests
External links
Output from tests
Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.