[f-nested-deps] Remove requirement to have root pack name in overrides #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angrycub
added
type/enhancement
theme/pack/dependency
angrycub
force-pushed
the
f-nested-var-deps-cont
branch
from
f7a8846 to
b804429
Compare
angrycub
changed the title
angrycub
force-pushed
the
f-nested-var-deps-cont
branch
from
b804429 to
ef3a0ca
Compare
angrycub
force-pushed
the
f-nested-var-deps-cont
branch
from
ef3a0ca to
0affa93
Compare
This was referenced Sep 27, 2023
pkazmierczak
approved these changes
Sep 28, 2023
internal/pkg/varfile/varfile.go
Outdated
| @@ -13,13 +13,15 @@ import ( | |||
| "github.com/hashicorp/nomad-pack/sdk/pack/variables" | |||
| ) | |||
|
|
|||
| func DecodeVariableOverrides(files []*pack.File) DecodeResult { | |||
| // TODO: this is only used in a test - remove? | |||
There was a problem hiding this comment.
Moved into the test package
| var path pack.ID | ||
| var name variables.ID | ||
|
|
||
| // NOTE: This implementation assumes a single element variable value, |
There was a problem hiding this comment.
I think that's fine for now but maybe make an issue so that we could revisit later?
There was a problem hiding this comment.
Created issue #435 to capture this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues on the work in #403. Removes the requirement to specify the name of the root pack in the override variable's path.