Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: move Darwin builds to Linux runner #566

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

tgross
Copy link
Member

@tgross tgross commented Jul 31, 2024

Pack doesn't require CGO and explicitly disables it in the build. We can build the Darwin builds on Linux and drop the expensive Darwin runners.

Ref: https://hashicorp.atlassian.net/browse/NET-9603

Pack doesn't require CGO and explicitly disables it in the build. We can build
the Darwin builds on Linux and drop the expensive Darwin runners.

Ref: https://hashicorp.atlassian.net/browse/NET-9603
@tgross tgross marked this pull request as ready for review July 31, 2024 19:27
@tgross tgross requested a review from a team as a code owner July 31, 2024 19:27
Copy link
Contributor

@pkazmierczak pkazmierczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Tim!

@tgross tgross merged commit 4a958ae into main Aug 1, 2024
17 checks passed
@tgross tgross deleted the build-remove-darwin-runner branch August 1, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants