-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update consul-template to 0.37.4 to fix resource leak #20234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
added
theme/dependencies
Pull requests that update a dependency file
theme/consul-template
labels
Mar 27, 2024
tgross
force-pushed
the
deps-consul-template
branch
from
March 27, 2024 14:48
aa774dd
to
45aa1a3
Compare
A Nomad user reported an issue where template runner `View.poll` goroutines were being leaked when using templates with many dependencies. This resource leak was fixed in consul-template 0.37.4. Fixes: #20163
tgross
force-pushed
the
deps-consul-template
branch
from
March 27, 2024 14:58
45aa1a3
to
98fa14f
Compare
shoenig
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🕷️
tgross
added
backport/1.5.x
backport to 1.5.x release line
backport/1.6.x
backport to 1.6.x release line
backport/1.7.x
backport to 1.7.x release line
labels
Mar 27, 2024
This was referenced Mar 27, 2024
Merged
Merged
tgross
added a commit
that referenced
this pull request
Mar 27, 2024
A Nomad user reported an issue where template runner `View.poll` goroutines were being leaked when using templates with many dependencies. This resource leak was fixed in consul-template 0.37.4. Fixes: #20163
tgross
added a commit
that referenced
this pull request
Mar 27, 2024
A Nomad user reported an issue where template runner `View.poll` goroutines were being leaked when using templates with many dependencies. This resource leak was fixed in consul-template 0.37.4. Fixes: #20163
tgross
added a commit
that referenced
this pull request
Mar 27, 2024
A Nomad user reported an issue where template runner `View.poll` goroutines were being leaked when using templates with many dependencies. This resource leak was fixed in consul-template 0.37.4. Fixes: #20163
tgross
added a commit
that referenced
this pull request
Mar 27, 2024
A Nomad user reported an issue where template runner `View.poll` goroutines were being leaked when using templates with many dependencies. This resource leak was fixed in consul-template 0.37.4. Fixes: #20163
philrenaud
pushed a commit
that referenced
this pull request
Apr 18, 2024
A Nomad user reported an issue where template runner `View.poll` goroutines were being leaked when using templates with many dependencies. This resource leak was fixed in consul-template 0.37.4. Fixes: #20163
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/1.5.x
backport to 1.5.x release line
backport/1.6.x
backport to 1.6.x release line
backport/1.7.x
backport to 1.7.x release line
theme/consul-template
theme/dependencies
Pull requests that update a dependency file
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Nomad user reported an issue where template runner
View.poll
goroutines were being leaked when using templates with many dependencies. This resource leak was fixed in consul-template 0.37.4.Fixes: #20163