Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boolvalidator: add Equals validator #232

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Sep 18, 2024

This validator can be used in cases where non-null boolean value should be exactly true or exactly false.

% go test -count=1 ./boolvalidator/...
ok      github.com/hashicorp/terraform-plugin-framework-validators/boolvalidator        0.251s

Closes #231

This validator can be used in cases where non-null boolean value should be exactly `true` or exactly `false`.

```console
% go test -count=1 ./boolvalidator/...
ok      github.com/hashicorp/terraform-plugin-framework-validators/boolvalidator        0.251s
```
@jar-b jar-b requested a review from a team as a code owner September 18, 2024 20:42
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @jar-b! Validators are pretty easy to maintain so no problem moving it up here.

I had one small suggestion for the go doc, and would you mind adding a changelog? 🙏🏻

boolvalidator/equals.go Outdated Show resolved Hide resolved
@austinvalle austinvalle added the enhancement New feature or request label Sep 20, 2024
@austinvalle austinvalle added this to the v0.14.0 milestone Sep 20, 2024
jar-b and others added 2 commits September 20, 2024 16:44
Co-authored-by: Austin Valle <austinvalle@gmail.com>
@jar-b
Copy link
Member Author

jar-b commented Sep 20, 2024

Added a changelog entry. Thanks!

@austinvalle austinvalle merged commit 974015b into hashicorp:main Sep 20, 2024
6 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Equals validator for boolean types
2 participants