Merge pull request #37511 from hashicorp/t-acctest-literal-value2-val…

…ue1-TRUE-FALSE-key1-key2-string-constant

ci: Prefer constants for test string literals

.ci/.semgrep-test-constants.yml

@@ -1,5 +1,35 @@
 # Generated by internal/generate/acctestconsts/main.go; DO NOT EDIT.
 rules:
+  - id: literal-FalseCaps-string-test-constant
+    languages: [go]
+    message: Use the constant `acctest.CtFalseCaps` for the string literal "FALSE"
+    paths:
+      include:
+        - "internal/service/**/*_test.go"
+    patterns:
+      - pattern: '"FALSE"'
+    severity: ERROR
+    fix: "acctest.CtFalseCaps"
+  - id: literal-Key1-string-test-constant
+    languages: [go]
+    message: Use the constant `acctest.CtKey1` for the string literal "key1"
+    paths:
+      include:
+        - "internal/service/**/*_test.go"
+    patterns:
+      - pattern: '"key1"'
+    severity: ERROR
+    fix: "acctest.CtKey1"
+  - id: literal-Key2-string-test-constant
+    languages: [go]
+    message: Use the constant `acctest.CtKey2` for the string literal "key2"
+    paths:
+      include:
+        - "internal/service/**/*_test.go"
+    patterns:
+      - pattern: '"key2"'
+    severity: ERROR
+    fix: "acctest.CtKey2"
   - id: literal-One-string-test-constant
     languages: [go]
     message: Use the constant `acctest.CtOne` for the string literal "1"
@@ -20,6 +50,16 @@ rules:
       - pattern: '"tags.%"'
     severity: ERROR
     fix: "acctest.CtTagsPercent"
+  - id: literal-TrueCaps-string-test-constant
+    languages: [go]
+    message: Use the constant `acctest.CtTrueCaps` for the string literal "TRUE"
+    paths:
+      include:
+        - "internal/service/**/*_test.go"
+    patterns:
+      - pattern: '"TRUE"'
+    severity: ERROR
+    fix: "acctest.CtTrueCaps"
   - id: literal-Two-string-test-constant
     languages: [go]
     message: Use the constant `acctest.CtTwo` for the string literal "2"
@@ -30,6 +70,26 @@ rules:
       - pattern: '"2"'
     severity: ERROR
     fix: "acctest.CtTwo"
+  - id: literal-Value1-string-test-constant
+    languages: [go]
+    message: Use the constant `acctest.CtValue1` for the string literal "value1"
+    paths:
+      include:
+        - "internal/service/**/*_test.go"
+    patterns:
+      - pattern: '"value1"'
+    severity: ERROR
+    fix: "acctest.CtValue1"
+  - id: literal-Value2-string-test-constant
+    languages: [go]
+    message: Use the constant `acctest.CtValue2` for the string literal "value2"
+    paths:
+      include:
+        - "internal/service/**/*_test.go"
+    patterns:
+      - pattern: '"value2"'
+    severity: ERROR
+    fix: "acctest.CtValue2"
   - id: literal-Zero-string-test-constant
     languages: [go]
     message: Use the constant `acctest.CtZero` for the string literal "0"

internal/acctest/consts.csv

@@ -1,4 +1,10 @@
 0,Zero
 1,One
 2,Two
+FALSE,FalseCaps
+TRUE,TrueCaps
+key1,Key1
+key2,Key2
 tags.%,TagsPercent
+value1,Value1
+value2,Value2