Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Changes to aws_iam_instance_profile are not detected #32671

Closed
Nuru opened this issue Jul 24, 2023 · 4 comments · Fixed by #34099
Closed

[Bug]: Changes to aws_iam_instance_profile are not detected #32671

Nuru opened this issue Jul 24, 2023 · 4 comments · Fixed by #34099
Labels
bug Addresses a defect in current functionality. service/iam Issues and PRs that pertain to the iam service.
Milestone

Comments

@Nuru
Copy link

Nuru commented Jul 24, 2023

Terraform Core Version

1.5.3

AWS Provider Version

5.9.0

Affected Resource(s)

  • aws_iam_instance_profile

Expected Behavior

When an aws_iam_instance_profile has a role attached in Terraform but not in AWS, terraform plan should detect the drift and correct it.

Actual Behavior

In this situation, terraform plan reports "No changes"

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

locals {
  iam_role_name = "example"
  role_enabled  = length(local.iam_role_name) > 0
}

resource "aws_iam_instance_profile" "default" {
  count = local.role_enabled ? 1 : 0

  name = local.iam_role_name
  role = local.iam_role_name
  tags = { Name = local.iam_role_name }
}

Steps to Reproduce

  • Use terraform apply to create an instance profile with an attached role
  • Use aws iam remove-role-from-instance-profile to remove the role from the instance profile
  • Run terraform apply again

Debug Output

No response

Panic Output

No response

Important Factoids

We did not intentionally remove the role from the profile, rather I just discovered it was missing. I do not know how it got into that state, but it was not as malicious or deliberate as the "Steps to Reproduce".

My best guess at how this actually happened is that after the instance profile was created, the attached role was updated in a way that caused it to be detached from the instance profile. Possibly the role was deleted and recreated.

References

These issues are similar, but do not specifically address the lack of drift detection:

Would you like to implement a fix?

No

@Nuru Nuru added bug Addresses a defect in current functionality. needs-triage Waiting for first response or review from a maintainer. labels Jul 24, 2023
@github-actions github-actions bot added the service/iam Issues and PRs that pertain to the iam service. label Jul 24, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.43.0 milestone Mar 27, 2024
Copy link

This functionality has been released in v5.43.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/iam Issues and PRs that pertain to the iam service.
Projects
None yet
2 participants