Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Resource] aws_datasync_location_fsx_ontap_file_system #32632

Merged
merged 50 commits into from
Aug 21, 2023
Merged

[New Resource] aws_datasync_location_fsx_ontap_file_system #32632

merged 50 commits into from
Aug 21, 2023

Conversation

R-Campbell
Copy link
Contributor

Description

Add a new resource for creating a DataSync location pointing to an FSx ONTAP file system.

Relations

Closes #30254

References

https://docs.aws.amazon.com/datasync/latest/userguide/API_CreateLocationFsxOntap.html

For the specific enumeration of mount versions:
https://docs.aws.amazon.com/datasync/latest/userguide/API_FsxProtocolNfs.html
https://docs.aws.amazon.com/datasync/latest/userguide/API_FsxProtocolSmb.html

Output from Acceptance Testing

$ make testacc TESTS=TestAccDataSyncLocationFSxOntapFileSystem_ PKG=datasync
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 20 -run='TestAccDataSyncLocationFSxOntapFileSystem_'  -timeout 180m
=== RUN   TestAccDataSyncLocationFSxOntapFileSystem_basic
=== PAUSE TestAccDataSyncLocationFSxOntapFileSystem_basic
=== RUN   TestAccDataSyncLocationFSxOntapFileSystem_disappears
=== PAUSE TestAccDataSyncLocationFSxOntapFileSystem_disappears
=== RUN   TestAccDataSyncLocationFSxOntapFileSystem_subdirectory
=== PAUSE TestAccDataSyncLocationFSxOntapFileSystem_subdirectory
=== RUN   TestAccDataSyncLocationFSxOntapFileSystem_tags
=== PAUSE TestAccDataSyncLocationFSxOntapFileSystem_tags
=== CONT  TestAccDataSyncLocationFSxOntapFileSystem_basic
=== CONT  TestAccDataSyncLocationFSxOntapFileSystem_subdirectory
=== CONT  TestAccDataSyncLocationFSxOntapFileSystem_tags
=== CONT  TestAccDataSyncLocationFSxOntapFileSystem_disappears
--- PASS: TestAccDataSyncLocationFSxOntapFileSystem_subdirectory (1998.14s)
--- PASS: TestAccDataSyncLocationFSxOntapFileSystem_disappears (2186.84s)
--- PASS: TestAccDataSyncLocationFSxOntapFileSystem_basic (2388.21s)
--- PASS: TestAccDataSyncLocationFSxOntapFileSystem_tags (2417.38s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datasync	2420.656s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/datasync Issues and PRs that pertain to the datasync service. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/datasync Issues and PRs that pertain to the datasync service. generators Relates to code generators. labels Jul 21, 2023
@R-Campbell R-Campbell changed the title [New Resource] aws_datasync_location_fsx_ontap_file_system [New Resource] aws_datasync_location_fsx_ontap_file_system Jul 21, 2023
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/datasync Issues and PRs that pertain to the datasync service. generators Relates to code generators. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/datasync Issues and PRs that pertain to the datasync service. generators Relates to code generators. labels Jul 21, 2023
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 24, 2023
@ewbankkit
r/aws_datasync_location_fsx_windows_file_system: Add 'FindLocationFSx…
00b3a58 
…WindowsByARN'.
@ewbankkit
r/aws_datasync_location_fsx_windows_file_system: Tidy up acceptance t…
4dd2226 
…ests.
@ewbankkit
r/aws_datasync_location_hdfs: Alphabetize attributes.
d375b7c
@ewbankkit
r/aws_datasync_location_hdfs: Tidy up.
2f0a9f8
@ewbankkit
r/aws_datasync_location_hdfs: Tidy up acceptance tests.
e8182bf
@ewbankkit
r/aws_datasync_location_efs: Tidy up acceptance tests.
a1ef474
@ewbankkit
r/aws_datasync_location_nfs: Tidy up.
1e2bcd2
@ewbankkit
r/aws_datasync_location_object_storage: Alphabetize attributes.
65cfae6
@ewbankkit
r/aws_datasync_location_object_storage: Tidy up.
024d972
@ewbankkit
r/aws_datasync_location_s3: Alphabetize attributes.
9623461
@ewbankkit
r/aws_datasync_location_s3: Tidy up resource Create.
69e8df7
@ewbankkit
r/aws_datasync_location_s3: Add 'FindLocationS3ByARN'.
f78288f
@ewbankkit
r/aws_datasync_location_s3: Tidy up acceptance tests.
036a3fc
@ewbankkit
r/aws_datasync_location_smb: Alphabetize attributes.
5c73677
@ewbankkit
r/aws_datasync_location_smb: Add 'FindLocationSMBByARN'.
51336a0
@ewbankkit
r/aws_datasync_location_smb: Tidy up acceptance tests.
a2d23c8
@ewbankkit
r/aws_datasync_task: Tidy up.
e8df6e0
@ewbankkit
r/aws_datasync_task: Tidy up acceptance tests.
1c89ed5
@ewbankkit
Support Azure blob URIs in 'subdirectoryFromLocationURI'.
f65cf2e
@ewbankkit
r/aws_datasync_location_azure_blob: New resource.
f646a0b
ewbankkit
ewbankkit approved these changes Aug 20, 2023
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDataSyncLocationFSxOntapFileSystem_' PKG=datasync ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 2  -run=TestAccDataSyncLocationFSxOntapFileSystem_ -timeout 180m
=== RUN   TestAccDataSyncLocationFSxOntapFileSystem_basic
=== PAUSE TestAccDataSyncLocationFSxOntapFileSystem_basic
=== RUN   TestAccDataSyncLocationFSxOntapFileSystem_disappears
=== PAUSE TestAccDataSyncLocationFSxOntapFileSystem_disappears
=== RUN   TestAccDataSyncLocationFSxOntapFileSystem_subdirectory
=== PAUSE TestAccDataSyncLocationFSxOntapFileSystem_subdirectory
=== RUN   TestAccDataSyncLocationFSxOntapFileSystem_tags
=== PAUSE TestAccDataSyncLocationFSxOntapFileSystem_tags
=== CONT  TestAccDataSyncLocationFSxOntapFileSystem_basic
=== CONT  TestAccDataSyncLocationFSxOntapFileSystem_subdirectory
--- PASS: TestAccDataSyncLocationFSxOntapFileSystem_basic (2265.91s)
=== CONT  TestAccDataSyncLocationFSxOntapFileSystem_disappears
--- PASS: TestAccDataSyncLocationFSxOntapFileSystem_subdirectory (2266.56s)
=== CONT  TestAccDataSyncLocationFSxOntapFileSystem_tags
--- PASS: TestAccDataSyncLocationFSxOntapFileSystem_tags (2106.39s)
--- PASS: TestAccDataSyncLocationFSxOntapFileSystem_disappears (2220.19s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datasync	4491.218s
% make testacc TESTARGS='-run=TestAccDataSyncAgent_' PKG=datasync ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 2  -run=TestAccDataSyncAgent_ -timeout 180m
=== RUN   TestAccDataSyncAgent_basic
=== PAUSE TestAccDataSyncAgent_basic
=== RUN   TestAccDataSyncAgent_disappears
=== PAUSE TestAccDataSyncAgent_disappears
=== RUN   TestAccDataSyncAgent_agentName
=== PAUSE TestAccDataSyncAgent_agentName
=== RUN   TestAccDataSyncAgent_tags
=== PAUSE TestAccDataSyncAgent_tags
=== RUN   TestAccDataSyncAgent_vpcEndpointID
=== PAUSE TestAccDataSyncAgent_vpcEndpointID
=== CONT  TestAccDataSyncAgent_basic
=== CONT  TestAccDataSyncAgent_tags
--- PASS: TestAccDataSyncAgent_basic (172.66s)
=== CONT  TestAccDataSyncAgent_agentName
--- PASS: TestAccDataSyncAgent_tags (178.62s)
=== CONT  TestAccDataSyncAgent_vpcEndpointID
--- PASS: TestAccDataSyncAgent_agentName (143.53s)
=== CONT  TestAccDataSyncAgent_disappears
--- PASS: TestAccDataSyncAgent_vpcEndpointID (235.35s)
--- PASS: TestAccDataSyncAgent_disappears (116.06s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datasync	437.556s
% make testacc TESTARGS='-run=TestAccDataSyncLocationEFS_' PKG=datasync ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 2  -run=TestAccDataSyncLocationEFS_ -timeout 180m
=== RUN   TestAccDataSyncLocationEFS_basic
=== PAUSE TestAccDataSyncLocationEFS_basic
=== RUN   TestAccDataSyncLocationEFS_accessPointARN
=== PAUSE TestAccDataSyncLocationEFS_accessPointARN
=== RUN   TestAccDataSyncLocationEFS_disappears
=== PAUSE TestAccDataSyncLocationEFS_disappears
=== RUN   TestAccDataSyncLocationEFS_subdirectory
=== PAUSE TestAccDataSyncLocationEFS_subdirectory
=== RUN   TestAccDataSyncLocationEFS_tags
=== PAUSE TestAccDataSyncLocationEFS_tags
=== CONT  TestAccDataSyncLocationEFS_basic
=== CONT  TestAccDataSyncLocationEFS_subdirectory
--- PASS: TestAccDataSyncLocationEFS_basic (143.37s)
=== CONT  TestAccDataSyncLocationEFS_disappears
--- PASS: TestAccDataSyncLocationEFS_subdirectory (144.30s)
=== CONT  TestAccDataSyncLocationEFS_tags
--- PASS: TestAccDataSyncLocationEFS_disappears (138.22s)
=== CONT  TestAccDataSyncLocationEFS_accessPointARN
--- PASS: TestAccDataSyncLocationEFS_tags (186.14s)
--- PASS: TestAccDataSyncLocationEFS_accessPointARN (140.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datasync	427.355s
% make testacc TESTARGS='-run=TestAccDataSyncLocationFSxLustreFileSystem_' PKG=datasync ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 2  -run=TestAccDataSyncLocationFSxLustreFileSystem_ -timeout 180m
=== RUN   TestAccDataSyncLocationFSxLustreFileSystem_basic
=== PAUSE TestAccDataSyncLocationFSxLustreFileSystem_basic
=== RUN   TestAccDataSyncLocationFSxLustreFileSystem_disappears
=== PAUSE TestAccDataSyncLocationFSxLustreFileSystem_disappears
=== RUN   TestAccDataSyncLocationFSxLustreFileSystem_subdirectory
=== PAUSE TestAccDataSyncLocationFSxLustreFileSystem_subdirectory
=== RUN   TestAccDataSyncLocationFSxLustreFileSystem_tags
=== PAUSE TestAccDataSyncLocationFSxLustreFileSystem_tags
=== CONT  TestAccDataSyncLocationFSxLustreFileSystem_basic
=== CONT  TestAccDataSyncLocationFSxLustreFileSystem_subdirectory
--- PASS: TestAccDataSyncLocationFSxLustreFileSystem_subdirectory (576.35s)
=== CONT  TestAccDataSyncLocationFSxLustreFileSystem_tags
--- PASS: TestAccDataSyncLocationFSxLustreFileSystem_basic (698.43s)
=== CONT  TestAccDataSyncLocationFSxLustreFileSystem_disappears
--- PASS: TestAccDataSyncLocationFSxLustreFileSystem_tags (667.39s)
--- PASS: TestAccDataSyncLocationFSxLustreFileSystem_disappears (630.80s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datasync	1334.623s
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccDataSyncLocationFSxLustreFileSystem_\|TestAccDataSyncLocationFSxWindowsFileSystem_\|TestAccDataSyncLocationHDFS_' PKG=datasync ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 2  -run=TestAccDataSyncLocationFSxLustreFileSystem_\|TestAccDataSyncLocationFSxWindowsFileSystem_\|TestAccDataSyncLocationHDFS_ -timeout 720m
=== RUN   TestAccDataSyncLocationFSxLustreFileSystem_basic
=== PAUSE TestAccDataSyncLocationFSxLustreFileSystem_basic
=== RUN   TestAccDataSyncLocationFSxLustreFileSystem_disappears
=== PAUSE TestAccDataSyncLocationFSxLustreFileSystem_disappears
=== RUN   TestAccDataSyncLocationFSxLustreFileSystem_subdirectory
=== PAUSE TestAccDataSyncLocationFSxLustreFileSystem_subdirectory
=== RUN   TestAccDataSyncLocationFSxLustreFileSystem_tags
=== PAUSE TestAccDataSyncLocationFSxLustreFileSystem_tags
=== RUN   TestAccDataSyncLocationFSxWindowsFileSystem_basic
=== PAUSE TestAccDataSyncLocationFSxWindowsFileSystem_basic
=== RUN   TestAccDataSyncLocationFSxWindowsFileSystem_disappears
=== PAUSE TestAccDataSyncLocationFSxWindowsFileSystem_disappears
=== RUN   TestAccDataSyncLocationFSxWindowsFileSystem_subdirectory
=== PAUSE TestAccDataSyncLocationFSxWindowsFileSystem_subdirectory
=== RUN   TestAccDataSyncLocationFSxWindowsFileSystem_tags
=== PAUSE TestAccDataSyncLocationFSxWindowsFileSystem_tags
=== RUN   TestAccDataSyncLocationHDFS_basic
=== PAUSE TestAccDataSyncLocationHDFS_basic
=== RUN   TestAccDataSyncLocationHDFS_disappears
=== PAUSE TestAccDataSyncLocationHDFS_disappears
=== RUN   TestAccDataSyncLocationHDFS_tags
=== PAUSE TestAccDataSyncLocationHDFS_tags
=== CONT  TestAccDataSyncLocationFSxLustreFileSystem_basic
=== CONT  TestAccDataSyncLocationFSxWindowsFileSystem_subdirectory
--- PASS: TestAccDataSyncLocationFSxLustreFileSystem_basic (606.11s)
=== CONT  TestAccDataSyncLocationHDFS_disappears
--- PASS: TestAccDataSyncLocationHDFS_disappears (166.31s)
=== CONT  TestAccDataSyncLocationHDFS_tags
--- PASS: TestAccDataSyncLocationHDFS_tags (164.45s)
=== CONT  TestAccDataSyncLocationFSxLustreFileSystem_tags
--- PASS: TestAccDataSyncLocationFSxLustreFileSystem_tags (666.06s)
=== CONT  TestAccDataSyncLocationFSxWindowsFileSystem_disappears
--- PASS: TestAccDataSyncLocationFSxWindowsFileSystem_subdirectory (2987.94s)
=== CONT  TestAccDataSyncLocationFSxWindowsFileSystem_basic
--- PASS: TestAccDataSyncLocationFSxWindowsFileSystem_disappears (3725.19s)
=== CONT  TestAccDataSyncLocationHDFS_basic
--- PASS: TestAccDataSyncLocationHDFS_basic (145.95s)
=== CONT  TestAccDataSyncLocationFSxWindowsFileSystem_tags
--- PASS: TestAccDataSyncLocationFSxWindowsFileSystem_basic (3896.64s)
=== CONT  TestAccDataSyncLocationFSxLustreFileSystem_subdirectory
--- PASS: TestAccDataSyncLocationFSxLustreFileSystem_subdirectory (584.07s)
=== CONT  TestAccDataSyncLocationFSxLustreFileSystem_disappears
--- PASS: TestAccDataSyncLocationFSxLustreFileSystem_disappears (672.35s)
--- PASS: TestAccDataSyncLocationFSxWindowsFileSystem_tags (3271.05s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datasync	8749.891s
% make testacc TESTARGS='-run=TestAccDataSyncLocationNFS_\|TestAccDataSyncLocationObjectStorage_\|TestAccDataSyncLocationS3_\|TestAccDataSyncLocationSMB_' PKG=datasync ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 2  -run=TestAccDataSyncLocationNFS_\|TestAccDataSyncLocationObjectStorage_\|TestAccDataSyncLocationS3_\|TestAccDataSyncLocationSMB_ -timeout 180m
=== RUN   TestAccDataSyncLocationNFS_basic
=== PAUSE TestAccDataSyncLocationNFS_basic
=== RUN   TestAccDataSyncLocationNFS_mountOptions
=== PAUSE TestAccDataSyncLocationNFS_mountOptions
=== RUN   TestAccDataSyncLocationNFS_disappears
=== PAUSE TestAccDataSyncLocationNFS_disappears
=== RUN   TestAccDataSyncLocationNFS_AgentARNs_multiple
=== PAUSE TestAccDataSyncLocationNFS_AgentARNs_multiple
=== RUN   TestAccDataSyncLocationNFS_subdirectory
=== PAUSE TestAccDataSyncLocationNFS_subdirectory
=== RUN   TestAccDataSyncLocationNFS_tags
=== PAUSE TestAccDataSyncLocationNFS_tags
=== RUN   TestAccDataSyncLocationObjectStorage_basic
=== PAUSE TestAccDataSyncLocationObjectStorage_basic
=== RUN   TestAccDataSyncLocationObjectStorage_disappears
=== PAUSE TestAccDataSyncLocationObjectStorage_disappears
=== RUN   TestAccDataSyncLocationObjectStorage_tags
=== PAUSE TestAccDataSyncLocationObjectStorage_tags
=== RUN   TestAccDataSyncLocationObjectStorage_serverCertificate
=== PAUSE TestAccDataSyncLocationObjectStorage_serverCertificate
=== RUN   TestAccDataSyncLocationS3_basic
=== PAUSE TestAccDataSyncLocationS3_basic
=== RUN   TestAccDataSyncLocationS3_storageClass
=== PAUSE TestAccDataSyncLocationS3_storageClass
=== RUN   TestAccDataSyncLocationS3_disappears
=== PAUSE TestAccDataSyncLocationS3_disappears
=== RUN   TestAccDataSyncLocationS3_tags
=== PAUSE TestAccDataSyncLocationS3_tags
=== RUN   TestAccDataSyncLocationSMB_basic
=== PAUSE TestAccDataSyncLocationSMB_basic
=== RUN   TestAccDataSyncLocationSMB_disappears
=== PAUSE TestAccDataSyncLocationSMB_disappears
=== RUN   TestAccDataSyncLocationSMB_tags
=== PAUSE TestAccDataSyncLocationSMB_tags
=== CONT  TestAccDataSyncLocationNFS_basic
=== CONT  TestAccDataSyncLocationObjectStorage_serverCertificate
--- PASS: TestAccDataSyncLocationNFS_basic (115.87s)
=== CONT  TestAccDataSyncLocationNFS_tags
--- PASS: TestAccDataSyncLocationObjectStorage_serverCertificate (119.05s)
=== CONT  TestAccDataSyncLocationObjectStorage_tags
--- PASS: TestAccDataSyncLocationObjectStorage_tags (179.25s)
=== CONT  TestAccDataSyncLocationObjectStorage_disappears
--- PASS: TestAccDataSyncLocationNFS_tags (189.99s)
=== CONT  TestAccDataSyncLocationObjectStorage_basic
--- PASS: TestAccDataSyncLocationObjectStorage_disappears (122.92s)
=== CONT  TestAccDataSyncLocationNFS_AgentARNs_multiple
--- PASS: TestAccDataSyncLocationObjectStorage_basic (125.44s)
=== CONT  TestAccDataSyncLocationNFS_subdirectory
--- PASS: TestAccDataSyncLocationNFS_subdirectory (150.85s)
=== CONT  TestAccDataSyncLocationS3_tags
--- PASS: TestAccDataSyncLocationNFS_AgentARNs_multiple (200.82s)
=== CONT  TestAccDataSyncLocationSMB_tags
--- PASS: TestAccDataSyncLocationS3_tags (75.04s)
=== CONT  TestAccDataSyncLocationSMB_disappears
--- PASS: TestAccDataSyncLocationSMB_disappears (124.74s)
=== CONT  TestAccDataSyncLocationSMB_basic
--- PASS: TestAccDataSyncLocationSMB_tags (173.44s)
=== CONT  TestAccDataSyncLocationS3_storageClass
--- PASS: TestAccDataSyncLocationS3_storageClass (28.49s)
=== CONT  TestAccDataSyncLocationS3_disappears
--- PASS: TestAccDataSyncLocationS3_disappears (35.41s)
=== CONT  TestAccDataSyncLocationS3_basic
--- PASS: TestAccDataSyncLocationS3_basic (38.16s)
=== CONT  TestAccDataSyncLocationNFS_disappears
--- PASS: TestAccDataSyncLocationSMB_basic (153.63s)
=== CONT  TestAccDataSyncLocationNFS_mountOptions
--- PASS: TestAccDataSyncLocationNFS_disappears (102.00s)
--- PASS: TestAccDataSyncLocationNFS_mountOptions (170.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datasync	1111.324s
% make testacc TESTARGS='-run=TestAccDataSyncLocationAzureBlob_' PKG=datasync ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 3  -run=TestAccDataSyncLocationAzureBlob_ -timeout 180m
=== RUN   TestAccDataSyncLocationAzureBlob_basic
=== PAUSE TestAccDataSyncLocationAzureBlob_basic
=== RUN   TestAccDataSyncLocationAzureBlob_disappears
=== PAUSE TestAccDataSyncLocationAzureBlob_disappears
=== RUN   TestAccDataSyncLocationAzureBlob_tags
=== PAUSE TestAccDataSyncLocationAzureBlob_tags
=== RUN   TestAccDataSyncLocationAzureBlob_update
=== PAUSE TestAccDataSyncLocationAzureBlob_update
=== CONT  TestAccDataSyncLocationAzureBlob_basic
=== CONT  TestAccDataSyncLocationAzureBlob_tags
=== CONT  TestAccDataSyncLocationAzureBlob_disappears
--- PASS: TestAccDataSyncLocationAzureBlob_disappears (130.32s)
=== CONT  TestAccDataSyncLocationAzureBlob_update
--- PASS: TestAccDataSyncLocationAzureBlob_basic (130.91s)
--- PASS: TestAccDataSyncLocationAzureBlob_tags (202.34s)
--- PASS: TestAccDataSyncLocationAzureBlob_update (187.75s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datasync	322.954s
% make testacc TESTARGS='-run=TestAccDataSyncTask_' PKG=datasync ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 2  -run=TestAccDataSyncTask_ -timeout 180m
=== RUN   TestAccDataSyncTask_basic
=== PAUSE TestAccDataSyncTask_basic
=== RUN   TestAccDataSyncTask_disappears
=== PAUSE TestAccDataSyncTask_disappears
=== RUN   TestAccDataSyncTask_schedule
=== PAUSE TestAccDataSyncTask_schedule
=== RUN   TestAccDataSyncTask_cloudWatchLogGroupARN
=== PAUSE TestAccDataSyncTask_cloudWatchLogGroupARN
=== RUN   TestAccDataSyncTask_excludes
=== PAUSE TestAccDataSyncTask_excludes
=== RUN   TestAccDataSyncTask_includes
=== PAUSE TestAccDataSyncTask_includes
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_atimeMtime
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_atimeMtime
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_bytesPerSecond
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_bytesPerSecond
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_gid
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_gid
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_logLevel
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_logLevel
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_objectTags
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_objectTags
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_overwriteMode
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_overwriteMode
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_posixPermissions
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_posixPermissions
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_preserveDeletedFiles
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_preserveDeletedFiles
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_preserveDevices
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_preserveDevices
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_securityDescriptorCopyFlags
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_securityDescriptorCopyFlags
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_taskQueueing
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_taskQueueing
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_transferMode
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_transferMode
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_uid
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_uid
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_verifyMode
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_verifyMode
=== RUN   TestAccDataSyncTask_tags
=== PAUSE TestAccDataSyncTask_tags
=== CONT  TestAccDataSyncTask_basic
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_overwriteMode
--- PASS: TestAccDataSyncTask_basic (161.81s)
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_atimeMtime
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_overwriteMode (216.87s)
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_objectTags
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_atimeMtime (185.47s)
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_logLevel
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_objectTags (210.82s)
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_gid
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_logLevel (206.03s)
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_bytesPerSecond
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_gid (196.37s)
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_taskQueueing
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_bytesPerSecond (195.46s)
=== CONT  TestAccDataSyncTask_tags
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_taskQueueing (205.57s)
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_verifyMode
--- PASS: TestAccDataSyncTask_tags (207.08s)
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_uid
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_verifyMode (242.19s)
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_transferMode
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_uid (206.70s)
=== CONT  TestAccDataSyncTask_cloudWatchLogGroupARN
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_transferMode (209.00s)
=== CONT  TestAccDataSyncTask_includes
--- PASS: TestAccDataSyncTask_cloudWatchLogGroupARN (239.08s)
=== CONT  TestAccDataSyncTask_excludes
--- PASS: TestAccDataSyncTask_includes (236.69s)
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_preserveDevices
--- PASS: TestAccDataSyncTask_excludes (186.42s)
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_securityDescriptorCopyFlags
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_preserveDevices (184.83s)
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_posixPermissions
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_posixPermissions (195.09s)
=== CONT  TestAccDataSyncTask_schedule
--- PASS: TestAccDataSyncTask_schedule (205.17s)
=== CONT  TestAccDataSyncTask_disappears
--- PASS: TestAccDataSyncTask_disappears (147.72s)
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_preserveDeletedFiles
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_preserveDeletedFiles (215.35s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_securityDescriptorCopyFlags (3126.67s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datasync	4720.559s

@ewbankkit
Copy link
Contributor 

% make sweep SWEEPARGS=-sweep-run=aws_datasync_agent
# make sweep SWEEPARGS=-sweep-run=aws_example_thing
# set SWEEPARGS=-sweep-allow-failures to continue after first failure
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./internal/sweep -v -tags=sweep -sweep=us-west-2,us-east-1,us-east-2,us-west-1 -sweep-run=aws_datasync_agent -timeout 60m
2023/08/21 09:48:57 [DEBUG] Running Sweepers for region (us-west-2):
2023/08/21 09:48:57 [DEBUG] Sweeper (aws_datasync_location) has dependency (aws_datasync_task), running..
2023/08/21 09:48:57 [DEBUG] Running Sweeper (aws_datasync_task) in region (us-west-2)
2023/08/21 09:48:58 [DEBUG] Completed Sweeper (aws_datasync_task) in region (us-west-2) in 923.27252ms
2023/08/21 09:48:58 [DEBUG] Running Sweeper (aws_datasync_location) in region (us-west-2)
2023/08/21 09:48:58 [DEBUG] Completed Sweeper (aws_datasync_location) in region (us-west-2) in 116.937677ms
2023/08/21 09:48:58 [DEBUG] Sweeper (aws_datasync_agent) has dependency (aws_datasync_location), running..
2023/08/21 09:48:58 [DEBUG] Sweeper (aws_datasync_location) has dependency (aws_datasync_task), running..
2023/08/21 09:48:58 [DEBUG] Sweeper (aws_datasync_task) already ran in region (us-west-2)
2023/08/21 09:48:58 [DEBUG] Sweeper (aws_datasync_location) already ran in region (us-west-2)
2023/08/21 09:48:58 [DEBUG] Running Sweeper (aws_datasync_agent) in region (us-west-2)
2023/08/21 09:48:58 [DEBUG] Completed Sweeper (aws_datasync_agent) in region (us-west-2) in 108.258929ms
2023/08/21 09:48:58 [DEBUG] Sweeper (aws_datasync_task) already ran in region (us-west-2)
2023/08/21 09:48:58 Completed Sweepers for region (us-west-2) in 1.148962712s
2023/08/21 09:48:58 Sweeper Tests for region (us-west-2) ran successfully:
2023/08/21 09:48:58 	- aws_datasync_task
2023/08/21 09:48:58 	- aws_datasync_location
2023/08/21 09:48:58 	- aws_datasync_agent
2023/08/21 09:48:58 [DEBUG] Running Sweepers for region (us-east-1):
2023/08/21 09:48:58 [DEBUG] Sweeper (aws_datasync_location) has dependency (aws_datasync_task), running..
2023/08/21 09:48:58 [DEBUG] Running Sweeper (aws_datasync_task) in region (us-east-1)
2023/08/21 09:48:58 [DEBUG] Completed Sweeper (aws_datasync_task) in region (us-east-1) in 299.304144ms
2023/08/21 09:48:58 [DEBUG] Running Sweeper (aws_datasync_location) in region (us-east-1)
2023/08/21 09:48:58 [DEBUG] Completed Sweeper (aws_datasync_location) in region (us-east-1) in 51.658602ms
2023/08/21 09:48:58 [DEBUG] Sweeper (aws_datasync_agent) has dependency (aws_datasync_location), running..
2023/08/21 09:48:58 [DEBUG] Sweeper (aws_datasync_location) has dependency (aws_datasync_task), running..
2023/08/21 09:48:58 [DEBUG] Sweeper (aws_datasync_task) already ran in region (us-east-1)
2023/08/21 09:48:58 [DEBUG] Sweeper (aws_datasync_location) already ran in region (us-east-1)
2023/08/21 09:48:58 [DEBUG] Running Sweeper (aws_datasync_agent) in region (us-east-1)
2023/08/21 09:48:58 [DEBUG] Completed Sweeper (aws_datasync_agent) in region (us-east-1) in 49.850873ms
2023/08/21 09:48:58 [DEBUG] Sweeper (aws_datasync_task) already ran in region (us-east-1)
2023/08/21 09:48:58 Completed Sweepers for region (us-east-1) in 400.982271ms
2023/08/21 09:48:58 Sweeper Tests for region (us-east-1) ran successfully:
2023/08/21 09:48:58 	- aws_datasync_agent
2023/08/21 09:48:58 	- aws_datasync_task
2023/08/21 09:48:58 	- aws_datasync_location
2023/08/21 09:48:58 [DEBUG] Running Sweepers for region (us-east-2):
2023/08/21 09:48:58 [DEBUG] Sweeper (aws_datasync_location) has dependency (aws_datasync_task), running..
2023/08/21 09:48:58 [DEBUG] Running Sweeper (aws_datasync_task) in region (us-east-2)
2023/08/21 09:48:59 [DEBUG] Completed Sweeper (aws_datasync_task) in region (us-east-2) in 399.850401ms
2023/08/21 09:48:59 [DEBUG] Running Sweeper (aws_datasync_location) in region (us-east-2)
2023/08/21 09:48:59 [DEBUG] Completed Sweeper (aws_datasync_location) in region (us-east-2) in 57.30942ms
2023/08/21 09:48:59 [DEBUG] Sweeper (aws_datasync_agent) has dependency (aws_datasync_location), running..
2023/08/21 09:48:59 [DEBUG] Sweeper (aws_datasync_location) has dependency (aws_datasync_task), running..
2023/08/21 09:48:59 [DEBUG] Sweeper (aws_datasync_task) already ran in region (us-east-2)
2023/08/21 09:48:59 [DEBUG] Sweeper (aws_datasync_location) already ran in region (us-east-2)
2023/08/21 09:48:59 [DEBUG] Running Sweeper (aws_datasync_agent) in region (us-east-2)
2023/08/21 09:48:59 [DEBUG] Completed Sweeper (aws_datasync_agent) in region (us-east-2) in 46.430371ms
2023/08/21 09:48:59 [DEBUG] Sweeper (aws_datasync_task) already ran in region (us-east-2)
2023/08/21 09:48:59 Completed Sweepers for region (us-east-2) in 503.794353ms
2023/08/21 09:48:59 Sweeper Tests for region (us-east-2) ran successfully:
2023/08/21 09:48:59 	- aws_datasync_task
2023/08/21 09:48:59 	- aws_datasync_location
2023/08/21 09:48:59 	- aws_datasync_agent
2023/08/21 09:48:59 [DEBUG] Running Sweepers for region (us-west-1):
2023/08/21 09:48:59 [DEBUG] Sweeper (aws_datasync_location) has dependency (aws_datasync_task), running..
2023/08/21 09:48:59 [DEBUG] Running Sweeper (aws_datasync_task) in region (us-west-1)
2023/08/21 09:48:59 [DEBUG] Completed Sweeper (aws_datasync_task) in region (us-west-1) in 830.418774ms
2023/08/21 09:48:59 [DEBUG] Running Sweeper (aws_datasync_location) in region (us-west-1)
2023/08/21 09:49:00 [DEBUG] Completed Sweeper (aws_datasync_location) in region (us-west-1) in 106.972382ms
2023/08/21 09:49:00 [DEBUG] Sweeper (aws_datasync_agent) has dependency (aws_datasync_location), running..
2023/08/21 09:49:00 [DEBUG] Sweeper (aws_datasync_location) has dependency (aws_datasync_task), running..
2023/08/21 09:49:00 [DEBUG] Sweeper (aws_datasync_task) already ran in region (us-west-1)
2023/08/21 09:49:00 [DEBUG] Sweeper (aws_datasync_location) already ran in region (us-west-1)
2023/08/21 09:49:00 [DEBUG] Running Sweeper (aws_datasync_agent) in region (us-west-1)
2023/08/21 09:49:00 [DEBUG] Completed Sweeper (aws_datasync_agent) in region (us-west-1) in 99.039275ms
2023/08/21 09:49:00 [DEBUG] Sweeper (aws_datasync_task) already ran in region (us-west-1)
2023/08/21 09:49:00 Completed Sweepers for region (us-west-1) in 1.036597856s
2023/08/21 09:49:00 Sweeper Tests for region (us-west-1) ran successfully:
2023/08/21 09:49:00 	- aws_datasync_task
2023/08/21 09:49:00 	- aws_datasync_location
2023/08/21 09:49:00 	- aws_datasync_agent
ok  	github.com/hashicorp/terraform-provider-aws/internal/sweep	8.423s

@ewbankkit
Copy link
Contributor

@R-Campbell Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 62a7772 into hashicorp:main Aug 21, 2023
41 checks passed
@github-actions github-actions bot added this to the v5.14.0 milestone Aug 21, 2023
@github-actions
Copy link

This functionality has been released in v5.14.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@ewbankkit ewbankkit mentioned this pull request Aug 29, 2023
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/datasync Issues and PRs that pertain to the datasync service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.14.0
Development

Successfully merging this pull request may close these issues.

[New]: datasync ontap location support
3 participants
@R-Campbell @ewbankkit @justinretzolk