-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize start time and end time value avoid null override #33713
Initialize start time and end time value avoid null override #33713
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @yaput 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
# Conflicts: # internal/service/appautoscaling/scheduled_action.go # internal/service/appautoscaling/scheduled_action_test.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAppAutoScalingScheduledAction_ecs' PKG=appautoscaling ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/appautoscaling/... -v -count 1 -parallel 3 -run=TestAccAppAutoScalingScheduledAction_ecs -timeout 360m
=== RUN TestAccAppAutoScalingScheduledAction_ecs
=== PAUSE TestAccAppAutoScalingScheduledAction_ecs
=== RUN TestAccAppAutoScalingScheduledAction_ecsUpdateScheduleRetainStartAndEndTime
=== PAUSE TestAccAppAutoScalingScheduledAction_ecsUpdateScheduleRetainStartAndEndTime
=== RUN TestAccAppAutoScalingScheduledAction_ecsUpdateStartAndEndTime
=== PAUSE TestAccAppAutoScalingScheduledAction_ecsUpdateStartAndEndTime
=== RUN TestAccAppAutoScalingScheduledAction_ecsAddStartTimeAndEndTimeAfterResourceCreated
=== PAUSE TestAccAppAutoScalingScheduledAction_ecsAddStartTimeAndEndTimeAfterResourceCreated
=== CONT TestAccAppAutoScalingScheduledAction_ecs
=== CONT TestAccAppAutoScalingScheduledAction_ecsUpdateStartAndEndTime
=== CONT TestAccAppAutoScalingScheduledAction_ecsAddStartTimeAndEndTimeAfterResourceCreated
--- PASS: TestAccAppAutoScalingScheduledAction_ecs (81.16s)
=== CONT TestAccAppAutoScalingScheduledAction_ecsUpdateScheduleRetainStartAndEndTime
--- PASS: TestAccAppAutoScalingScheduledAction_ecsAddStartTimeAndEndTimeAfterResourceCreated (85.24s)
--- PASS: TestAccAppAutoScalingScheduledAction_ecsUpdateStartAndEndTime (85.34s)
--- PASS: TestAccAppAutoScalingScheduledAction_ecsUpdateScheduleRetainStartAndEndTime (79.32s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/appautoscaling 166.985s
@yaput Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.42.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Initialize
StartTime
andEndTime
for aws scheduled action parameter from current existing values.Relations
Closes #33708
Closes #32616
References
Output from Acceptance Testing