Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize start time and end time value avoid null override #33713

Conversation

yaput
Copy link
Contributor

@yaput yaput commented Oct 2, 2023

Description

Initialize StartTime and EndTime for aws scheduled action parameter from current existing values.

Relations

Closes #33708
Closes #32616

References

Output from Acceptance Testing

% make testacc TESTS=TestAccAppAutoScalingScheduledAction_UpdateScheduleRetainStartAndEndTime_ecs PKG=appautoscaling
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appautoscaling/... -v -count 1 -parallel 20 -run='TestAccAppAutoScalingScheduledAction_UpdateScheduleRetainStartAndEndTime_ecs'  -timeout 360m
=== RUN   TestAccAppAutoScalingScheduledAction_UpdateScheduleRetainStartAndEndTime_ecs
=== PAUSE TestAccAppAutoScalingScheduledAction_UpdateScheduleRetainStartAndEndTime_ecs
=== CONT  TestAccAppAutoScalingScheduledAction_UpdateScheduleRetainStartAndEndTime_ecs
--- PASS: TestAccAppAutoScalingScheduledAction_UpdateScheduleRetainStartAndEndTime_ecs (93.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appautoscaling	95.967s
% make testacc TESTS=TestAccAppAutoScalingScheduledAction_UpdateStartAndEndTime_ecs PKG=appautoscaling
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appautoscaling/... -v -count 1 -parallel 20 -run='TestAccAppAutoScalingScheduledAction_UpdateStartAndEndTime_ecs'  -timeout 360m
=== RUN   TestAccAppAutoScalingScheduledAction_UpdateStartAndEndTime_ecs
=== PAUSE TestAccAppAutoScalingScheduledAction_UpdateStartAndEndTime_ecs
=== CONT  TestAccAppAutoScalingScheduledAction_UpdateStartAndEndTime_ecs
--- PASS: TestAccAppAutoScalingScheduledAction_UpdateStartAndEndTime_ecs (88.49s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appautoscaling	90.601s
%  make testacc TESTS=TestAccAppAutoScalingScheduledAction_AddStartTimeAndEndTimeAfterResourceCreated_ecs PKG=appautoscaling
TF_ACC=1 go test ./internal/service/appautoscaling/... -v -count 1 -parallel 20 -run='TestAccAppAutoScalingScheduledAction_AddStartTimeAndEndTimeAfterResourceCreated_ecs'  -timeout 360m
=== RUN   TestAccAppAutoScalingScheduledAction_AddStartTimeAndEndTimeAfterResourceCreated_ecs
=== PAUSE TestAccAppAutoScalingScheduledAction_AddStartTimeAndEndTimeAfterResourceCreated_ecs
=== CONT  TestAccAppAutoScalingScheduledAction_AddStartTimeAndEndTimeAfterResourceCreated_ecs
--- PASS: TestAccAppAutoScalingScheduledAction_AddStartTimeAndEndTimeAfterResourceCreated_ecs (73.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appautoscaling	75.917s

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/appautoscaling Issues and PRs that pertain to the appautoscaling service. labels Oct 2, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 2, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @yaput 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@yaput yaput marked this pull request as ready for review October 2, 2023 08:31
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 26, 2023
# Conflicts:
#	internal/service/appautoscaling/scheduled_action.go
#	internal/service/appautoscaling/scheduled_action_test.go
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAppAutoScalingScheduledAction_ecs' PKG=appautoscaling ACCTEST_PARALLELISM=3      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/appautoscaling/... -v -count 1 -parallel 3  -run=TestAccAppAutoScalingScheduledAction_ecs -timeout 360m
=== RUN   TestAccAppAutoScalingScheduledAction_ecs
=== PAUSE TestAccAppAutoScalingScheduledAction_ecs
=== RUN   TestAccAppAutoScalingScheduledAction_ecsUpdateScheduleRetainStartAndEndTime
=== PAUSE TestAccAppAutoScalingScheduledAction_ecsUpdateScheduleRetainStartAndEndTime
=== RUN   TestAccAppAutoScalingScheduledAction_ecsUpdateStartAndEndTime
=== PAUSE TestAccAppAutoScalingScheduledAction_ecsUpdateStartAndEndTime
=== RUN   TestAccAppAutoScalingScheduledAction_ecsAddStartTimeAndEndTimeAfterResourceCreated
=== PAUSE TestAccAppAutoScalingScheduledAction_ecsAddStartTimeAndEndTimeAfterResourceCreated
=== CONT  TestAccAppAutoScalingScheduledAction_ecs
=== CONT  TestAccAppAutoScalingScheduledAction_ecsUpdateStartAndEndTime
=== CONT  TestAccAppAutoScalingScheduledAction_ecsAddStartTimeAndEndTimeAfterResourceCreated
--- PASS: TestAccAppAutoScalingScheduledAction_ecs (81.16s)
=== CONT  TestAccAppAutoScalingScheduledAction_ecsUpdateScheduleRetainStartAndEndTime
--- PASS: TestAccAppAutoScalingScheduledAction_ecsAddStartTimeAndEndTimeAfterResourceCreated (85.24s)
--- PASS: TestAccAppAutoScalingScheduledAction_ecsUpdateStartAndEndTime (85.34s)
--- PASS: TestAccAppAutoScalingScheduledAction_ecsUpdateScheduleRetainStartAndEndTime (79.32s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appautoscaling	166.985s

@ewbankkit
Copy link
Contributor

@yaput Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 97505d5 into hashicorp:main Mar 18, 2024
36 checks passed
@github-actions github-actions bot added this to the v5.42.0 milestone Mar 18, 2024
Copy link

This functionality has been released in v5.42.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2024
@yaput yaput deleted the b-aws_scheduled_action_missing_startTime_endTime branch May 10, 2024 02:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/appautoscaling Issues and PRs that pertain to the appautoscaling service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
3 participants