-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Udpate EKS to use aws-sdk-go-v2 #34114
feat: Udpate EKS to use aws-sdk-go-v2 #34114
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
|
…ed with AWS SDK for Go v2." This reverts commit fb97974.
2a3cc81
to
9d99201
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccSTSCallerIdentityDataSource_' PKG=sts
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sts/... -v -count 1 -parallel 20 -run=TestAccSTSCallerIdentityDataSource_ -timeout 360m
=== RUN TestAccSTSCallerIdentityDataSource_basic
=== PAUSE TestAccSTSCallerIdentityDataSource_basic
=== CONT TestAccSTSCallerIdentityDataSource_basic
--- PASS: TestAccSTSCallerIdentityDataSource_basic (15.52s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/sts 20.899s
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccEKSCluster' PKG=eks ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 4 -run=TestAccEKSCluster -timeout 720m
=== RUN TestAccEKSClusterAuthDataSource_basic
=== PAUSE TestAccEKSClusterAuthDataSource_basic
=== RUN TestAccEKSClusterDataSource_basic
=== PAUSE TestAccEKSClusterDataSource_basic
=== RUN TestAccEKSClusterDataSource_outpost
=== PAUSE TestAccEKSClusterDataSource_outpost
=== RUN TestAccEKSCluster_basic
=== PAUSE TestAccEKSCluster_basic
=== RUN TestAccEKSCluster_disappears
=== PAUSE TestAccEKSCluster_disappears
=== RUN TestAccEKSCluster_Encryption_create
=== PAUSE TestAccEKSCluster_Encryption_create
=== RUN TestAccEKSCluster_Encryption_update
=== PAUSE TestAccEKSCluster_Encryption_update
=== RUN TestAccEKSCluster_Encryption_versionUpdate
=== PAUSE TestAccEKSCluster_Encryption_versionUpdate
=== RUN TestAccEKSCluster_version
=== PAUSE TestAccEKSCluster_version
=== RUN TestAccEKSCluster_logging
=== PAUSE TestAccEKSCluster_logging
=== RUN TestAccEKSCluster_tags
=== PAUSE TestAccEKSCluster_tags
=== RUN TestAccEKSCluster_VPC_securityGroupIDs
=== PAUSE TestAccEKSCluster_VPC_securityGroupIDs
=== RUN TestAccEKSCluster_VPC_securityGroupIDsAndSubnetIDs_update
=== PAUSE TestAccEKSCluster_VPC_securityGroupIDsAndSubnetIDs_update
=== RUN TestAccEKSCluster_VPC_endpointPrivateAccess
=== PAUSE TestAccEKSCluster_VPC_endpointPrivateAccess
=== RUN TestAccEKSCluster_VPC_endpointPublicAccess
=== PAUSE TestAccEKSCluster_VPC_endpointPublicAccess
=== RUN TestAccEKSCluster_VPC_publicAccessCIDRs
=== PAUSE TestAccEKSCluster_VPC_publicAccessCIDRs
=== RUN TestAccEKSCluster_Network_serviceIPv4CIDR
=== PAUSE TestAccEKSCluster_Network_serviceIPv4CIDR
=== RUN TestAccEKSCluster_Network_ipFamily
=== PAUSE TestAccEKSCluster_Network_ipFamily
=== RUN TestAccEKSCluster_Outpost_create
=== PAUSE TestAccEKSCluster_Outpost_create
=== RUN TestAccEKSCluster_Outpost_placement
=== PAUSE TestAccEKSCluster_Outpost_placement
=== RUN TestAccEKSClustersDataSource_basic
=== PAUSE TestAccEKSClustersDataSource_basic
=== CONT TestAccEKSClusterAuthDataSource_basic
=== CONT TestAccEKSClustersDataSource_basic
=== CONT TestAccEKSCluster_tags
=== CONT TestAccEKSCluster_Encryption_create
--- PASS: TestAccEKSClusterAuthDataSource_basic (18.57s)
=== CONT TestAccEKSCluster_logging
--- PASS: TestAccEKSCluster_logging (917.81s)
=== CONT TestAccEKSCluster_version
--- PASS: TestAccEKSCluster_version (1255.65s)
=== CONT TestAccEKSCluster_Encryption_versionUpdate
--- PASS: TestAccEKSCluster_Encryption_versionUpdate (1258.63s)
=== CONT TestAccEKSCluster_Encryption_update
--- PASS: TestAccEKSClustersDataSource_basic (580.01s)
=== CONT TestAccEKSCluster_basic
--- PASS: TestAccEKSCluster_tags (582.66s)
=== CONT TestAccEKSCluster_disappears
--- PASS: TestAccEKSCluster_Encryption_create (635.32s)
=== CONT TestAccEKSClusterDataSource_basic
--- PASS: TestAccEKSClusterDataSource_basic (559.13s)
=== CONT TestAccEKSCluster_VPC_publicAccessCIDRs
--- PASS: TestAccEKSCluster_basic (612.81s)
=== CONT TestAccEKSCluster_Outpost_placement
acctest.go:1137: skipping since no Outposts found
--- SKIP: TestAccEKSCluster_Outpost_placement (0.47s)
=== CONT TestAccEKSCluster_Outpost_create
acctest.go:1137: skipping since no Outposts found
--- SKIP: TestAccEKSCluster_Outpost_create (0.19s)
--- PASS: TestAccEKSCluster_Network_ipFamily (1321.66s)
=== CONT TestAccEKSCluster_Network_serviceIPv4CIDR
--- PASS: TestAccEKSCluster_disappears (799.40s)
=== CONT TestAccEKSCluster_VPC_endpointPrivateAccess
--- PASS: TestAccEKSCluster_VPC_publicAccessCIDRs (965.18s)
=== CONT TestAccEKSCluster_VPC_endpointPublicAccess
--- PASS: TestAccEKSCluster_Encryption_update (1507.48s)
=== CONT TestAccEKSCluster_VPC_securityGroupIDsAndSubnetIDs_update
--- PASS: TestAccEKSCluster_Network_serviceIPv4CIDR (1145.62s)
=== CONT TestAccEKSCluster_VPC_securityGroupIDs
--- PASS: TestAccEKSCluster_VPC_endpointPublicAccess (1127.09s)
=== CONT TestAccEKSClusterDataSource_outpost
acctest.go:1137: skipping since no Outposts found
--- SKIP: TestAccEKSClusterDataSource_outpost (0.46s)
--- PASS: TestAccEKSCluster_VPC_endpointPrivateAccess (1560.28s)
--- PASS: TestAccEKSCluster_VPC_securityGroupIDs (617.04s)
--- PASS: TestAccEKSCluster_VPC_securityGroupIDsAndSubnetIDs_update (1459.81s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/eks 3101.992s
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccEKSAddon\|TestAccEKSFargateProfile_\|TestAccEKSIdentityProviderConfig_' PKG=eks ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 4 -run=TestAccEKSAddon\|TestAccEKSFargateProfile_\|TestAccEKSIdentityProviderConfig_ -timeout 720m
=== RUN TestAccEKSAddonDataSource_basic
=== PAUSE TestAccEKSAddonDataSource_basic
=== RUN TestAccEKSAddonDataSource_configurationValues
=== PAUSE TestAccEKSAddonDataSource_configurationValues
=== RUN TestAccEKSAddon_basic
=== PAUSE TestAccEKSAddon_basic
=== RUN TestAccEKSAddon_disappears
=== PAUSE TestAccEKSAddon_disappears
=== RUN TestAccEKSAddon_Disappears_cluster
=== PAUSE TestAccEKSAddon_Disappears_cluster
=== RUN TestAccEKSAddon_addonVersion
=== PAUSE TestAccEKSAddon_addonVersion
=== RUN TestAccEKSAddon_preserve
=== PAUSE TestAccEKSAddon_preserve
=== RUN TestAccEKSAddon_deprecated
=== PAUSE TestAccEKSAddon_deprecated
=== RUN TestAccEKSAddon_resolveConflicts
=== PAUSE TestAccEKSAddon_resolveConflicts
=== RUN TestAccEKSAddon_serviceAccountRoleARN
=== PAUSE TestAccEKSAddon_serviceAccountRoleARN
=== RUN TestAccEKSAddon_configurationValues
=== PAUSE TestAccEKSAddon_configurationValues
=== RUN TestAccEKSAddon_tags
=== PAUSE TestAccEKSAddon_tags
=== RUN TestAccEKSAddonVersionDataSource_basic
=== PAUSE TestAccEKSAddonVersionDataSource_basic
=== RUN TestAccEKSFargateProfile_basic
=== PAUSE TestAccEKSFargateProfile_basic
=== RUN TestAccEKSFargateProfile_disappears
=== PAUSE TestAccEKSFargateProfile_disappears
=== RUN TestAccEKSFargateProfile_Multi_profile
=== PAUSE TestAccEKSFargateProfile_Multi_profile
=== RUN TestAccEKSFargateProfile_Selector_labels
=== PAUSE TestAccEKSFargateProfile_Selector_labels
=== RUN TestAccEKSFargateProfile_tags
=== PAUSE TestAccEKSFargateProfile_tags
=== RUN TestAccEKSIdentityProviderConfig_basic
=== PAUSE TestAccEKSIdentityProviderConfig_basic
=== RUN TestAccEKSIdentityProviderConfig_disappears
=== PAUSE TestAccEKSIdentityProviderConfig_disappears
=== RUN TestAccEKSIdentityProviderConfig_allOIDCOptions
=== PAUSE TestAccEKSIdentityProviderConfig_allOIDCOptions
=== RUN TestAccEKSIdentityProviderConfig_tags
=== PAUSE TestAccEKSIdentityProviderConfig_tags
=== CONT TestAccEKSAddonDataSource_basic
=== CONT TestAccEKSAddon_tags
=== CONT TestAccEKSFargateProfile_tags
=== CONT TestAccEKSIdentityProviderConfig_allOIDCOptions
--- PASS: TestAccEKSAddon_tags (1020.60s)
=== CONT TestAccEKSIdentityProviderConfig_tags
--- PASS: TestAccEKSAddonDataSource_basic (1179.69s)
=== CONT TestAccEKSFargateProfile_basic
--- PASS: TestAccEKSFargateProfile_tags (1358.77s)
=== CONT TestAccEKSFargateProfile_disappears
--- PASS: TestAccEKSIdentityProviderConfig_allOIDCOptions (1833.59s)
=== CONT TestAccEKSIdentityProviderConfig_disappears
--- PASS: TestAccEKSFargateProfile_basic (893.77s)
=== CONT TestAccEKSFargateProfile_Selector_labels
--- PASS: TestAccEKSFargateProfile_disappears (885.65s)
=== CONT TestAccEKSAddonVersionDataSource_basic
--- PASS: TestAccEKSIdentityProviderConfig_tags (1516.83s)
=== CONT TestAccEKSAddon_preserve
--- PASS: TestAccEKSAddonVersionDataSource_basic (714.46s)
=== CONT TestAccEKSAddon_configurationValues
--- PASS: TestAccEKSAddon_preserve (537.79s)
=== CONT TestAccEKSAddon_serviceAccountRoleARN
--- PASS: TestAccEKSFargateProfile_Selector_labels (1079.02s)
=== CONT TestAccEKSFargateProfile_Multi_profile
--- PASS: TestAccEKSIdentityProviderConfig_disappears (1446.83s)
=== CONT TestAccEKSAddon_resolveConflicts
--- PASS: TestAccEKSAddonDataSource_configurationValues (726.61s)
=== CONT TestAccEKSIdentityProviderConfig_basic
--- PASS: TestAccEKSAddon_serviceAccountRoleARN (694.21s)
=== CONT TestAccEKSAddon_disappears
--- PASS: TestAccEKSAddon_resolveConflicts (598.74s)
=== CONT TestAccEKSAddon_addonVersion
--- PASS: TestAccEKSFargateProfile_Multi_profile (1050.35s)
=== CONT TestAccEKSAddon_deprecated
--- PASS: TestAccEKSAddon_disappears (539.71s)
=== CONT TestAccEKSAddon_Disappears_cluster
--- PASS: TestAccEKSAddon_addonVersion (765.77s)
=== CONT TestAccEKSAddon_basic
--- PASS: TestAccEKSAddon_Disappears_cluster (596.31s)
=== CONT TestAccEKSAddonDataSource_configurationValues
--- PASS: TestAccEKSAddon_deprecated (715.09s)
--- PASS: TestAccEKSAddon_basic (598.22s)
--- PASS: TestAccEKSIdentityProviderConfig_basic (1489.65s)
--- PASS: TestAccEKSAddonDataSource_configurationValues (726.61s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/eks 5516.796s
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccEKSNodeGroup' PKG=eks ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 4 -run=TestAccEKSNodeGroup -timeout 720m
=== RUN TestAccEKSNodeGroupDataSource_basic
--- PASS: TestAccEKSNodeGroupDataSource_basic (1272.58s)
=== RUN TestAccEKSNodeGroup_basic
=== PAUSE TestAccEKSNodeGroup_basic
=== RUN TestAccEKSNodeGroup_Name_generated
=== PAUSE TestAccEKSNodeGroup_Name_generated
=== RUN TestAccEKSNodeGroup_namePrefix
=== PAUSE TestAccEKSNodeGroup_namePrefix
=== RUN TestAccEKSNodeGroup_disappears
=== PAUSE TestAccEKSNodeGroup_disappears
=== RUN TestAccEKSNodeGroup_amiType
=== PAUSE TestAccEKSNodeGroup_amiType
=== RUN TestAccEKSNodeGroup_CapacityType_spot
=== PAUSE TestAccEKSNodeGroup_CapacityType_spot
=== RUN TestAccEKSNodeGroup_diskSize
=== PAUSE TestAccEKSNodeGroup_diskSize
=== RUN TestAccEKSNodeGroup_forceUpdateVersion
=== PAUSE TestAccEKSNodeGroup_forceUpdateVersion
=== RUN TestAccEKSNodeGroup_InstanceTypes_multiple
=== PAUSE TestAccEKSNodeGroup_InstanceTypes_multiple
=== RUN TestAccEKSNodeGroup_InstanceTypes_single
=== PAUSE TestAccEKSNodeGroup_InstanceTypes_single
=== RUN TestAccEKSNodeGroup_labels
=== PAUSE TestAccEKSNodeGroup_labels
=== RUN TestAccEKSNodeGroup_LaunchTemplate_id
=== PAUSE TestAccEKSNodeGroup_LaunchTemplate_id
=== RUN TestAccEKSNodeGroup_LaunchTemplate_name
=== PAUSE TestAccEKSNodeGroup_LaunchTemplate_name
=== RUN TestAccEKSNodeGroup_LaunchTemplate_version
=== PAUSE TestAccEKSNodeGroup_LaunchTemplate_version
=== RUN TestAccEKSNodeGroup_releaseVersion
=== PAUSE TestAccEKSNodeGroup_releaseVersion
=== RUN TestAccEKSNodeGroup_RemoteAccess_ec2SSHKey
=== PAUSE TestAccEKSNodeGroup_RemoteAccess_ec2SSHKey
=== RUN TestAccEKSNodeGroup_RemoteAccess_sourceSecurityGroupIDs
=== PAUSE TestAccEKSNodeGroup_RemoteAccess_sourceSecurityGroupIDs
=== RUN TestAccEKSNodeGroup_Scaling_desiredSize
=== PAUSE TestAccEKSNodeGroup_Scaling_desiredSize
=== RUN TestAccEKSNodeGroup_Scaling_maxSize
=== PAUSE TestAccEKSNodeGroup_Scaling_maxSize
=== RUN TestAccEKSNodeGroup_Scaling_minSize
=== PAUSE TestAccEKSNodeGroup_Scaling_minSize
=== RUN TestAccEKSNodeGroup_ScalingZeroDesiredSize_minSize
=== PAUSE TestAccEKSNodeGroup_ScalingZeroDesiredSize_minSize
=== RUN TestAccEKSNodeGroup_tags
=== PAUSE TestAccEKSNodeGroup_tags
=== RUN TestAccEKSNodeGroup_taints
=== PAUSE TestAccEKSNodeGroup_taints
=== RUN TestAccEKSNodeGroup_update
=== PAUSE TestAccEKSNodeGroup_update
=== RUN TestAccEKSNodeGroup_version
=== PAUSE TestAccEKSNodeGroup_version
=== RUN TestAccEKSNodeGroupsDataSource_basic
--- PASS: TestAccEKSNodeGroupsDataSource_basic (1011.74s)
=== CONT TestAccEKSNodeGroup_basic
=== CONT TestAccEKSNodeGroup_LaunchTemplate_version
=== CONT TestAccEKSNodeGroup_version
=== CONT TestAccEKSNodeGroup_update
--- PASS: TestAccEKSNodeGroup_basic (1179.98s)
=== CONT TestAccEKSNodeGroup_taints
--- PASS: TestAccEKSNodeGroup_update (1339.78s)
=== CONT TestAccEKSNodeGroup_forceUpdateVersion
--- PASS: TestAccEKSNodeGroup_LaunchTemplate_version (1704.22s)
=== CONT TestAccEKSNodeGroup_tags
--- PASS: TestAccEKSNodeGroup_version (2019.73s)
=== CONT TestAccEKSNodeGroup_ScalingZeroDesiredSize_minSize
--- PASS: TestAccEKSNodeGroup_taints (984.76s)
=== CONT TestAccEKSNodeGroup_LaunchTemplate_name
--- PASS: TestAccEKSNodeGroup_ScalingZeroDesiredSize_minSize (790.90s)
=== CONT TestAccEKSNodeGroup_Scaling_minSize
--- PASS: TestAccEKSNodeGroup_tags (1335.89s)
=== CONT TestAccEKSNodeGroup_LaunchTemplate_id
--- PASS: TestAccEKSNodeGroup_forceUpdateVersion (2426.18s)
=== CONT TestAccEKSNodeGroup_Scaling_maxSize
--- PASS: TestAccEKSNodeGroup_Scaling_minSize (1192.74s)
=== CONT TestAccEKSNodeGroup_labels
--- PASS: TestAccEKSNodeGroup_LaunchTemplate_name (1921.76s)
=== CONT TestAccEKSNodeGroup_Scaling_desiredSize
--- PASS: TestAccEKSNodeGroup_LaunchTemplate_id (1987.45s)
=== CONT TestAccEKSNodeGroup_RemoteAccess_sourceSecurityGroupIDs
--- PASS: TestAccEKSNodeGroup_Scaling_maxSize (1300.81s)
=== CONT TestAccEKSNodeGroup_InstanceTypes_single
--- PASS: TestAccEKSNodeGroup_Scaling_desiredSize (1336.29s)
=== CONT TestAccEKSNodeGroup_RemoteAccess_ec2SSHKey
--- PASS: TestAccEKSNodeGroup_labels (1597.44s)
=== CONT TestAccEKSNodeGroup_InstanceTypes_multiple
--- PASS: TestAccEKSNodeGroup_InstanceTypes_single (1245.15s)
=== CONT TestAccEKSNodeGroup_releaseVersion
node_group_test.go:523: Step 1/3 error: After applying this test step, the plan was not empty.
stdout:
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
<= read (data resources)
Terraform will perform the following actions:
# data.aws_ssm_parameter.test will be read during apply
# (config refers to values not yet known)
<= data "aws_ssm_parameter" "test" {
~ arn = "arn:aws:ssm:us-west-2::parameter/aws/service/eks/optimized-ami/1.27/amazon-linux-2/recommended/release_version" -> (known after apply)
~ id = "/aws/service/eks/optimized-ami/1.27/amazon-linux-2/recommended/release_version" -> (known after apply)
~ insecure_value = "1.27.6-20231027" -> (known after apply)
name = "/aws/service/eks/optimized-ami/1.27/amazon-linux-2/recommended/release_version"
~ type = "String" -> (known after apply)
~ value = (sensitive value)
~ version = 11 -> (known after apply)
- with_decryption = true -> null
}
# aws_eks_cluster.test will be updated in-place
~ resource "aws_eks_cluster" "test" {
id = "tf-acc-test-83368561313263405"
name = "tf-acc-test-83368561313263405"
~ tags = {
- "AWS.SSM.AppManager.EKS.Cluster.ARN" = "arn:aws:eks:us-west-2:123456789012:cluster/tf-acc-test-83368561313263405" -> null
}
~ tags_all = {
- "AWS.SSM.AppManager.EKS.Cluster.ARN" = "arn:aws:eks:us-west-2:123456789012:cluster/tf-acc-test-83368561313263405"
} -> (known after apply)
# (9 unchanged attributes hidden)
~ vpc_config {
+ security_group_ids = []
# (6 unchanged attributes hidden)
}
# (1 unchanged block hidden)
}
# aws_eks_node_group.test will be updated in-place
~ resource "aws_eks_node_group" "test" {
id = "tf-acc-test-83368561313263405:tf-acc-test-83368561313263405"
~ release_version = (sensitive) -> (sensitive)
# (14 unchanged attributes hidden)
# (2 unchanged blocks hidden)
}
Plan: 0 to add, 2 to change, 0 to destroy.
--- FAIL: TestAccEKSNodeGroup_releaseVersion (914.95s)
=== CONT TestAccEKSNodeGroup_amiType
--- PASS: TestAccEKSNodeGroup_RemoteAccess_sourceSecurityGroupIDs (1322.31s)
=== CONT TestAccEKSNodeGroup_namePrefix
--- PASS: TestAccEKSNodeGroup_RemoteAccess_ec2SSHKey (1252.59s)
=== CONT TestAccEKSNodeGroup_diskSize
--- PASS: TestAccEKSNodeGroup_InstanceTypes_multiple (1124.89s)
=== CONT TestAccEKSNodeGroup_disappears
--- PASS: TestAccEKSNodeGroup_namePrefix (1239.68s)
=== CONT TestAccEKSNodeGroup_CapacityType_spot
--- PASS: TestAccEKSNodeGroup_diskSize (1183.42s)
=== CONT TestAccEKSNodeGroup_Name_generated
--- PASS: TestAccEKSNodeGroup_disappears (1296.72s)
--- PASS: TestAccEKSNodeGroup_amiType (1807.20s)
--- PASS: TestAccEKSNodeGroup_CapacityType_spot (1179.87s)
--- PASS: TestAccEKSNodeGroup_Name_generated (1332.48s)
FAIL
FAIL github.com/hashicorp/terraform-provider-aws/internal/service/eks 11481.331s
Failure is unrelated to this change.
@bryantbiggs Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Relations
Relates #32976
References
Output from Acceptance Testing