TechDebt: Migrate `deploy` service to `aws-sdk-go-v2` #34282

brittandeyoung · 2023-11-06T19:32:17Z

Description

This pull request converts the deploy service to use the aws-sdk-go-v2.

Relations

References

Output from Acceptance Testing

➜ terraform-provider-aws (td-deploy-aws-sdk-go-v2) ✔ make testacc TESTARGS='-run=TestAccDeploy' PKG=deploy 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/deploy/... -v -count 1 -parallel 20  -run=TestAccDeploy -timeout 360m
=== RUN   TestAccDeployApp_basic
=== PAUSE TestAccDeployApp_basic
=== RUN   TestAccDeployApp_computePlatform
=== PAUSE TestAccDeployApp_computePlatform
=== RUN   TestAccDeployApp_ComputePlatform_ecs
=== PAUSE TestAccDeployApp_ComputePlatform_ecs
=== RUN   TestAccDeployApp_ComputePlatform_lambda
=== PAUSE TestAccDeployApp_ComputePlatform_lambda
=== RUN   TestAccDeployApp_name
=== PAUSE TestAccDeployApp_name
=== RUN   TestAccDeployApp_tags
=== PAUSE TestAccDeployApp_tags
=== RUN   TestAccDeployApp_disappears
=== PAUSE TestAccDeployApp_disappears
=== RUN   TestAccDeployDeploymentConfig_basic
=== PAUSE TestAccDeployDeploymentConfig_basic
=== RUN   TestAccDeployDeploymentConfig_fleetPercent
=== PAUSE TestAccDeployDeploymentConfig_fleetPercent
=== RUN   TestAccDeployDeploymentConfig_hostCount
=== PAUSE TestAccDeployDeploymentConfig_hostCount
=== RUN   TestAccDeployDeploymentConfig_trafficCanary
=== PAUSE TestAccDeployDeploymentConfig_trafficCanary
=== RUN   TestAccDeployDeploymentConfig_trafficLinear
=== PAUSE TestAccDeployDeploymentConfig_trafficLinear
=== RUN   TestAccDeployDeploymentGroup_basic
=== PAUSE TestAccDeployDeploymentGroup_basic
=== RUN   TestAccDeployDeploymentGroup_Basic_tagSet
=== PAUSE TestAccDeployDeploymentGroup_Basic_tagSet
=== RUN   TestAccDeployDeploymentGroup_onPremiseTag
=== PAUSE TestAccDeployDeploymentGroup_onPremiseTag
=== RUN   TestAccDeployDeploymentGroup_disappears
=== PAUSE TestAccDeployDeploymentGroup_disappears
=== RUN   TestAccDeployDeploymentGroup_Disappears_app
=== PAUSE TestAccDeployDeploymentGroup_Disappears_app
=== RUN   TestAccDeployDeploymentGroup_tags
=== PAUSE TestAccDeployDeploymentGroup_tags
=== RUN   TestAccDeployDeploymentGroup_Trigger_basic
=== PAUSE TestAccDeployDeploymentGroup_Trigger_basic
=== RUN   TestAccDeployDeploymentGroup_Trigger_multiple
=== PAUSE TestAccDeployDeploymentGroup_Trigger_multiple
=== RUN   TestAccDeployDeploymentGroup_AutoRollback_create
=== PAUSE TestAccDeployDeploymentGroup_AutoRollback_create
=== RUN   TestAccDeployDeploymentGroup_AutoRollback_update
=== PAUSE TestAccDeployDeploymentGroup_AutoRollback_update
=== RUN   TestAccDeployDeploymentGroup_AutoRollback_delete
=== PAUSE TestAccDeployDeploymentGroup_AutoRollback_delete
=== RUN   TestAccDeployDeploymentGroup_AutoRollback_disable
=== PAUSE TestAccDeployDeploymentGroup_AutoRollback_disable
=== RUN   TestAccDeployDeploymentGroup_Alarm_create
=== PAUSE TestAccDeployDeploymentGroup_Alarm_create
=== RUN   TestAccDeployDeploymentGroup_Alarm_update
=== PAUSE TestAccDeployDeploymentGroup_Alarm_update
=== RUN   TestAccDeployDeploymentGroup_Alarm_delete
=== PAUSE TestAccDeployDeploymentGroup_Alarm_delete
=== RUN   TestAccDeployDeploymentGroup_Alarm_disable
=== PAUSE TestAccDeployDeploymentGroup_Alarm_disable
=== RUN   TestAccDeployDeploymentGroup_DeploymentStyle_default
=== PAUSE TestAccDeployDeploymentGroup_DeploymentStyle_default
=== RUN   TestAccDeployDeploymentGroup_DeploymentStyle_create
=== PAUSE TestAccDeployDeploymentGroup_DeploymentStyle_create
=== RUN   TestAccDeployDeploymentGroup_DeploymentStyle_update
=== PAUSE TestAccDeployDeploymentGroup_DeploymentStyle_update
=== RUN   TestAccDeployDeploymentGroup_DeploymentStyle_delete
=== PAUSE TestAccDeployDeploymentGroup_DeploymentStyle_delete
=== RUN   TestAccDeployDeploymentGroup_LoadBalancerInfo_create
=== PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfo_create
=== RUN   TestAccDeployDeploymentGroup_LoadBalancerInfo_update
=== PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfo_update
=== RUN   TestAccDeployDeploymentGroup_LoadBalancerInfo_delete
=== PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfo_delete
=== RUN   TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_create
=== PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_create
=== RUN   TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_update
=== PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_update
=== RUN   TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_delete
=== PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_delete
=== RUN   TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_create
=== PAUSE TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_create
=== RUN   TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_update
=== PAUSE TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_update
=== RUN   TestAccDeployDeploymentGroup_BlueGreenDeployment_create
=== PAUSE TestAccDeployDeploymentGroup_BlueGreenDeployment_create
=== RUN   TestAccDeployDeploymentGroup_BlueGreenDeployment_updateWithASG
=== PAUSE TestAccDeployDeploymentGroup_BlueGreenDeployment_updateWithASG
=== RUN   TestAccDeployDeploymentGroup_BlueGreenDeployment_update
=== PAUSE TestAccDeployDeploymentGroup_BlueGreenDeployment_update
=== RUN   TestAccDeployDeploymentGroup_BlueGreenDeployment_delete
=== PAUSE TestAccDeployDeploymentGroup_BlueGreenDeployment_delete
=== RUN   TestAccDeployDeploymentGroup_BlueGreenDeployment_complete
=== PAUSE TestAccDeployDeploymentGroup_BlueGreenDeployment_complete
=== RUN   TestAccDeployDeploymentGroup_ECS_blueGreen
=== PAUSE TestAccDeployDeploymentGroup_ECS_blueGreen
=== RUN   TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_update
=== PAUSE TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_update
=== RUN   TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_ignore
=== PAUSE TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_ignore
=== CONT  TestAccDeployApp_basic
=== CONT  TestAccDeployDeploymentGroup_Alarm_create
=== CONT  TestAccDeployDeploymentGroup_basic
=== CONT  TestAccDeployDeploymentConfig_trafficLinear
=== CONT  TestAccDeployDeploymentConfig_hostCount
=== CONT  TestAccDeployDeploymentConfig_fleetPercent
=== CONT  TestAccDeployDeploymentConfig_basic
=== CONT  TestAccDeployApp_disappears
=== CONT  TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_update
=== CONT  TestAccDeployApp_tags
=== CONT  TestAccDeployApp_name
=== CONT  TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_ignore
=== CONT  TestAccDeployApp_ComputePlatform_lambda
=== CONT  TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_update
=== CONT  TestAccDeployDeploymentGroup_DeploymentStyle_update
=== CONT  TestAccDeployApp_computePlatform
=== CONT  TestAccDeployDeploymentGroup_ECS_blueGreen
=== CONT  TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_create
=== CONT  TestAccDeployDeploymentGroup_BlueGreenDeployment_updateWithASG
=== CONT  TestAccDeployApp_ComputePlatform_ecs
--- PASS: TestAccDeployApp_disappears (57.39s)
=== CONT  TestAccDeployDeploymentGroup_BlueGreenDeployment_create
--- PASS: TestAccDeployApp_ComputePlatform_ecs (76.46s)
=== CONT  TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_update
--- PASS: TestAccDeployDeploymentConfig_basic (77.65s)
=== CONT  TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_create
--- PASS: TestAccDeployApp_ComputePlatform_lambda (77.72s)
=== CONT  TestAccDeployDeploymentGroup_BlueGreenDeployment_delete
--- PASS: TestAccDeployApp_basic (91.97s)
=== CONT  TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_delete
--- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_create (98.54s)
=== CONT  TestAccDeployDeploymentGroup_BlueGreenDeployment_update
--- PASS: TestAccDeployDeploymentGroup_Alarm_create (101.73s)
=== CONT  TestAccDeployDeploymentConfig_trafficCanary
--- PASS: TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_ignore (103.70s)
=== CONT  TestAccDeployDeploymentGroup_LoadBalancerInfo_delete
--- PASS: TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_update (103.99s)
=== CONT  TestAccDeployDeploymentGroup_Trigger_basic
--- PASS: TestAccDeployApp_computePlatform (119.50s)
=== CONT  TestAccDeployDeploymentGroup_LoadBalancerInfo_update
--- PASS: TestAccDeployDeploymentConfig_fleetPercent (129.39s)
=== CONT  TestAccDeployDeploymentGroup_AutoRollback_disable
--- PASS: TestAccDeployDeploymentConfig_hostCount (130.62s)
=== CONT  TestAccDeployDeploymentGroup_LoadBalancerInfo_create
--- PASS: TestAccDeployDeploymentConfig_trafficLinear (131.67s)
=== CONT  TestAccDeployDeploymentGroup_DeploymentStyle_delete
--- PASS: TestAccDeployApp_name (140.45s)
=== CONT  TestAccDeployDeploymentGroup_BlueGreenDeployment_complete
--- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_update (155.18s)
=== CONT  TestAccDeployDeploymentGroup_AutoRollback_create
--- PASS: TestAccDeployDeploymentGroup_DeploymentStyle_update (155.43s)
=== CONT  TestAccDeployDeploymentGroup_Alarm_disable
--- PASS: TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_create (86.08s)
=== CONT  TestAccDeployDeploymentGroup_AutoRollback_update
--- PASS: TestAccDeployDeploymentGroup_basic (164.20s)
=== CONT  TestAccDeployDeploymentGroup_DeploymentStyle_create
--- PASS: TestAccDeployApp_tags (182.87s)
=== CONT  TestAccDeployDeploymentGroup_DeploymentStyle_default
--- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfo_create (84.40s)
=== CONT  TestAccDeployDeploymentGroup_Alarm_delete
--- PASS: TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_update (140.85s)
=== CONT  TestAccDeployDeploymentGroup_Alarm_update
--- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_delete (144.58s)
=== CONT  TestAccDeployDeploymentGroup_Trigger_multiple
--- PASS: TestAccDeployDeploymentConfig_trafficCanary (123.53s)
=== CONT  TestAccDeployDeploymentGroup_disappears
--- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_update (129.02s)
=== CONT  TestAccDeployDeploymentGroup_Basic_tagSet
--- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_delete (142.63s)
=== CONT  TestAccDeployDeploymentGroup_tags
--- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_updateWithASG (243.20s)
=== CONT  TestAccDeployDeploymentGroup_onPremiseTag
--- PASS: TestAccDeployDeploymentGroup_Trigger_basic (139.88s)
=== CONT  TestAccDeployDeploymentGroup_Disappears_app
--- PASS: TestAccDeployDeploymentGroup_AutoRollback_create (89.07s)
=== CONT  TestAccDeployDeploymentGroup_AutoRollback_delete
--- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfo_delete (145.17s)
--- PASS: TestAccDeployDeploymentGroup_DeploymentStyle_create (88.95s)
--- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfo_update (137.61s)
--- PASS: TestAccDeployDeploymentGroup_DeploymentStyle_default (83.19s)
--- PASS: TestAccDeployDeploymentGroup_AutoRollback_disable (138.00s)
--- PASS: TestAccDeployDeploymentGroup_DeploymentStyle_delete (137.11s)
--- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_complete (130.06s)
--- PASS: TestAccDeployDeploymentGroup_Alarm_disable (126.60s)
--- PASS: TestAccDeployDeploymentGroup_disappears (60.78s)
--- PASS: TestAccDeployDeploymentGroup_AutoRollback_update (123.86s)
--- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_create (235.84s)
--- PASS: TestAccDeployDeploymentGroup_Disappears_app (51.56s)
--- PASS: TestAccDeployDeploymentGroup_onPremiseTag (61.07s)
--- PASS: TestAccDeployDeploymentGroup_Alarm_delete (95.36s)
--- PASS: TestAccDeployDeploymentGroup_Alarm_update (93.99s)
--- PASS: TestAccDeployDeploymentGroup_Trigger_multiple (91.01s)
--- PASS: TestAccDeployDeploymentGroup_AutoRollback_delete (76.07s)
--- PASS: TestAccDeployDeploymentGroup_Basic_tagSet (93.22s)
--- PASS: TestAccDeployDeploymentGroup_tags (101.78s)
--- PASS: TestAccDeployDeploymentGroup_ECS_blueGreen (405.21s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/deploy     408.418s
...

github-actions · 2023-11-06T19:32:32Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

github-actions · 2023-11-06T19:32:54Z

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

Check open pull requests with the dependencies label to view other dependency updates.
If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
If this pull request is for supporting a new AWS service:
- Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
- If this pull request is already a separate pull request from the above item, you can ignore this message.

# Conflicts: # go.mod # go.sum # names/names_data.csv

% make testacc TESTARGS='-run=TestAccDeployApp_' PKG=deploy ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/deploy/... -v -count 1 -parallel 2 -run=TestAccDeployApp_ -timeout 360m === RUN TestAccDeployApp_basic === PAUSE TestAccDeployApp_basic === RUN TestAccDeployApp_computePlatform === PAUSE TestAccDeployApp_computePlatform === RUN TestAccDeployApp_ComputePlatform_ecs === PAUSE TestAccDeployApp_ComputePlatform_ecs === RUN TestAccDeployApp_ComputePlatform_lambda === PAUSE TestAccDeployApp_ComputePlatform_lambda === RUN TestAccDeployApp_name === PAUSE TestAccDeployApp_name === RUN TestAccDeployApp_tags === PAUSE TestAccDeployApp_tags === RUN TestAccDeployApp_disappears === PAUSE TestAccDeployApp_disappears === CONT TestAccDeployApp_basic === CONT TestAccDeployApp_name --- PASS: TestAccDeployApp_basic (30.14s) === CONT TestAccDeployApp_disappears --- PASS: TestAccDeployApp_name (43.35s) === CONT TestAccDeployApp_ComputePlatform_ecs --- PASS: TestAccDeployApp_disappears (18.32s) === CONT TestAccDeployApp_ComputePlatform_lambda --- PASS: TestAccDeployApp_ComputePlatform_ecs (24.75s) === CONT TestAccDeployApp_computePlatform --- PASS: TestAccDeployApp_ComputePlatform_lambda (25.16s) === CONT TestAccDeployApp_tags --- PASS: TestAccDeployApp_computePlatform (38.79s) --- PASS: TestAccDeployApp_tags (57.51s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/deploy 136.840s

% make testacc TESTARGS='-run=TestAccDeployDeploymentConfig_' PKG=deploy ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/deploy/... -v -count 1 -parallel 2 -run=TestAccDeployDeploymentConfig_ -timeout 360m === RUN TestAccDeployDeploymentConfig_basic === PAUSE TestAccDeployDeploymentConfig_basic === RUN TestAccDeployDeploymentConfig_fleetPercent === PAUSE TestAccDeployDeploymentConfig_fleetPercent === RUN TestAccDeployDeploymentConfig_hostCount === PAUSE TestAccDeployDeploymentConfig_hostCount === RUN TestAccDeployDeploymentConfig_trafficCanary === PAUSE TestAccDeployDeploymentConfig_trafficCanary === RUN TestAccDeployDeploymentConfig_trafficLinear === PAUSE TestAccDeployDeploymentConfig_trafficLinear === CONT TestAccDeployDeploymentConfig_basic === CONT TestAccDeployDeploymentConfig_trafficCanary --- PASS: TestAccDeployDeploymentConfig_basic (25.10s) === CONT TestAccDeployDeploymentConfig_trafficLinear --- PASS: TestAccDeployDeploymentConfig_trafficCanary (41.82s) === CONT TestAccDeployDeploymentConfig_hostCount --- PASS: TestAccDeployDeploymentConfig_trafficLinear (41.86s) === CONT TestAccDeployDeploymentConfig_fleetPercent --- PASS: TestAccDeployDeploymentConfig_hostCount (42.69s) --- PASS: TestAccDeployDeploymentConfig_fleetPercent (39.65s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/deploy 112.410s

…yDeploymentGroup_ECS_blueGreen'.

% make testacc TESTARGS='-run=TestAccDeployDeploymentGroup_' PKG=deploy ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/deploy/... -v -count 1 -parallel 2 -run=TestAccDeployDeploymentGroup_ -timeout 360m === RUN TestAccDeployDeploymentGroup_basic === PAUSE TestAccDeployDeploymentGroup_basic === RUN TestAccDeployDeploymentGroup_Basic_tagSet === PAUSE TestAccDeployDeploymentGroup_Basic_tagSet === RUN TestAccDeployDeploymentGroup_onPremiseTag === PAUSE TestAccDeployDeploymentGroup_onPremiseTag === RUN TestAccDeployDeploymentGroup_disappears === PAUSE TestAccDeployDeploymentGroup_disappears === RUN TestAccDeployDeploymentGroup_Disappears_app === PAUSE TestAccDeployDeploymentGroup_Disappears_app === RUN TestAccDeployDeploymentGroup_tags === PAUSE TestAccDeployDeploymentGroup_tags === RUN TestAccDeployDeploymentGroup_Trigger_basic === PAUSE TestAccDeployDeploymentGroup_Trigger_basic === RUN TestAccDeployDeploymentGroup_Trigger_multiple === PAUSE TestAccDeployDeploymentGroup_Trigger_multiple === RUN TestAccDeployDeploymentGroup_AutoRollback_create === PAUSE TestAccDeployDeploymentGroup_AutoRollback_create === RUN TestAccDeployDeploymentGroup_AutoRollback_update === PAUSE TestAccDeployDeploymentGroup_AutoRollback_update === RUN TestAccDeployDeploymentGroup_AutoRollback_delete === PAUSE TestAccDeployDeploymentGroup_AutoRollback_delete === RUN TestAccDeployDeploymentGroup_AutoRollback_disable === PAUSE TestAccDeployDeploymentGroup_AutoRollback_disable === RUN TestAccDeployDeploymentGroup_Alarm_create === PAUSE TestAccDeployDeploymentGroup_Alarm_create === RUN TestAccDeployDeploymentGroup_Alarm_update === PAUSE TestAccDeployDeploymentGroup_Alarm_update === RUN TestAccDeployDeploymentGroup_Alarm_delete === PAUSE TestAccDeployDeploymentGroup_Alarm_delete === RUN TestAccDeployDeploymentGroup_Alarm_disable === PAUSE TestAccDeployDeploymentGroup_Alarm_disable === RUN TestAccDeployDeploymentGroup_DeploymentStyle_default === PAUSE TestAccDeployDeploymentGroup_DeploymentStyle_default === RUN TestAccDeployDeploymentGroup_DeploymentStyle_create === PAUSE TestAccDeployDeploymentGroup_DeploymentStyle_create === RUN TestAccDeployDeploymentGroup_DeploymentStyle_update === PAUSE TestAccDeployDeploymentGroup_DeploymentStyle_update === RUN TestAccDeployDeploymentGroup_DeploymentStyle_delete === PAUSE TestAccDeployDeploymentGroup_DeploymentStyle_delete === RUN TestAccDeployDeploymentGroup_LoadBalancerInfo_create === PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfo_create === RUN TestAccDeployDeploymentGroup_LoadBalancerInfo_update === PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfo_update === RUN TestAccDeployDeploymentGroup_LoadBalancerInfo_delete === PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfo_delete === RUN TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_create === PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_create === RUN TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_update === PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_update === RUN TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_delete === PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_delete === RUN TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_create === PAUSE TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_create === RUN TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_update === PAUSE TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_update === RUN TestAccDeployDeploymentGroup_BlueGreenDeployment_create === PAUSE TestAccDeployDeploymentGroup_BlueGreenDeployment_create === RUN TestAccDeployDeploymentGroup_BlueGreenDeployment_updateWithASG === PAUSE TestAccDeployDeploymentGroup_BlueGreenDeployment_updateWithASG === RUN TestAccDeployDeploymentGroup_BlueGreenDeployment_update === PAUSE TestAccDeployDeploymentGroup_BlueGreenDeployment_update === RUN TestAccDeployDeploymentGroup_BlueGreenDeployment_delete === PAUSE TestAccDeployDeploymentGroup_BlueGreenDeployment_delete === RUN TestAccDeployDeploymentGroup_BlueGreenDeployment_complete === PAUSE TestAccDeployDeploymentGroup_BlueGreenDeployment_complete === RUN TestAccDeployDeploymentGroup_ECS_blueGreen === PAUSE TestAccDeployDeploymentGroup_ECS_blueGreen === RUN TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_update === PAUSE TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_update === RUN TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_ignore === PAUSE TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_ignore === CONT TestAccDeployDeploymentGroup_basic === CONT TestAccDeployDeploymentGroup_DeploymentStyle_update --- PASS: TestAccDeployDeploymentGroup_DeploymentStyle_update (52.12s) === CONT TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_update --- PASS: TestAccDeployDeploymentGroup_basic (60.93s) === CONT TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_ignore --- PASS: TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_ignore (32.37s) === CONT TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_update --- PASS: TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_update (50.29s) === CONT TestAccDeployDeploymentGroup_ECS_blueGreen --- PASS: TestAccDeployDeploymentGroup_ECS_blueGreen (334.32s) === CONT TestAccDeployDeploymentGroup_BlueGreenDeployment_complete --- PASS: TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_update (32.81s) === CONT TestAccDeployDeploymentGroup_BlueGreenDeployment_delete --- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_complete (49.23s) === CONT TestAccDeployDeploymentGroup_BlueGreenDeployment_update --- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_delete (49.91s) === CONT TestAccDeployDeploymentGroup_BlueGreenDeployment_updateWithASG --- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_update (45.06s) === CONT TestAccDeployDeploymentGroup_BlueGreenDeployment_create --- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_updateWithASG (166.66s) === CONT TestAccDeployDeploymentGroup_AutoRollback_update --- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_create (175.24s) === CONT TestAccDeployDeploymentGroup_DeploymentStyle_create --- PASS: TestAccDeployDeploymentGroup_AutoRollback_update (47.70s) === CONT TestAccDeployDeploymentGroup_DeploymentStyle_default --- PASS: TestAccDeployDeploymentGroup_DeploymentStyle_create (32.36s) === CONT TestAccDeployDeploymentGroup_Alarm_disable --- PASS: TestAccDeployDeploymentGroup_DeploymentStyle_default (32.35s) === CONT TestAccDeployDeploymentGroup_Alarm_delete --- PASS: TestAccDeployDeploymentGroup_Alarm_disable (49.80s) === CONT TestAccDeployDeploymentGroup_Alarm_update --- PASS: TestAccDeployDeploymentGroup_Alarm_delete (50.31s) === CONT TestAccDeployDeploymentGroup_Alarm_create --- PASS: TestAccDeployDeploymentGroup_Alarm_create (33.04s) === CONT TestAccDeployDeploymentGroup_AutoRollback_disable --- PASS: TestAccDeployDeploymentGroup_Alarm_update (49.33s) === CONT TestAccDeployDeploymentGroup_AutoRollback_delete --- PASS: TestAccDeployDeploymentGroup_AutoRollback_delete (50.93s) === CONT TestAccDeployDeploymentGroup_tags --- PASS: TestAccDeployDeploymentGroup_AutoRollback_disable (51.76s) === CONT TestAccDeployDeploymentGroup_AutoRollback_create --- PASS: TestAccDeployDeploymentGroup_AutoRollback_create (33.85s) === CONT TestAccDeployDeploymentGroup_Trigger_multiple --- PASS: TestAccDeployDeploymentGroup_Trigger_multiple (54.44s) === CONT TestAccDeployDeploymentGroup_Trigger_basic --- PASS: TestAccDeployDeploymentGroup_tags (68.29s) === CONT TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_delete --- PASS: TestAccDeployDeploymentGroup_Trigger_basic (52.55s) === CONT TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_create --- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_delete (52.66s) === CONT TestAccDeployDeploymentGroup_disappears --- PASS: TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_create (33.66s) === CONT TestAccDeployDeploymentGroup_Disappears_app --- PASS: TestAccDeployDeploymentGroup_disappears (39.55s) === CONT TestAccDeployDeploymentGroup_LoadBalancerInfo_update --- PASS: TestAccDeployDeploymentGroup_Disappears_app (30.00s) === CONT TestAccDeployDeploymentGroup_LoadBalancerInfo_delete --- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfo_update (52.07s) === CONT TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_update --- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfo_delete (52.45s) === CONT TestAccDeployDeploymentGroup_LoadBalancerInfo_create --- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfo_create (34.64s) === CONT TestAccDeployDeploymentGroup_onPremiseTag --- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_update (52.48s) === CONT TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_create --- PASS: TestAccDeployDeploymentGroup_onPremiseTag (34.76s) === CONT TestAccDeployDeploymentGroup_DeploymentStyle_delete --- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_create (34.20s) === CONT TestAccDeployDeploymentGroup_Basic_tagSet --- PASS: TestAccDeployDeploymentGroup_DeploymentStyle_delete (52.19s) --- PASS: TestAccDeployDeploymentGroup_Basic_tagSet (61.71s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/deploy 923.498s

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDeployApp_' PKG=deploy ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/deploy/... -v -count 1 -parallel 2  -run=TestAccDeployApp_ -timeout 360m
=== RUN   TestAccDeployApp_basic
=== PAUSE TestAccDeployApp_basic
=== RUN   TestAccDeployApp_computePlatform
=== PAUSE TestAccDeployApp_computePlatform
=== RUN   TestAccDeployApp_ComputePlatform_ecs
=== PAUSE TestAccDeployApp_ComputePlatform_ecs
=== RUN   TestAccDeployApp_ComputePlatform_lambda
=== PAUSE TestAccDeployApp_ComputePlatform_lambda
=== RUN   TestAccDeployApp_name
=== PAUSE TestAccDeployApp_name
=== RUN   TestAccDeployApp_tags
=== PAUSE TestAccDeployApp_tags
=== RUN   TestAccDeployApp_disappears
=== PAUSE TestAccDeployApp_disappears
=== CONT  TestAccDeployApp_basic
=== CONT  TestAccDeployApp_name
--- PASS: TestAccDeployApp_basic (30.14s)
=== CONT  TestAccDeployApp_disappears
--- PASS: TestAccDeployApp_name (43.35s)
=== CONT  TestAccDeployApp_ComputePlatform_ecs
--- PASS: TestAccDeployApp_disappears (18.32s)
=== CONT  TestAccDeployApp_ComputePlatform_lambda
--- PASS: TestAccDeployApp_ComputePlatform_ecs (24.75s)
=== CONT  TestAccDeployApp_computePlatform
--- PASS: TestAccDeployApp_ComputePlatform_lambda (25.16s)
=== CONT  TestAccDeployApp_tags
--- PASS: TestAccDeployApp_computePlatform (38.79s)
--- PASS: TestAccDeployApp_tags (57.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/deploy	136.840s

% make testacc TESTARGS='-run=TestAccDeployDeploymentConfig_' PKG=deploy ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/deploy/... -v -count 1 -parallel 2  -run=TestAccDeployDeploymentConfig_ -timeout 360m
=== RUN   TestAccDeployDeploymentConfig_basic
=== PAUSE TestAccDeployDeploymentConfig_basic
=== RUN   TestAccDeployDeploymentConfig_fleetPercent
=== PAUSE TestAccDeployDeploymentConfig_fleetPercent
=== RUN   TestAccDeployDeploymentConfig_hostCount
=== PAUSE TestAccDeployDeploymentConfig_hostCount
=== RUN   TestAccDeployDeploymentConfig_trafficCanary
=== PAUSE TestAccDeployDeploymentConfig_trafficCanary
=== RUN   TestAccDeployDeploymentConfig_trafficLinear
=== PAUSE TestAccDeployDeploymentConfig_trafficLinear
=== CONT  TestAccDeployDeploymentConfig_basic
=== CONT  TestAccDeployDeploymentConfig_trafficCanary
--- PASS: TestAccDeployDeploymentConfig_basic (25.10s)
=== CONT  TestAccDeployDeploymentConfig_trafficLinear
--- PASS: TestAccDeployDeploymentConfig_trafficCanary (41.82s)
=== CONT  TestAccDeployDeploymentConfig_hostCount
--- PASS: TestAccDeployDeploymentConfig_trafficLinear (41.86s)
=== CONT  TestAccDeployDeploymentConfig_fleetPercent
--- PASS: TestAccDeployDeploymentConfig_hostCount (42.69s)
--- PASS: TestAccDeployDeploymentConfig_fleetPercent (39.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/deploy	112.410s

% make testacc TESTARGS='-run=TestAccDeployDeploymentGroup_' PKG=deploy ACCTEST_PARALLELISM=2 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/deploy/... -v -count 1 -parallel 2  -run=TestAccDeployDeploymentGroup_ -timeout 360m
=== RUN   TestAccDeployDeploymentGroup_basic
=== PAUSE TestAccDeployDeploymentGroup_basic
=== RUN   TestAccDeployDeploymentGroup_Basic_tagSet
=== PAUSE TestAccDeployDeploymentGroup_Basic_tagSet
=== RUN   TestAccDeployDeploymentGroup_onPremiseTag
=== PAUSE TestAccDeployDeploymentGroup_onPremiseTag
=== RUN   TestAccDeployDeploymentGroup_disappears
=== PAUSE TestAccDeployDeploymentGroup_disappears
=== RUN   TestAccDeployDeploymentGroup_Disappears_app
=== PAUSE TestAccDeployDeploymentGroup_Disappears_app
=== RUN   TestAccDeployDeploymentGroup_tags
=== PAUSE TestAccDeployDeploymentGroup_tags
=== RUN   TestAccDeployDeploymentGroup_Trigger_basic
=== PAUSE TestAccDeployDeploymentGroup_Trigger_basic
=== RUN   TestAccDeployDeploymentGroup_Trigger_multiple
=== PAUSE TestAccDeployDeploymentGroup_Trigger_multiple
=== RUN   TestAccDeployDeploymentGroup_AutoRollback_create
=== PAUSE TestAccDeployDeploymentGroup_AutoRollback_create
=== RUN   TestAccDeployDeploymentGroup_AutoRollback_update
=== PAUSE TestAccDeployDeploymentGroup_AutoRollback_update
=== RUN   TestAccDeployDeploymentGroup_AutoRollback_delete
=== PAUSE TestAccDeployDeploymentGroup_AutoRollback_delete
=== RUN   TestAccDeployDeploymentGroup_AutoRollback_disable
=== PAUSE TestAccDeployDeploymentGroup_AutoRollback_disable
=== RUN   TestAccDeployDeploymentGroup_Alarm_create
=== PAUSE TestAccDeployDeploymentGroup_Alarm_create
=== RUN   TestAccDeployDeploymentGroup_Alarm_update
=== PAUSE TestAccDeployDeploymentGroup_Alarm_update
=== RUN   TestAccDeployDeploymentGroup_Alarm_delete
=== PAUSE TestAccDeployDeploymentGroup_Alarm_delete
=== RUN   TestAccDeployDeploymentGroup_Alarm_disable
=== PAUSE TestAccDeployDeploymentGroup_Alarm_disable
=== RUN   TestAccDeployDeploymentGroup_DeploymentStyle_default
=== PAUSE TestAccDeployDeploymentGroup_DeploymentStyle_default
=== RUN   TestAccDeployDeploymentGroup_DeploymentStyle_create
=== PAUSE TestAccDeployDeploymentGroup_DeploymentStyle_create
=== RUN   TestAccDeployDeploymentGroup_DeploymentStyle_update
=== PAUSE TestAccDeployDeploymentGroup_DeploymentStyle_update
=== RUN   TestAccDeployDeploymentGroup_DeploymentStyle_delete
=== PAUSE TestAccDeployDeploymentGroup_DeploymentStyle_delete
=== RUN   TestAccDeployDeploymentGroup_LoadBalancerInfo_create
=== PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfo_create
=== RUN   TestAccDeployDeploymentGroup_LoadBalancerInfo_update
=== PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfo_update
=== RUN   TestAccDeployDeploymentGroup_LoadBalancerInfo_delete
=== PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfo_delete
=== RUN   TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_create
=== PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_create
=== RUN   TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_update
=== PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_update
=== RUN   TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_delete
=== PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_delete
=== RUN   TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_create
=== PAUSE TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_create
=== RUN   TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_update
=== PAUSE TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_update
=== RUN   TestAccDeployDeploymentGroup_BlueGreenDeployment_create
=== PAUSE TestAccDeployDeploymentGroup_BlueGreenDeployment_create
=== RUN   TestAccDeployDeploymentGroup_BlueGreenDeployment_updateWithASG
=== PAUSE TestAccDeployDeploymentGroup_BlueGreenDeployment_updateWithASG
=== RUN   TestAccDeployDeploymentGroup_BlueGreenDeployment_update
=== PAUSE TestAccDeployDeploymentGroup_BlueGreenDeployment_update
=== RUN   TestAccDeployDeploymentGroup_BlueGreenDeployment_delete
=== PAUSE TestAccDeployDeploymentGroup_BlueGreenDeployment_delete
=== RUN   TestAccDeployDeploymentGroup_BlueGreenDeployment_complete
=== PAUSE TestAccDeployDeploymentGroup_BlueGreenDeployment_complete
=== RUN   TestAccDeployDeploymentGroup_ECS_blueGreen
=== PAUSE TestAccDeployDeploymentGroup_ECS_blueGreen
=== RUN   TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_update
=== PAUSE TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_update
=== RUN   TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_ignore
=== PAUSE TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_ignore
=== CONT  TestAccDeployDeploymentGroup_basic
=== CONT  TestAccDeployDeploymentGroup_DeploymentStyle_update
--- PASS: TestAccDeployDeploymentGroup_DeploymentStyle_update (51.07s)
=== CONT  TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_update
--- PASS: TestAccDeployDeploymentGroup_basic (60.42s)
=== CONT  TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_ignore
--- PASS: TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_ignore (32.77s)
=== CONT  TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_update
--- PASS: TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_update (49.54s)
=== CONT  TestAccDeployDeploymentGroup_ECS_blueGreen
--- PASS: TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_update (32.32s)
=== CONT  TestAccDeployDeploymentGroup_BlueGreenDeployment_complete
--- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_complete (47.57s)
=== CONT  TestAccDeployDeploymentGroup_BlueGreenDeployment_delete
--- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_delete (47.41s)
=== CONT  TestAccDeployDeploymentGroup_BlueGreenDeployment_update
--- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_update (45.73s)
=== CONT  TestAccDeployDeploymentGroup_BlueGreenDeployment_updateWithASG
--- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_updateWithASG (171.04s)
=== CONT  TestAccDeployDeploymentGroup_BlueGreenDeployment_create
--- PASS: TestAccDeployDeploymentGroup_ECS_blueGreen (353.92s)
=== CONT  TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_create
--- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_create (31.22s)
=== CONT  TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_create
--- PASS: TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_create (31.52s)
=== CONT  TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_delete
--- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_delete (48.77s)
=== CONT  TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_update
--- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_create (154.85s)
=== CONT  TestAccDeployDeploymentGroup_AutoRollback_update
--- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_update (51.42s)
=== CONT  TestAccDeployDeploymentGroup_DeploymentStyle_create
--- PASS: TestAccDeployDeploymentGroup_AutoRollback_update (53.62s)
=== CONT  TestAccDeployDeploymentGroup_DeploymentStyle_default
--- PASS: TestAccDeployDeploymentGroup_DeploymentStyle_create (35.55s)
=== CONT  TestAccDeployDeploymentGroup_Alarm_disable
--- PASS: TestAccDeployDeploymentGroup_DeploymentStyle_default (34.78s)
=== CONT  TestAccDeployDeploymentGroup_Alarm_delete
--- PASS: TestAccDeployDeploymentGroup_Alarm_disable (52.16s)
=== CONT  TestAccDeployDeploymentGroup_Alarm_update
--- PASS: TestAccDeployDeploymentGroup_Alarm_delete (52.14s)
=== CONT  TestAccDeployDeploymentGroup_Alarm_create
--- PASS: TestAccDeployDeploymentGroup_Alarm_update (52.79s)
=== CONT  TestAccDeployDeploymentGroup_AutoRollback_disable
--- PASS: TestAccDeployDeploymentGroup_Alarm_create (34.59s)
=== CONT  TestAccDeployDeploymentGroup_AutoRollback_delete
--- PASS: TestAccDeployDeploymentGroup_AutoRollback_disable (52.18s)
=== CONT  TestAccDeployDeploymentGroup_LoadBalancerInfo_update
--- PASS: TestAccDeployDeploymentGroup_AutoRollback_delete (52.75s)
=== CONT  TestAccDeployDeploymentGroup_LoadBalancerInfo_delete
--- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfo_update (53.56s)
=== CONT  TestAccDeployDeploymentGroup_disappears
--- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfo_delete (53.52s)
=== CONT  TestAccDeployDeploymentGroup_Disappears_app
--- PASS: TestAccDeployDeploymentGroup_disappears (30.51s)
=== CONT  TestAccDeployDeploymentGroup_onPremiseTag
--- PASS: TestAccDeployDeploymentGroup_Disappears_app (29.90s)
=== CONT  TestAccDeployDeploymentGroup_LoadBalancerInfo_create
--- PASS: TestAccDeployDeploymentGroup_onPremiseTag (33.15s)
=== CONT  TestAccDeployDeploymentGroup_Trigger_multiple
--- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfo_create (32.80s)
=== CONT  TestAccDeployDeploymentGroup_AutoRollback_create
--- PASS: TestAccDeployDeploymentGroup_AutoRollback_create (32.92s)
=== CONT  TestAccDeployDeploymentGroup_Basic_tagSet
--- PASS: TestAccDeployDeploymentGroup_Trigger_multiple (51.74s)
=== CONT  TestAccDeployDeploymentGroup_Trigger_basic
--- PASS: TestAccDeployDeploymentGroup_Basic_tagSet (58.24s)
=== CONT  TestAccDeployDeploymentGroup_DeploymentStyle_delete
--- PASS: TestAccDeployDeploymentGroup_Trigger_basic (50.60s)
=== CONT  TestAccDeployDeploymentGroup_tags
--- PASS: TestAccDeployDeploymentGroup_DeploymentStyle_delete (50.31s)
--- PASS: TestAccDeployDeploymentGroup_tags (66.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/deploy	1101.822s

ewbankkit · 2023-11-19T21:04:14Z

@brittandeyoung Thanks for the contribution 🎉 👏.

github-actions · 2023-11-27T19:46:30Z

This functionality has been released in v5.27.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2023-12-28T02:04:25Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

brittandeyoung added 12 commits November 6, 2023 10:23

go get github.com/aws/aws-sdk-go-v2/service/codedeploy

17178f7

names: Update codedeploy to use aws-sdk-go-v2

3d2b2b1

conns: generate new codedeploy aws-sdk-go-v2 client

4e9e7e6

deploy: Amend generate, update tags gen to sdk-v2

01d4e24

deploy: re-generate tags_gen with sdk-v2

4c0b35c

deploy: Amend app, migrate to aws-sdk-go-v2

59e81f1

deploy: Amend app_test, migrate to aws-sdk-go-v2

becb4e1

deploy: Amend deployment_config, migrate to aws-sdk-go-v2

08cbeb6

deploy: Amend deployment_config_test, migrate to aws-sdk-go-v2

4ba9e38

deploy: Amend deployment_group, migrate to aws-sdk-go-v2

99b9878

deploy: Amend deployment_group_test, migrate to aws-sdk-go-v2

62a56cd

deploy: Amend sweep, migrate to aws-sdk-go-v2

b1043c3

terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Nov 6, 2023

brittandeyoung added 2 commits November 6, 2023 14:40

deploy: Amend deployment_config, use enum.Slice

8e07517

deploy: Amend deployment_group, remove Deployment from function names

a0fe7f6

brittandeyoung added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Nov 6, 2023

brittandeyoung added 4 commits November 6, 2023 15:30

deploy: Amend deployment_group_test, resolve failing tests

03d950c

deploy: Amend sweep, remove unnecessary trailing newline

260167d

deploy: Amend deployment_config, remove unnecessary conversion

67cf524

deploy: Amend deployment_group, remove unnecessary conversion

72bdb88

justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Nov 7, 2023

ewbankkit added 17 commits November 17, 2023 14:45

Merge branch 'main' into HEAD

b9f8391

# Conflicts: # go.mod # go.sum # names/names_data.csv

Add and use 'names.CodeDeployEndpointID'.

f0721cb

Use github.com/aws/aws-sdk-go-v2/service/codedeploy@v1.20.1

af9838e

r/aws_codedeploy_app: Tidy up.

5b549c0

r/aws_codedeploy_deployment_config: Tidy up.

d797688

Fix golangci-lint 'unused'.

151276e

r/aws_codedeploy_deployment_group: Start to tidy up.

ea23a87

r/aws_codedeploy_app: Tidy up sweeper.

3ae32fb

Replace 'validTagFilters'.

147e2c0

r/aws_codedeploy_deployment_group: Tidy up acceptance tests.

a17b53a

Fix 'TestAccDeployDeploymentGroup_basic'.

4fd3e3e

Fix 'TestAccDeployDeploymentGroup_Trigger_multiple' and 'TestAccDeplo…

32755de

…yDeploymentGroup_ECS_blueGreen'.

r/aws_codedeploy_deployment_group: Remove custom Set functions.

4e2834a

Fix semgrep 'ci.deploy-in-var-name'.

244e35b

ewbankkit approved these changes Nov 19, 2023

View reviewed changes

ewbankkit merged commit b27fa9d into hashicorp:main Nov 20, 2023
43 checks passed

github-actions bot added this to the v5.27.0 milestone Nov 20, 2023

github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2023

justinretzolk added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Mar 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TechDebt: Migrate `deploy` service to `aws-sdk-go-v2` #34282

TechDebt: Migrate `deploy` service to `aws-sdk-go-v2` #34282

brittandeyoung commented Nov 6, 2023 •

edited

Loading

github-actions bot commented Nov 6, 2023

github-actions bot commented Nov 6, 2023

ewbankkit left a comment

ewbankkit commented Nov 19, 2023

github-actions bot commented Nov 27, 2023

github-actions bot commented Dec 28, 2023

TechDebt: Migrate deploy service to aws-sdk-go-v2 #34282

TechDebt: Migrate deploy service to aws-sdk-go-v2 #34282

Conversation

brittandeyoung commented Nov 6, 2023 • edited Loading

Description

Relations

References

Output from Acceptance Testing

github-actions bot commented Nov 6, 2023

Community Note

github-actions bot commented Nov 6, 2023

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented Nov 19, 2023

github-actions bot commented Nov 27, 2023

github-actions bot commented Dec 28, 2023

TechDebt: Migrate `deploy` service to `aws-sdk-go-v2` #34282

TechDebt: Migrate `deploy` service to `aws-sdk-go-v2` #34282

brittandeyoung commented Nov 6, 2023 •

edited

Loading