Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/chimesdkvoice service: fix eventual consistency errors #34426

Merged
merged 4 commits into from
Nov 15, 2023

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Nov 15, 2023

Description

Test are successful in regions other than us-east-1

Relations

Closes #32678

References

Output from Acceptance Testing

$ make testacc TESTARGS="-run=TestAccChimeSDKVoiceSipMediaApplication_" PKG=chimesdkvoice

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/chimesdkvoice/... -v -count 1 -parallel 20  -run=TestAccChimeSDKVoiceSipMediaApplication_ -timeout 360m
--- PASS: TestAccChimeSDKVoiceSipMediaApplication_disappears (129.17s)
--- PASS: TestAccChimeSDKVoiceSipMediaApplication_basic (145.59s)
--- PASS: TestAccChimeSDKVoiceSipMediaApplication_update (254.78s)
--- PASS: TestAccChimeSDKVoiceSipMediaApplication_tags (352.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/chimesdkvoice	355.659s
$ make testacc TESTARGS="-run=TestAccChimeSDKVoiceSipRule_" PKG=chimesdkvoice

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/chimesdkvoice/... -v -count 1 -parallel 20  -run=TestAccChimeSDKVoiceSipRule_ -timeout 360m
--- PASS: TestAccChimeSDKVoiceSipRule_disappears (201.51s)
--- PASS: TestAccChimeSDKVoiceSipRule_basic (207.11s)
--- PASS: TestAccChimeSDKVoiceSipRule_update (356.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/chimesdkvoice	359.815s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/chimesdkvoice Issues and PRs that pertain to the chimesdkvoice service. labels Nov 15, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 15, 2023
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@johnsonaj johnsonaj marked this pull request as ready for review November 15, 2023 20:26
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Nov 15, 2023
@johnsonaj johnsonaj added the bug Addresses a defect in current functionality. label Nov 15, 2023
@johnsonaj johnsonaj merged commit b51f4d2 into main Nov 15, 2023
65 checks passed
@johnsonaj johnsonaj deleted the b-chimsdkvoice_eventual_consistency branch November 15, 2023 21:20
@github-actions github-actions bot added this to the v5.26.0 milestone Nov 15, 2023
github-actions bot pushed a commit that referenced this pull request Nov 15, 2023
Copy link

This functionality has been released in v5.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the bug Addresses a defect in current functionality. label Nov 16, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/chimesdkvoice Issues and PRs that pertain to the chimesdkvoice service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to deploy SIP media application in us-west-2
2 participants