Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech debt: Migrate servicecatalog resources to AWS SDK for Go v2 #36009

Merged
merged 52 commits into from
Aug 8, 2024
Merged

Tech debt: Migrate servicecatalog resources to AWS SDK for Go v2 #36009

merged 52 commits into from
Aug 8, 2024

Conversation

bschaatsbergen
Copy link
Member

@bschaatsbergen bschaatsbergen commented Feb 28, 2024 •
edited by ewbankkit
Loading

Description

Relations

Closes #36211.
Relates #32976.

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. sweeper Pertains to changes to or issues with the sweeper. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. labels Feb 28, 2024
@bschaatsbergen bschaatsbergen mentioned this pull request Feb 28, 2024
Open
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Feb 28, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@ewbankkit ewbankkit added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Mar 5, 2024
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Mar 7, 2024
@DanielRieske
Copy link
Contributor

Closes: #36211

@DanielRieske
Copy link
Contributor

This PR is now ready for review.

% make testacc TESTARGS='-run=TestAcc' PKG=servicecatalog
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/servicecatalog/... -v -count 1 -parallel 20  -run=TestAcc -timeout 360m
=== RUN   TestAccServiceCatalogPortfolio_tags_EmptyTag_OnCreate
    portfolio_tags_gen_test.go:329: Resource Portfolio does not support empty tags
--- SKIP: TestAccServiceCatalogPortfolio_tags_EmptyTag_OnCreate (0.00s)
=== RUN   TestAccServiceCatalogPortfolio_tags_EmptyTag_OnUpdate_Add
    portfolio_tags_gen_test.go:416: Resource Portfolio does not support empty tags
--- SKIP: TestAccServiceCatalogPortfolio_tags_EmptyTag_OnUpdate_Add (0.00s)
=== RUN   TestAccServiceCatalogPortfolio_tags_EmptyTag_OnUpdate_Replace
    portfolio_tags_gen_test.go:545: Resource Portfolio does not support empty tags
--- SKIP: TestAccServiceCatalogPortfolio_tags_EmptyTag_OnUpdate_Replace (0.00s)
=== RUN   TestAccServiceCatalogPortfolio_tags_DefaultTags_emptyResourceTag
    portfolio_tags_gen_test.go:1326: Resource Portfolio does not support empty tags
--- SKIP: TestAccServiceCatalogPortfolio_tags_DefaultTags_emptyResourceTag (0.00s)
=== RUN   TestAccServiceCatalogPortfolio_tags_DefaultTags_emptyProviderOnlyTag
    portfolio_tags_gen_test.go:1393: Resource Portfolio does not support empty tags
--- SKIP: TestAccServiceCatalogPortfolio_tags_DefaultTags_emptyProviderOnlyTag (0.00s)
=== RUN   TestAccServiceCatalogProduct_tags_EmptyTag_OnCreate
    product_tags_gen_test.go:343: Resource Product does not support empty tags
--- SKIP: TestAccServiceCatalogProduct_tags_EmptyTag_OnCreate (0.00s)
=== RUN   TestAccServiceCatalogProduct_tags_EmptyTag_OnUpdate_Add
    product_tags_gen_test.go:435: Resource Product does not support empty tags
--- SKIP: TestAccServiceCatalogProduct_tags_EmptyTag_OnUpdate_Add (0.00s)
=== RUN   TestAccServiceCatalogProduct_tags_EmptyTag_OnUpdate_Replace
    product_tags_gen_test.go:569: Resource Product does not support empty tags
--- SKIP: TestAccServiceCatalogProduct_tags_EmptyTag_OnUpdate_Replace (0.00s)
=== RUN   TestAccServiceCatalogProduct_tags_DefaultTags_emptyResourceTag
    product_tags_gen_test.go:1383: Resource Product does not support empty tags
--- SKIP: TestAccServiceCatalogProduct_tags_DefaultTags_emptyResourceTag (0.00s)
=== RUN   TestAccServiceCatalogProduct_tags_DefaultTags_emptyProviderOnlyTag
    product_tags_gen_test.go:1452: Resource Product does not support empty tags
--- SKIP: TestAccServiceCatalogProduct_tags_DefaultTags_emptyProviderOnlyTag (0.00s)
=== RUN   TestAccServiceCatalogProvisionedProduct_tags_EmptyTag_OnCreate
    provisioned_product_tags_gen_test.go:351: Resource ProvisionedProduct does not support empty tags
--- SKIP: TestAccServiceCatalogProvisionedProduct_tags_EmptyTag_OnCreate (0.00s)
=== RUN   TestAccServiceCatalogProvisionedProduct_tags_EmptyTag_OnUpdate_Add
    provisioned_product_tags_gen_test.go:444: Resource ProvisionedProduct does not support empty tags
--- SKIP: TestAccServiceCatalogProvisionedProduct_tags_EmptyTag_OnUpdate_Add (0.00s)
=== RUN   TestAccServiceCatalogProvisionedProduct_tags_EmptyTag_OnUpdate_Replace
    provisioned_product_tags_gen_test.go:579: Resource ProvisionedProduct does not support empty tags
--- SKIP: TestAccServiceCatalogProvisionedProduct_tags_EmptyTag_OnUpdate_Replace (0.00s)
--- PASS: TestAccServiceCatalogTagOption_notActive (20.93s)
--- PASS: TestAccServiceCatalogPortfolio_basic (24.90s)
--- PASS: TestAccServiceCatalogPrincipalPortfolioAssociation_iam_pattern (25.67s)
--- PASS: TestAccServiceCatalogPrincipalPortfolioAssociation_disappears (35.15s)
--- PASS: TestAccServiceCatalogBudgetResourceAssociation_basic (36.54s)
--- PASS: TestAccServiceCatalogPortfolio_tags_AddOnUpdate (41.59s)
--- PASS: TestAccServiceCatalogProductDataSource_tags (48.77s)
--- PASS: TestAccServiceCatalogProductDataSource_basic (49.97s)
--- PASS: TestAccServiceCatalogProduct_tags_DefaultTags_nullOverlappingResourceTag (53.05s)
--- PASS: TestAccServiceCatalogProduct_tags_DefaultTags_nullNonOverlappingResourceTag (53.45s)
--- PASS: TestAccServiceCatalogProduct_tags_ComputedTag_OnCreate (55.02s)
--- PASS: TestAccServiceCatalogPortfolio_tags_ComputedTag_OnCreate (29.95s)
--- PASS: TestAccServiceCatalogPortfolio_tags_DefaultTags_nullNonOverlappingResourceTag (29.49s)
--- PASS: TestAccServiceCatalogPortfolio_tags_DefaultTags_nullOverlappingResourceTag (30.20s)
--- PASS: TestAccServiceCatalogPortfolio_tags_ComputedTag_OnUpdate_Replace (46.78s)
--- PASS: TestAccServiceCatalogPrincipalPortfolioAssociation_migrateV0 (71.17s)
--- PASS: TestAccServiceCatalogPortfolio_tags_ComputedTag_OnUpdate_Add (49.56s)
--- PASS: TestAccServiceCatalogProductPortfolioAssociation_disappears (75.01s)
--- PASS: TestAccServiceCatalogProductDataSource_physicalID (75.96s)
--- PASS: TestAccServiceCatalogProductPortfolioAssociation_basic (82.33s)
--- PASS: TestAccServiceCatalogPortfolio_tags_DefaultTags_updateToResourceOnly (44.19s)
--- PASS: TestAccServiceCatalogProduct_tags_ComputedTag_OnUpdate_Add (86.69s)
--- PASS: TestAccServiceCatalogPrincipalPortfolioAssociation_basic (34.28s)
--- PASS: TestAccServiceCatalogPortfolio_tags_DefaultTags_updateToProviderOnly (42.77s)
--- PASS: TestAccServiceCatalogPortfolio_tags_DefaultTags_overlapping (62.14s)
--- PASS: TestAccServiceCatalogProduct_disappears (29.98s)
--- PASS: TestAccServiceCatalogPortfolio_tags_DefaultTags_nonOverlapping (63.75s)
--- PASS: TestAccServiceCatalogPortfolio_tags_DefaultTags_providerOnly (80.12s)
--- PASS: TestAccServiceCatalogProduct_tags_DefaultTags_updateToResourceOnly (68.57s)
--- PASS: TestAccServiceCatalogProduct_update (56.95s)
--- PASS: TestAccServiceCatalogProduct_tags_DefaultTags_updateToProviderOnly (71.61s)
--- PASS: TestAccServiceCatalogProduct_physicalID (62.03s)
--- PASS: TestAccServiceCatalogProduct_tags_AddOnUpdate (63.77s)
--- PASS: TestAccServiceCatalogTagOption_disappears (15.54s)
--- PASS: TestAccServiceCatalogTagOption_basic (18.85s)
--- PASS: TestAccServiceCatalogProduct_basic (38.36s)
--- PASS: TestAccServiceCatalogTagOptionResourceAssociation_disappears (18.80s)
=== NAME  TestAccServiceCatalog_serial/OrganizationsAccess/basic
    organizations_access_test.go:28: this AWS account must be the management account of an AWS Organization
--- PASS: TestAccServiceCatalogProvisionedProduct_ProductName_update (165.01s)
--- PASS: TestAccServiceCatalogProvisioningArtifactsDataSource_basic (39.86s)
=== NAME  TestAccServiceCatalog_serial/PortfolioShare/sharePrincipals
    portfolio_share_test.go:86: this AWS account must be the management account of an AWS Organization
=== RUN   TestAccServiceCatalog_serial/PortfolioShare/organizationalUnit
--- PASS: TestAccServiceCatalogProduct_tags_DefaultTags_nonOverlapping (115.86s)
=== NAME  TestAccServiceCatalog_serial/PortfolioShare/organizationalUnit
    portfolio_share_test.go:129: this AWS account must be the management account of an AWS Organization
=== RUN   TestAccServiceCatalog_serial/PortfolioShare/disappears
    portfolio_share_test.go:168: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
=== RUN   TestAccServiceCatalog_serial/PortfolioShare/basic
    portfolio_share_test.go:32: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- PASS: TestAccServiceCatalog_serial (9.48s)
    --- PASS: TestAccServiceCatalog_serial/OrganizationsAccess (1.39s)
        --- SKIP: TestAccServiceCatalog_serial/OrganizationsAccess/basic (1.39s)
    --- PASS: TestAccServiceCatalog_serial/PortfolioShare (8.09s)
        --- SKIP: TestAccServiceCatalog_serial/PortfolioShare/sharePrincipals (5.55s)
        --- SKIP: TestAccServiceCatalog_serial/PortfolioShare/organizationalUnit (2.54s)
        --- SKIP: TestAccServiceCatalog_serial/PortfolioShare/disappears (0.00s)
        --- SKIP: TestAccServiceCatalog_serial/PortfolioShare/basic (0.00s)
--- PASS: TestAccServiceCatalogProduct_tags_DefaultTags_overlapping (111.70s)
--- PASS: TestAccServiceCatalogTagOptionResourceAssociation_basic (20.54s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tags_null (124.63s)
--- PASS: TestAccServiceCatalogProvisionedProduct_update (196.81s)
--- PASS: TestAccServiceCatalogServiceAction_disappears (17.98s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tags_ComputedTag_OnUpdate_Add (205.05s)
--- PASS: TestAccServiceCatalogServiceAction_basic (21.01s)
--- PASS: TestAccServiceCatalogTagOption_update (62.33s)
--- PASS: TestAccServiceCatalogServiceAction_update (31.78s)
--- PASS: TestAccServiceCatalogPortfolioDataSource_basic (19.92s)
--- PASS: TestAccServiceCatalogPortfolioDataSource_tags (17.01s)
--- PASS: TestAccServiceCatalogPortfolio_tags_null (27.37s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_nullOverlappingResourceTag (106.94s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tags_ComputedTag_OnCreate (107.51s)
--- PASS: TestAccServiceCatalogPortfolioConstraintsDataSource_Constraint_basic (41.48s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_nullNonOverlappingResourceTag (106.46s)
=== NAME  TestAccServiceCatalogProvisionedProduct_tags
    provisioned_product_tags_gen_test.go:1904: Skipping step: Resource ProvisionedProduct does not support removing tags
    provisioned_product_tags_gen_test.go:26: Skipping step 5/8 due to SkipFunc
    provisioned_product_tags_gen_test.go:1904: Skipping step: Resource ProvisionedProduct does not support removing tags
    provisioned_product_tags_gen_test.go:26: Skipping step 6/8 due to SkipFunc
    provisioned_product_tags_gen_test.go:1904: Skipping step: Resource ProvisionedProduct does not support removing tags
    provisioned_product_tags_gen_test.go:26: Skipping step 7/8 due to SkipFunc
    provisioned_product_tags_gen_test.go:1904: Skipping step: Resource ProvisionedProduct does not support removing tags
    provisioned_product_tags_gen_test.go:26: Skipping step 8/8 due to SkipFunc
=== NAME  TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_nonOverlapping
    provisioned_product_tags_gen_test.go:1904: Skipping step: Resource ProvisionedProduct does not support removing tags
    provisioned_product_tags_gen_test.go:869: Skipping step 5/6 due to SkipFunc
    provisioned_product_tags_gen_test.go:1904: Skipping step: Resource ProvisionedProduct does not support removing tags
    provisioned_product_tags_gen_test.go:869: Skipping step 6/6 due to SkipFunc
--- PASS: TestAccServiceCatalogProvisioningArtifact_disappears (38.07s)
=== NAME  TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_providerOnly
    provisioned_product_tags_gen_test.go:1904: Skipping step: Resource ProvisionedProduct does not support removing tags
    provisioned_product_tags_gen_test.go:672: Skipping step 5/8 due to SkipFunc
    provisioned_product_tags_gen_test.go:1904: Skipping step: Resource ProvisionedProduct does not support removing tags
    provisioned_product_tags_gen_test.go:672: Skipping step 6/8 due to SkipFunc
    provisioned_product_tags_gen_test.go:1904: Skipping step: Resource ProvisionedProduct does not support removing tags
    provisioned_product_tags_gen_test.go:672: Skipping step 7/8 due to SkipFunc
    provisioned_product_tags_gen_test.go:1904: Skipping step: Resource ProvisionedProduct does not support removing tags
    provisioned_product_tags_gen_test.go:672: Skipping step 8/8 due to SkipFunc
--- PASS: TestAccServiceCatalogProvisionedProduct_tags (203.32s)
--- PASS: TestAccServiceCatalogLaunchPathsDataSource_basic (67.18s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tags_AddOnUpdate (195.41s)
--- PASS: TestAccServiceCatalogProduct_tags_DefaultTags_providerOnly (152.58s)
--- PASS: TestAccServiceCatalogProvisioningArtifact_basic (45.93s)
--- PASS: TestAccServiceCatalogPortfolio_tags (71.35s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_nonOverlapping (205.96s)
--- PASS: TestAccServiceCatalogProduct_tags_null (49.76s)
--- PASS: TestAccServiceCatalogPortfolio_disappears (17.25s)
--- PASS: TestAccServiceCatalogConstraint_basic (50.37s)
--- PASS: TestAccServiceCatalogConstraint_disappears (41.73s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_providerOnly (207.51s)
--- PASS: TestAccServiceCatalogProvisioningArtifact_physicalID (68.22s)
--- PASS: TestAccServiceCatalogProvisioningArtifact_update (73.28s)
--- PASS: TestAccServiceCatalogConstraint_update (73.85s)
--- PASS: TestAccServiceCatalogBudgetResourceAssociation_disappears (25.46s)
--- PASS: TestAccServiceCatalogProvisionedProduct_errorOnCreate (53.67s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_overlapping (321.02s)
--- PASS: TestAccServiceCatalogProduct_tags_ComputedTag_OnUpdate_Replace (64.56s)
--- PASS: TestAccServiceCatalogConstraintDataSource_basic (51.89s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_updateToResourceOnly (149.77s)
--- PASS: TestAccServiceCatalogProvisionedProduct_disappears (96.47s)
--- PASS: TestAccServiceCatalogProduct_tags (126.35s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_updateToProviderOnly (160.82s)
--- PASS: TestAccServiceCatalogProvisionedProduct_stackSetProvisioningPreferences (212.50s)
--- PASS: TestAccServiceCatalogProvisionedProduct_productTagUpdateAfterError (197.27s)
--- PASS: TestAccServiceCatalogProvisionedProduct_errorOnUpdate (186.15s)
--- PASS: TestAccServiceCatalogProvisionedProduct_ProvisioningArtifactName_update (152.19s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tags_ComputedTag_OnUpdate_Replace (191.33s)
--- PASS: TestAccServiceCatalogProvisionedProduct_basic (96.97s)
--- PASS: TestAccServiceCatalogProvisionedProduct_computedOutputs (202.27s)
PASS
ok   	github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog	496.122s

@bschaatsbergen bschaatsbergen marked this pull request as ready for review August 7, 2024 11:12
@bschaatsbergen bschaatsbergen requested a review from a team as a code owner August 7, 2024 11:12
@ewbankkit ewbankkit self-assigned this Aug 8, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 8, 2024
ewbankkit
ewbankkit approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccServiceCatalog' PKG=servicecatalog ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/servicecatalog/... -v -count 1 -parallel 4  -run=TestAccServiceCatalog -timeout 360m
=== RUN   TestAccServiceCatalogBudgetResourceAssociation_basic
=== PAUSE TestAccServiceCatalogBudgetResourceAssociation_basic
=== RUN   TestAccServiceCatalogBudgetResourceAssociation_disappears
=== PAUSE TestAccServiceCatalogBudgetResourceAssociation_disappears
=== RUN   TestAccServiceCatalogConstraintDataSource_basic
=== PAUSE TestAccServiceCatalogConstraintDataSource_basic
=== RUN   TestAccServiceCatalogConstraint_basic
=== PAUSE TestAccServiceCatalogConstraint_basic
=== RUN   TestAccServiceCatalogConstraint_disappears
=== PAUSE TestAccServiceCatalogConstraint_disappears
=== RUN   TestAccServiceCatalogConstraint_update
=== PAUSE TestAccServiceCatalogConstraint_update
=== RUN   TestAccServiceCatalogLaunchPathsDataSource_basic
=== PAUSE TestAccServiceCatalogLaunchPathsDataSource_basic
=== RUN   TestAccServiceCatalogPortfolioConstraintsDataSource_Constraint_basic
=== PAUSE TestAccServiceCatalogPortfolioConstraintsDataSource_Constraint_basic
=== RUN   TestAccServiceCatalogPortfolioDataSource_tags
=== PAUSE TestAccServiceCatalogPortfolioDataSource_tags
=== RUN   TestAccServiceCatalogPortfolioDataSource_basic
=== PAUSE TestAccServiceCatalogPortfolioDataSource_basic
=== RUN   TestAccServiceCatalogPortfolio_tags
=== PAUSE TestAccServiceCatalogPortfolio_tags
=== RUN   TestAccServiceCatalogPortfolio_tags_null
=== PAUSE TestAccServiceCatalogPortfolio_tags_null
=== RUN   TestAccServiceCatalogPortfolio_tags_AddOnUpdate
=== PAUSE TestAccServiceCatalogPortfolio_tags_AddOnUpdate
=== RUN   TestAccServiceCatalogPortfolio_tags_EmptyTag_OnCreate
    portfolio_tags_gen_test.go:329: Resource Portfolio does not support empty tags
--- SKIP: TestAccServiceCatalogPortfolio_tags_EmptyTag_OnCreate (0.00s)
=== RUN   TestAccServiceCatalogPortfolio_tags_EmptyTag_OnUpdate_Add
    portfolio_tags_gen_test.go:416: Resource Portfolio does not support empty tags
--- SKIP: TestAccServiceCatalogPortfolio_tags_EmptyTag_OnUpdate_Add (0.00s)
=== RUN   TestAccServiceCatalogPortfolio_tags_EmptyTag_OnUpdate_Replace
    portfolio_tags_gen_test.go:545: Resource Portfolio does not support empty tags
--- SKIP: TestAccServiceCatalogPortfolio_tags_EmptyTag_OnUpdate_Replace (0.00s)
=== RUN   TestAccServiceCatalogPortfolio_tags_DefaultTags_providerOnly
=== PAUSE TestAccServiceCatalogPortfolio_tags_DefaultTags_providerOnly
=== RUN   TestAccServiceCatalogPortfolio_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccServiceCatalogPortfolio_tags_DefaultTags_nonOverlapping
=== RUN   TestAccServiceCatalogPortfolio_tags_DefaultTags_overlapping
=== PAUSE TestAccServiceCatalogPortfolio_tags_DefaultTags_overlapping
=== RUN   TestAccServiceCatalogPortfolio_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccServiceCatalogPortfolio_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccServiceCatalogPortfolio_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccServiceCatalogPortfolio_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccServiceCatalogPortfolio_tags_DefaultTags_emptyResourceTag
    portfolio_tags_gen_test.go:1326: Resource Portfolio does not support empty tags
--- SKIP: TestAccServiceCatalogPortfolio_tags_DefaultTags_emptyResourceTag (0.00s)
=== RUN   TestAccServiceCatalogPortfolio_tags_DefaultTags_emptyProviderOnlyTag
    portfolio_tags_gen_test.go:1393: Resource Portfolio does not support empty tags
--- SKIP: TestAccServiceCatalogPortfolio_tags_DefaultTags_emptyProviderOnlyTag (0.00s)
=== RUN   TestAccServiceCatalogPortfolio_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccServiceCatalogPortfolio_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccServiceCatalogPortfolio_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccServiceCatalogPortfolio_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccServiceCatalogPortfolio_tags_ComputedTag_OnCreate
=== PAUSE TestAccServiceCatalogPortfolio_tags_ComputedTag_OnCreate
=== RUN   TestAccServiceCatalogPortfolio_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccServiceCatalogPortfolio_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccServiceCatalogPortfolio_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccServiceCatalogPortfolio_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccServiceCatalogPortfolio_basic
=== PAUSE TestAccServiceCatalogPortfolio_basic
=== RUN   TestAccServiceCatalogPortfolio_disappears
=== PAUSE TestAccServiceCatalogPortfolio_disappears
=== RUN   TestAccServiceCatalogPrincipalPortfolioAssociation_basic
=== PAUSE TestAccServiceCatalogPrincipalPortfolioAssociation_basic
=== RUN   TestAccServiceCatalogPrincipalPortfolioAssociation_iam_pattern
=== PAUSE TestAccServiceCatalogPrincipalPortfolioAssociation_iam_pattern
=== RUN   TestAccServiceCatalogPrincipalPortfolioAssociation_disappears
=== PAUSE TestAccServiceCatalogPrincipalPortfolioAssociation_disappears
=== RUN   TestAccServiceCatalogPrincipalPortfolioAssociation_migrateV0
=== PAUSE TestAccServiceCatalogPrincipalPortfolioAssociation_migrateV0
=== RUN   TestAccServiceCatalogProductDataSource_tags
=== PAUSE TestAccServiceCatalogProductDataSource_tags
=== RUN   TestAccServiceCatalogProductDataSource_basic
=== PAUSE TestAccServiceCatalogProductDataSource_basic
=== RUN   TestAccServiceCatalogProductDataSource_physicalID
=== PAUSE TestAccServiceCatalogProductDataSource_physicalID
=== RUN   TestAccServiceCatalogProductPortfolioAssociation_basic
=== PAUSE TestAccServiceCatalogProductPortfolioAssociation_basic
=== RUN   TestAccServiceCatalogProductPortfolioAssociation_disappears
=== PAUSE TestAccServiceCatalogProductPortfolioAssociation_disappears
=== RUN   TestAccServiceCatalogProduct_tags
=== PAUSE TestAccServiceCatalogProduct_tags
=== RUN   TestAccServiceCatalogProduct_tags_null
=== PAUSE TestAccServiceCatalogProduct_tags_null
=== RUN   TestAccServiceCatalogProduct_tags_AddOnUpdate
=== PAUSE TestAccServiceCatalogProduct_tags_AddOnUpdate
=== RUN   TestAccServiceCatalogProduct_tags_EmptyTag_OnCreate
    product_tags_gen_test.go:343: Resource Product does not support empty tags
--- SKIP: TestAccServiceCatalogProduct_tags_EmptyTag_OnCreate (0.00s)
=== RUN   TestAccServiceCatalogProduct_tags_EmptyTag_OnUpdate_Add
    product_tags_gen_test.go:435: Resource Product does not support empty tags
--- SKIP: TestAccServiceCatalogProduct_tags_EmptyTag_OnUpdate_Add (0.00s)
=== RUN   TestAccServiceCatalogProduct_tags_EmptyTag_OnUpdate_Replace
    product_tags_gen_test.go:569: Resource Product does not support empty tags
--- SKIP: TestAccServiceCatalogProduct_tags_EmptyTag_OnUpdate_Replace (0.00s)
=== RUN   TestAccServiceCatalogProduct_tags_DefaultTags_providerOnly
=== PAUSE TestAccServiceCatalogProduct_tags_DefaultTags_providerOnly
=== RUN   TestAccServiceCatalogProduct_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccServiceCatalogProduct_tags_DefaultTags_nonOverlapping
=== RUN   TestAccServiceCatalogProduct_tags_DefaultTags_overlapping
=== PAUSE TestAccServiceCatalogProduct_tags_DefaultTags_overlapping
=== RUN   TestAccServiceCatalogProduct_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccServiceCatalogProduct_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccServiceCatalogProduct_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccServiceCatalogProduct_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccServiceCatalogProduct_tags_DefaultTags_emptyResourceTag
    product_tags_gen_test.go:1383: Resource Product does not support empty tags
--- SKIP: TestAccServiceCatalogProduct_tags_DefaultTags_emptyResourceTag (0.00s)
=== RUN   TestAccServiceCatalogProduct_tags_DefaultTags_emptyProviderOnlyTag
    product_tags_gen_test.go:1452: Resource Product does not support empty tags
--- SKIP: TestAccServiceCatalogProduct_tags_DefaultTags_emptyProviderOnlyTag (0.00s)
=== RUN   TestAccServiceCatalogProduct_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccServiceCatalogProduct_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccServiceCatalogProduct_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccServiceCatalogProduct_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccServiceCatalogProduct_tags_ComputedTag_OnCreate
=== PAUSE TestAccServiceCatalogProduct_tags_ComputedTag_OnCreate
=== RUN   TestAccServiceCatalogProduct_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccServiceCatalogProduct_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccServiceCatalogProduct_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccServiceCatalogProduct_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccServiceCatalogProduct_basic
=== PAUSE TestAccServiceCatalogProduct_basic
=== RUN   TestAccServiceCatalogProduct_disappears
=== PAUSE TestAccServiceCatalogProduct_disappears
=== RUN   TestAccServiceCatalogProduct_update
=== PAUSE TestAccServiceCatalogProduct_update
=== RUN   TestAccServiceCatalogProduct_physicalID
=== PAUSE TestAccServiceCatalogProduct_physicalID
=== RUN   TestAccServiceCatalogProvisionedProduct_tags
=== PAUSE TestAccServiceCatalogProvisionedProduct_tags
=== RUN   TestAccServiceCatalogProvisionedProduct_tags_null
=== PAUSE TestAccServiceCatalogProvisionedProduct_tags_null
=== RUN   TestAccServiceCatalogProvisionedProduct_tags_AddOnUpdate
=== PAUSE TestAccServiceCatalogProvisionedProduct_tags_AddOnUpdate
=== RUN   TestAccServiceCatalogProvisionedProduct_tags_EmptyTag_OnCreate
    provisioned_product_tags_gen_test.go:351: Resource ProvisionedProduct does not support empty tags
--- SKIP: TestAccServiceCatalogProvisionedProduct_tags_EmptyTag_OnCreate (0.00s)
=== RUN   TestAccServiceCatalogProvisionedProduct_tags_EmptyTag_OnUpdate_Add
    provisioned_product_tags_gen_test.go:444: Resource ProvisionedProduct does not support empty tags
--- SKIP: TestAccServiceCatalogProvisionedProduct_tags_EmptyTag_OnUpdate_Add (0.00s)
=== RUN   TestAccServiceCatalogProvisionedProduct_tags_EmptyTag_OnUpdate_Replace
    provisioned_product_tags_gen_test.go:579: Resource ProvisionedProduct does not support empty tags
--- SKIP: TestAccServiceCatalogProvisionedProduct_tags_EmptyTag_OnUpdate_Replace (0.00s)
=== RUN   TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_providerOnly
=== PAUSE TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_providerOnly
=== RUN   TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_nonOverlapping
=== RUN   TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_overlapping
=== PAUSE TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_overlapping
=== RUN   TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_emptyResourceTag
    provisioned_product_tags_gen_test.go:1405: Resource ProvisionedProduct does not support empty tags
--- SKIP: TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_emptyResourceTag (0.00s)
=== RUN   TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_emptyProviderOnlyTag
    provisioned_product_tags_gen_test.go:1475: Resource ProvisionedProduct does not support empty tags
--- SKIP: TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_emptyProviderOnlyTag (0.00s)
=== RUN   TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccServiceCatalogProvisionedProduct_tags_ComputedTag_OnCreate
=== PAUSE TestAccServiceCatalogProvisionedProduct_tags_ComputedTag_OnCreate
=== RUN   TestAccServiceCatalogProvisionedProduct_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccServiceCatalogProvisionedProduct_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccServiceCatalogProvisionedProduct_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccServiceCatalogProvisionedProduct_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccServiceCatalogProvisionedProduct_basic
=== PAUSE TestAccServiceCatalogProvisionedProduct_basic
=== RUN   TestAccServiceCatalogProvisionedProduct_update
=== PAUSE TestAccServiceCatalogProvisionedProduct_update
=== RUN   TestAccServiceCatalogProvisionedProduct_stackSetProvisioningPreferences
=== PAUSE TestAccServiceCatalogProvisionedProduct_stackSetProvisioningPreferences
=== RUN   TestAccServiceCatalogProvisionedProduct_ProductName_update
=== PAUSE TestAccServiceCatalogProvisionedProduct_ProductName_update
=== RUN   TestAccServiceCatalogProvisionedProduct_ProvisioningArtifactName_update
=== PAUSE TestAccServiceCatalogProvisionedProduct_ProvisioningArtifactName_update
=== RUN   TestAccServiceCatalogProvisionedProduct_computedOutputs
=== PAUSE TestAccServiceCatalogProvisionedProduct_computedOutputs
=== RUN   TestAccServiceCatalogProvisionedProduct_disappears
=== PAUSE TestAccServiceCatalogProvisionedProduct_disappears
=== RUN   TestAccServiceCatalogProvisionedProduct_errorOnCreate
=== PAUSE TestAccServiceCatalogProvisionedProduct_errorOnCreate
=== RUN   TestAccServiceCatalogProvisionedProduct_errorOnUpdate
=== PAUSE TestAccServiceCatalogProvisionedProduct_errorOnUpdate
=== RUN   TestAccServiceCatalogProvisionedProduct_productTagUpdateAfterError
=== PAUSE TestAccServiceCatalogProvisionedProduct_productTagUpdateAfterError
=== RUN   TestAccServiceCatalogProvisioningArtifact_basic
=== PAUSE TestAccServiceCatalogProvisioningArtifact_basic
=== RUN   TestAccServiceCatalogProvisioningArtifact_disappears
=== PAUSE TestAccServiceCatalogProvisioningArtifact_disappears
=== RUN   TestAccServiceCatalogProvisioningArtifact_update
=== PAUSE TestAccServiceCatalogProvisioningArtifact_update
=== RUN   TestAccServiceCatalogProvisioningArtifact_physicalID
=== PAUSE TestAccServiceCatalogProvisioningArtifact_physicalID
=== RUN   TestAccServiceCatalogProvisioningArtifactsDataSource_basic
=== PAUSE TestAccServiceCatalogProvisioningArtifactsDataSource_basic
=== RUN   TestAccServiceCatalogServiceAction_basic
=== PAUSE TestAccServiceCatalogServiceAction_basic
=== RUN   TestAccServiceCatalogServiceAction_disappears
=== PAUSE TestAccServiceCatalogServiceAction_disappears
=== RUN   TestAccServiceCatalogServiceAction_update
=== PAUSE TestAccServiceCatalogServiceAction_update
=== RUN   TestAccServiceCatalog_serial
=== PAUSE TestAccServiceCatalog_serial
=== RUN   TestAccServiceCatalogTagOptionResourceAssociation_basic
=== PAUSE TestAccServiceCatalogTagOptionResourceAssociation_basic
=== RUN   TestAccServiceCatalogTagOptionResourceAssociation_disappears
=== PAUSE TestAccServiceCatalogTagOptionResourceAssociation_disappears
=== RUN   TestAccServiceCatalogTagOption_basic
=== PAUSE TestAccServiceCatalogTagOption_basic
=== RUN   TestAccServiceCatalogTagOption_disappears
=== PAUSE TestAccServiceCatalogTagOption_disappears
=== RUN   TestAccServiceCatalogTagOption_update
=== PAUSE TestAccServiceCatalogTagOption_update
=== RUN   TestAccServiceCatalogTagOption_notActive
=== PAUSE TestAccServiceCatalogTagOption_notActive
=== CONT  TestAccServiceCatalogBudgetResourceAssociation_basic
=== CONT  TestAccServiceCatalogProduct_tags_ComputedTag_OnUpdate_Add
=== CONT  TestAccServiceCatalogProvisionedProduct_ProductName_update
=== CONT  TestAccServiceCatalogPortfolio_basic
--- PASS: TestAccServiceCatalogPortfolio_basic (12.21s)
=== CONT  TestAccServiceCatalogTagOption_notActive
--- PASS: TestAccServiceCatalogTagOption_notActive (8.79s)
=== CONT  TestAccServiceCatalogTagOption_update
--- PASS: TestAccServiceCatalogBudgetResourceAssociation_basic (22.01s)
=== CONT  TestAccServiceCatalogTagOption_disappears
--- PASS: TestAccServiceCatalogTagOption_disappears (9.90s)
=== CONT  TestAccServiceCatalogTagOption_basic
--- PASS: TestAccServiceCatalogTagOption_basic (11.27s)
=== CONT  TestAccServiceCatalogTagOptionResourceAssociation_disappears
--- PASS: TestAccServiceCatalogProduct_tags_ComputedTag_OnUpdate_Add (50.86s)
=== CONT  TestAccServiceCatalogTagOptionResourceAssociation_basic
--- PASS: TestAccServiceCatalogTagOptionResourceAssociation_disappears (11.80s)
=== CONT  TestAccServiceCatalog_serial
=== RUN   TestAccServiceCatalog_serial/OrganizationsAccess
=== RUN   TestAccServiceCatalog_serial/OrganizationsAccess/basic
    organizations_access_test.go:28: this AWS account must be the management account of an AWS Organization
=== RUN   TestAccServiceCatalog_serial/PortfolioShare
=== RUN   TestAccServiceCatalog_serial/PortfolioShare/basic
    portfolio_share_test.go:32: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
=== RUN   TestAccServiceCatalog_serial/PortfolioShare/sharePrincipals
--- PASS: TestAccServiceCatalogTagOption_update (35.21s)
=== CONT  TestAccServiceCatalogServiceAction_update
=== NAME  TestAccServiceCatalog_serial/PortfolioShare/sharePrincipals
    portfolio_share_test.go:86: this AWS account must be the management account of an AWS Organization
=== RUN   TestAccServiceCatalog_serial/PortfolioShare/organizationalUnit
    portfolio_share_test.go:129: this AWS account must be the management account of an AWS Organization
=== RUN   TestAccServiceCatalog_serial/PortfolioShare/disappears
    portfolio_share_test.go:168: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- PASS: TestAccServiceCatalog_serial (7.06s)
    --- PASS: TestAccServiceCatalog_serial/OrganizationsAccess (0.47s)
        --- SKIP: TestAccServiceCatalog_serial/OrganizationsAccess/basic (0.47s)
    --- PASS: TestAccServiceCatalog_serial/PortfolioShare (6.60s)
        --- SKIP: TestAccServiceCatalog_serial/PortfolioShare/basic (0.00s)
        --- SKIP: TestAccServiceCatalog_serial/PortfolioShare/sharePrincipals (4.15s)
        --- SKIP: TestAccServiceCatalog_serial/PortfolioShare/organizationalUnit (2.45s)
        --- SKIP: TestAccServiceCatalog_serial/PortfolioShare/disappears (0.00s)
=== CONT  TestAccServiceCatalogServiceAction_disappears
--- PASS: TestAccServiceCatalogTagOptionResourceAssociation_basic (12.47s)
=== CONT  TestAccServiceCatalogServiceAction_basic
--- PASS: TestAccServiceCatalogServiceAction_disappears (9.98s)
=== CONT  TestAccServiceCatalogProvisioningArtifactsDataSource_basic
--- PASS: TestAccServiceCatalogServiceAction_update (16.84s)
=== CONT  TestAccServiceCatalogProvisioningArtifact_physicalID
--- PASS: TestAccServiceCatalogServiceAction_basic (11.68s)
=== CONT  TestAccServiceCatalogProvisioningArtifact_update
--- PASS: TestAccServiceCatalogProvisioningArtifactsDataSource_basic (30.04s)
=== CONT  TestAccServiceCatalogProvisioningArtifact_disappears
--- PASS: TestAccServiceCatalogProvisioningArtifact_disappears (27.96s)
=== CONT  TestAccServiceCatalogProvisioningArtifact_basic
--- PASS: TestAccServiceCatalogProvisioningArtifact_update (55.82s)
=== CONT  TestAccServiceCatalogProvisionedProduct_productTagUpdateAfterError
--- PASS: TestAccServiceCatalogProvisioningArtifact_physicalID (58.93s)
=== CONT  TestAccServiceCatalogProvisionedProduct_errorOnUpdate
--- PASS: TestAccServiceCatalogProvisionedProduct_ProductName_update (146.53s)
=== CONT  TestAccServiceCatalogProvisionedProduct_errorOnCreate
--- PASS: TestAccServiceCatalogProvisioningArtifact_basic (33.90s)
=== CONT  TestAccServiceCatalogProvisionedProduct_disappears
--- PASS: TestAccServiceCatalogProvisionedProduct_errorOnCreate (47.77s)
=== CONT  TestAccServiceCatalogProvisionedProduct_computedOutputs
--- PASS: TestAccServiceCatalogProvisionedProduct_disappears (85.39s)
=== CONT  TestAccServiceCatalogProvisionedProduct_ProvisioningArtifactName_update
--- PASS: TestAccServiceCatalogProvisionedProduct_errorOnUpdate (167.06s)
=== CONT  TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_overlapping
--- PASS: TestAccServiceCatalogProvisionedProduct_productTagUpdateAfterError (177.40s)
=== CONT  TestAccServiceCatalogProvisionedProduct_stackSetProvisioningPreferences
--- PASS: TestAccServiceCatalogProvisionedProduct_computedOutputs (176.12s)
=== CONT  TestAccServiceCatalogProvisionedProduct_update
--- PASS: TestAccServiceCatalogProvisionedProduct_ProvisioningArtifactName_update (149.35s)
=== CONT  TestAccServiceCatalogProvisionedProduct_basic
--- PASS: TestAccServiceCatalogProvisionedProduct_basic (88.06s)
=== CONT  TestAccServiceCatalogProvisionedProduct_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccServiceCatalogProvisionedProduct_stackSetProvisioningPreferences (188.04s)
=== CONT  TestAccServiceCatalogProvisionedProduct_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccServiceCatalogProvisionedProduct_update (156.29s)
=== CONT  TestAccServiceCatalogProvisionedProduct_tags_ComputedTag_OnCreate
--- PASS: TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_overlapping (268.76s)
=== CONT  TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_nullNonOverlappingResourceTag
=== CONT  TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccServiceCatalogProvisionedProduct_tags_ComputedTag_OnCreate (98.44s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_nullOverlappingResourceTag (92.07s)
=== CONT  TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_nullNonOverlappingResourceTag (92.51s)
=== CONT  TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccServiceCatalogProvisionedProduct_tags_ComputedTag_OnUpdate_Replace (177.53s)
=== CONT  TestAccServiceCatalogProvisionedProduct_tags
--- PASS: TestAccServiceCatalogProvisionedProduct_tags_ComputedTag_OnUpdate_Add (174.51s)
=== CONT  TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_nonOverlapping
--- PASS: TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_updateToResourceOnly (128.55s)
=== CONT  TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_providerOnly
--- PASS: TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_updateToProviderOnly (166.32s)
=== CONT  TestAccServiceCatalogProvisionedProduct_tags_AddOnUpdate
=== NAME  TestAccServiceCatalogProvisionedProduct_tags
    provisioned_product_tags_gen_test.go:1904: Skipping step: Resource ProvisionedProduct does not support removing tags
    provisioned_product_tags_gen_test.go:26: Skipping step 5/8 due to SkipFunc
    provisioned_product_tags_gen_test.go:1904: Skipping step: Resource ProvisionedProduct does not support removing tags
    provisioned_product_tags_gen_test.go:26: Skipping step 6/8 due to SkipFunc
    provisioned_product_tags_gen_test.go:1904: Skipping step: Resource ProvisionedProduct does not support removing tags
    provisioned_product_tags_gen_test.go:26: Skipping step 7/8 due to SkipFunc
    provisioned_product_tags_gen_test.go:1904: Skipping step: Resource ProvisionedProduct does not support removing tags
    provisioned_product_tags_gen_test.go:26: Skipping step 8/8 due to SkipFunc
--- PASS: TestAccServiceCatalogProvisionedProduct_tags (176.84s)
=== CONT  TestAccServiceCatalogProvisionedProduct_tags_null
=== NAME  TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_nonOverlapping
    provisioned_product_tags_gen_test.go:1904: Skipping step: Resource ProvisionedProduct does not support removing tags
    provisioned_product_tags_gen_test.go:869: Skipping step 5/6 due to SkipFunc
    provisioned_product_tags_gen_test.go:1904: Skipping step: Resource ProvisionedProduct does not support removing tags
    provisioned_product_tags_gen_test.go:869: Skipping step 6/6 due to SkipFunc
=== NAME  TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_providerOnly
    provisioned_product_tags_gen_test.go:1904: Skipping step: Resource ProvisionedProduct does not support removing tags
    provisioned_product_tags_gen_test.go:672: Skipping step 5/8 due to SkipFunc
    provisioned_product_tags_gen_test.go:1904: Skipping step: Resource ProvisionedProduct does not support removing tags
    provisioned_product_tags_gen_test.go:672: Skipping step 6/8 due to SkipFunc
    provisioned_product_tags_gen_test.go:1904: Skipping step: Resource ProvisionedProduct does not support removing tags
    provisioned_product_tags_gen_test.go:672: Skipping step 7/8 due to SkipFunc
    provisioned_product_tags_gen_test.go:1904: Skipping step: Resource ProvisionedProduct does not support removing tags
    provisioned_product_tags_gen_test.go:672: Skipping step 8/8 due to SkipFunc
--- PASS: TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_nonOverlapping (184.78s)
=== CONT  TestAccServiceCatalogProduct_disappears
--- PASS: TestAccServiceCatalogProvisionedProduct_tags_DefaultTags_providerOnly (184.89s)
=== CONT  TestAccServiceCatalogProduct_physicalID
--- PASS: TestAccServiceCatalogProduct_disappears (21.10s)
=== CONT  TestAccServiceCatalogProduct_update
--- PASS: TestAccServiceCatalogProduct_physicalID (51.85s)
=== CONT  TestAccServiceCatalogProduct_tags
--- PASS: TestAccServiceCatalogProduct_update (40.53s)
=== CONT  TestAccServiceCatalogProduct_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccServiceCatalogProvisionedProduct_tags_null (108.33s)
=== CONT  TestAccServiceCatalogProduct_tags_ComputedTag_OnCreate
--- PASS: TestAccServiceCatalogProduct_tags_DefaultTags_updateToProviderOnly (51.66s)
=== CONT  TestAccServiceCatalogProduct_tags_DefaultTags_overlapping
--- PASS: TestAccServiceCatalogProduct_tags_ComputedTag_OnCreate (31.13s)
=== CONT  TestAccServiceCatalogProduct_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccServiceCatalogProduct_tags_DefaultTags_nullNonOverlappingResourceTag (28.80s)
=== CONT  TestAccServiceCatalogProduct_tags_DefaultTags_nonOverlapping
--- PASS: TestAccServiceCatalogProduct_tags (101.45s)
=== CONT  TestAccServiceCatalogProduct_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccServiceCatalogProduct_tags_DefaultTags_nullOverlappingResourceTag (29.01s)
=== CONT  TestAccServiceCatalogProduct_tags_DefaultTags_providerOnly
--- PASS: TestAccServiceCatalogProvisionedProduct_tags_AddOnUpdate (215.44s)
=== CONT  TestAccServiceCatalogProduct_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccServiceCatalogProduct_tags_DefaultTags_overlapping (81.07s)
=== CONT  TestAccServiceCatalogProduct_tags_AddOnUpdate
--- PASS: TestAccServiceCatalogProduct_tags_DefaultTags_updateToResourceOnly (45.93s)
=== CONT  TestAccServiceCatalogProduct_tags_null
--- PASS: TestAccServiceCatalogProduct_tags_DefaultTags_nonOverlapping (80.37s)
=== CONT  TestAccServiceCatalogProductDataSource_tags
--- PASS: TestAccServiceCatalogProduct_tags_AddOnUpdate (45.61s)
=== CONT  TestAccServiceCatalogProductPortfolioAssociation_disappears
--- PASS: TestAccServiceCatalogProductDataSource_tags (28.74s)
=== CONT  TestAccServiceCatalogProduct_basic
--- PASS: TestAccServiceCatalogProduct_tags_null (34.97s)
=== CONT  TestAccServiceCatalogProductPortfolioAssociation_basic
--- PASS: TestAccServiceCatalogProduct_tags_DefaultTags_providerOnly (105.82s)
=== CONT  TestAccServiceCatalogProduct_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccServiceCatalogProduct_basic (27.61s)
=== CONT  TestAccServiceCatalogProductDataSource_physicalID
--- PASS: TestAccServiceCatalogProductPortfolioAssociation_disappears (52.39s)
=== CONT  TestAccServiceCatalogProductDataSource_basic
--- PASS: TestAccServiceCatalogProductDataSource_basic (30.36s)
=== CONT  TestAccServiceCatalogPortfolio_tags_AddOnUpdate
--- PASS: TestAccServiceCatalogProductPortfolioAssociation_basic (57.77s)
=== CONT  TestAccServiceCatalogPrincipalPortfolioAssociation_iam_pattern
--- PASS: TestAccServiceCatalogPrincipalPortfolioAssociation_iam_pattern (12.58s)
=== CONT  TestAccServiceCatalogPortfolio_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccServiceCatalogProduct_tags_ComputedTag_OnUpdate_Replace (52.41s)
=== CONT  TestAccServiceCatalogPrincipalPortfolioAssociation_migrateV0
--- PASS: TestAccServiceCatalogPortfolio_tags_AddOnUpdate (21.34s)
=== CONT  TestAccServiceCatalogPortfolio_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccServiceCatalogProductDataSource_physicalID (56.30s)
=== CONT  TestAccServiceCatalogPrincipalPortfolioAssociation_disappears
--- PASS: TestAccServiceCatalogPortfolio_tags_ComputedTag_OnUpdate_Replace (26.09s)
=== CONT  TestAccServiceCatalogLaunchPathsDataSource_basic
--- PASS: TestAccServiceCatalogPrincipalPortfolioAssociation_disappears (20.24s)
=== CONT  TestAccServiceCatalogPortfolio_tags_ComputedTag_OnCreate
--- PASS: TestAccServiceCatalogPortfolio_tags_ComputedTag_OnUpdate_Add (27.51s)
=== CONT  TestAccServiceCatalogPortfolio_tags_null
--- PASS: TestAccServiceCatalogPortfolio_tags_ComputedTag_OnCreate (16.18s)
=== CONT  TestAccServiceCatalogPortfolio_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccServiceCatalogPortfolio_tags_null (16.01s)
=== CONT  TestAccServiceCatalogPortfolio_tags
--- PASS: TestAccServiceCatalogPortfolio_tags_DefaultTags_nullNonOverlappingResourceTag (13.59s)
=== CONT  TestAccServiceCatalogPortfolio_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccServiceCatalogPrincipalPortfolioAssociation_migrateV0 (55.58s)
=== CONT  TestAccServiceCatalogPortfolioDataSource_basic
--- PASS: TestAccServiceCatalogPortfolioDataSource_basic (10.83s)
=== CONT  TestAccServiceCatalogPortfolio_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccServiceCatalogPortfolio_tags_DefaultTags_nullOverlappingResourceTag (13.48s)
=== CONT  TestAccServiceCatalogPortfolioDataSource_tags
--- PASS: TestAccServiceCatalogPortfolioDataSource_tags (9.62s)
=== CONT  TestAccServiceCatalogPortfolio_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccServiceCatalogLaunchPathsDataSource_basic (59.93s)
=== CONT  TestAccServiceCatalogPortfolioConstraintsDataSource_Constraint_basic
--- PASS: TestAccServiceCatalogPortfolio_tags_DefaultTags_updateToResourceOnly (19.45s)
=== CONT  TestAccServiceCatalogPortfolio_tags_DefaultTags_overlapping
--- PASS: TestAccServiceCatalogPortfolio_tags (43.76s)
=== CONT  TestAccServiceCatalogPortfolio_tags_DefaultTags_nonOverlapping
--- PASS: TestAccServiceCatalogPortfolio_tags_DefaultTags_updateToProviderOnly (21.00s)
=== CONT  TestAccServiceCatalogPrincipalPortfolioAssociation_basic
--- PASS: TestAccServiceCatalogPortfolioConstraintsDataSource_Constraint_basic (33.42s)
=== CONT  TestAccServiceCatalogPortfolio_tags_DefaultTags_providerOnly
--- PASS: TestAccServiceCatalogPortfolio_tags_DefaultTags_overlapping (33.80s)
=== CONT  TestAccServiceCatalogConstraint_basic
--- PASS: TestAccServiceCatalogPrincipalPortfolioAssociation_basic (21.40s)
=== CONT  TestAccServiceCatalogConstraintDataSource_basic
--- PASS: TestAccServiceCatalogPortfolio_tags_DefaultTags_nonOverlapping (33.73s)
=== CONT  TestAccServiceCatalogConstraint_update
--- PASS: TestAccServiceCatalogConstraint_basic (38.29s)
=== CONT  TestAccServiceCatalogConstraint_disappears
--- PASS: TestAccServiceCatalogPortfolio_tags_DefaultTags_providerOnly (46.31s)
=== CONT  TestAccServiceCatalogPortfolio_disappears
--- PASS: TestAccServiceCatalogConstraintDataSource_basic (42.68s)
=== CONT  TestAccServiceCatalogBudgetResourceAssociation_disappears
--- PASS: TestAccServiceCatalogPortfolio_disappears (10.59s)
--- PASS: TestAccServiceCatalogConstraint_update (59.88s)
--- PASS: TestAccServiceCatalogBudgetResourceAssociation_disappears (20.64s)
--- PASS: TestAccServiceCatalogConstraint_disappears (33.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog	1393.650s

@ewbankkit
Copy link
Contributor

@bschaatsbergen @DanielRieske Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 0f98773 into hashicorp:main Aug 8, 2024
41 checks passed
@github-actions github-actions bot added this to the v5.62.0 milestone Aug 8, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

This functionality has been released in v5.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@bschaatsbergen bschaatsbergen deleted the migrate-service-catalog-to-v2 branch August 9, 2024 12:18
@DanielRieske DanielRieske mentioned this pull request Aug 13, 2024
Closed
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tags Pertains to resource tagging. labels Aug 16, 2024
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.62.0
Development

Successfully merging this pull request may close these issues.

[AWS SDK for Go Migration] Service Catalog Service
4 participants
@bschaatsbergen @DanielRieske @ewbankkit @justinretzolk