Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appflow flow status #37501

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Viriathus1
Copy link
Contributor

Description

Following up on #34948. Allow flow status to be configurable in resource block for Scheduled or Event triggered flows. Main use case is to obviate the need to manually activate an AppFlow during resource creation and update.

Relations

Closes #36441

References

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-appflow-flow.html#cfn-appflow-flow-flowstatus
https://docs.aws.amazon.com/appflow/1.0/APIReference/API_StartFlow.html
https://docs.aws.amazon.com/appflow/1.0/APIReference/API_StopFlow.html

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccAppFlowFlow_update' PKG=appflow
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/appflow/... -v -count 1 -parallel 20  -run=TestAccAppFlowFlow_update -timeout 360m
=== RUN   TestAccAppFlowFlow_update
=== PAUSE TestAccAppFlowFlow_update
=== CONT  TestAccAppFlowFlow_update
--- PASS: TestAccAppFlowFlow_update (48.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appflow	55.036s
% make testacc TESTARGS='-run=TestAccAppFlowFlow_activateFlowStatus' PKG=appflow
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/appflow/... -v -count 1 -parallel 20  -run=TestAccAppFlowFlow_activateFlowStatus -timeout 360m
=== RUN   TestAccAppFlowFlow_activateFlowStatus
=== PAUSE TestAccAppFlowFlow_activateFlowStatus
=== CONT  TestAccAppFlowFlow_activateFlowStatus
--- PASS: TestAccAppFlowFlow_activateFlowStatus (37.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appflow	43.912s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/appflow Issues and PRs that pertain to the appflow service. size/XL Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/appflow Issues and PRs that pertain to the appflow service. labels May 14, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label May 14, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @Viriathus1 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. service/appflow Issues and PRs that pertain to the appflow service. and removed needs-triage Waiting for first response or review from a maintainer. labels May 16, 2024
@Viriathus1 Viriathus1 requested a review from a team as a code owner June 14, 2024 05:10
@Viriathus1
Copy link
Contributor Author

Output from updated Acceptance Testing

% make testacc TESTARGS='-run=TestAccAppFlowFlow_update' PKG=appflow
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/appflow/... -v -count 1 -parallel 20  -run=TestAccAppFlowFlow_update -timeout 360m
=== RUN   TestAccAppFlowFlow_update
=== PAUSE TestAccAppFlowFlow_update
=== CONT  TestAccAppFlowFlow_update
--- PASS: TestAccAppFlowFlow_update (46.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appflow	53.445s
% make testacc TESTARGS='-run=TestAccAppFlowFlow_createWithActiveFlowStatus' PKG=appflow
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/appflow/... -v -count 1 -parallel 20  -run=TestAccAppFlowFlow_createWithActiveFlowStatus -timeout 360m
=== RUN   TestAccAppFlowFlow_createWithActiveFlowStatus
=== PAUSE TestAccAppFlowFlow_createWithActiveFlowStatus
=== CONT  TestAccAppFlowFlow_createWithActiveFlowStatus
--- PASS: TestAccAppFlowFlow_createWithActiveFlowStatus (54.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appflow	66.626s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. service/appflow Issues and PRs that pertain to the appflow service. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Can't configure a value for "flow_status" on AppFlow Flows
2 participants