-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Glue: Migrate to AWS SDK v2 #38397
Glue: Migrate to AWS SDK v2 #38397
Conversation
…n_settings: Migrate to AWS SDK v2
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
% make testacc TESTARGS='-run=TestAccGlue' PKG=glue
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/glue/... -v -count 1 -parallel 20 -run=TestAccGlue -timeout 360m
--- PASS: TestAccGlueCatalogDatabase_disappears (27.39s)
--- PASS: TestAccGlueCatalogTableDataSource_basic (27.59s)
--- PASS: TestAccGlueCatalogTable_full (33.79s)
--- PASS: TestAccGlueCatalogTable_columnParameters (34.32s)
--- PASS: TestAccGlueCatalogTable_basic (34.37s)
--- PASS: TestAccGlueCrawler_RoleARN_noPath (42.89s)
--- PASS: TestAccGlueCatalogDatabase_targetDatabaseWithRegion (47.50s)
--- PASS: TestAccGlueCatalogDatabase_createTablePermission (49.70s)
--- PASS: TestAccGlueCatalogTable_Update_replaceValues (52.85s)
--- PASS: TestAccGlueCatalogDatabase_targetDatabase (52.85s)
--- PASS: TestAccGlueCatalogTable_Update_addValues (53.01s)
--- PASS: TestAccGlueCatalogTable_openTableFormat (56.71s)
--- PASS: TestAccGlueCatalogTable_disappears (26.50s)
--- PASS: TestAccGlueCatalogDatabase_full (65.34s)
--- PASS: TestAccGlueCrawler_description (65.90s)
--- PASS: TestAccGlueCatalogDatabase_tags (67.16s)
--- PASS: TestAccGlueCatalogTable_StorageDescriptor_schemaReferenceARN (33.75s)
--- PASS: TestAccGlueCrawler_disappears (33.26s)
--- PASS: TestAccGlueCrawler_dynamoDBTarget (73.24s)
--- PASS: TestAccGlueCatalogTable_Disappears_database (25.37s)
--- PASS: TestAccGlueCatalogTable_targetTable (31.93s)
--- PASS: TestAccGlueCrawler_DynamoDBTarget_scanRate (82.13s)
--- PASS: TestAccGlueCatalogTable_partitionIndexesMultiple (38.98s)
--- PASS: TestAccGlueCrawler_DynamoDBTarget_scanAll (94.22s)
--- PASS: TestAccGlueCatalogTable_partitionIndexesSingle (35.56s)
--- PASS: TestAccGlueCrawler_classifiers (78.97s)
--- PASS: TestAccGlueCrawler_Configuration (80.91s)
--- PASS: TestAccGlueCrawler_S3Target_exclusions (44.60s)
--- PASS: TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_updateValues (48.84s)
--- PASS: TestAccGlueCrawler_catalogTarget (67.53s)
--- PASS: TestAccGlueCatalogTable_StorageDescriptor_schemaReference (53.49s)
--- PASS: TestAccGlueCrawler_CatalogTarget_dlqeventqueue (57.36s)
--- PASS: TestAccGlueCrawler_S3Target_dlqeventqueue (66.03s)
--- PASS: TestAccGlueCrawler_S3Target_connectionName (45.09s)
--- PASS: TestAccGlueCrawler_JDBCTarget_exclusions (31.79s)
--- PASS: TestAccGlueCrawler_icebergTarget (50.01s)
--- PASS: TestAccGlueCrawler_S3Target_sampleSize (60.46s)
--- PASS: TestAccGlueCrawler_S3Target_multiple (81.74s)
--- PASS: TestAccGlueCrawler_S3Target_eventqueue (67.49s)
--- PASS: TestAccGlueCrawler_CatalogTarget_multiple (100.30s)
--- PASS: TestAccGlueCrawler_s3Target (64.07s)
--- PASS: TestAccGlueCrawler_hudiTarget (51.80s)
--- PASS: TestAccGlueDataQualityRuleset_basic (23.17s)
--- PASS: TestAccGlueCrawler_deltaTarget (53.52s)
--- PASS: TestAccGlueDataQualityRuleset_disappears (18.79s)
--- PASS: TestAccGlueCrawler_mongoDBTarget (47.63s)
--- PASS: TestAccGlueDataQualityRuleset_targetTableRequired (25.94s)
--- PASS: TestAccGlueDataQualityRuleset_targetTableFull (26.37s)
--- PASS: TestAccGlueWorkflow_disappears (20.00s)
--- PASS: TestAccGlueCrawler_MongoDBTarget_multiple (68.65s)
--- PASS: TestAccGlueCrawler_MongoDBTargetScan_all (67.34s)
--- PASS: TestAccGlueWorkflow_defaultRunProperties (25.03s)
--- PASS: TestAccGlueDataQualityRuleset_updateDescription (38.82s)
--- PASS: TestAccGlueDataQualityRuleset_updateRuleset (39.44s)
--- PASS: TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_emptyBlock (23.10s)
--- PASS: TestAccGlueCatalogTable_StorageDescriptor_emptyBlock (20.21s)
--- PASS: TestAccGlueDataQualityRuleset_tags (51.28s)
--- PASS: TestAccGlueConnectionDataSource_basic (19.94s)
--- PASS: TestAccGlueCrawler_jdbcTarget (71.01s)
--- PASS: TestAccGlueWorkflow_description (38.93s)
--- PASS: TestAccGlueConnection_disappears (19.35s)
--- PASS: TestAccGlueWorkflow_tags (50.98s)
--- PASS: TestAccGlueCrawler_JDBCTarget_multiple (91.41s)
--- PASS: TestAccGlueConnection_kafka (20.52s)
--- PASS: TestAccGlueConnection_mongoDB (20.68s)
--- PASS: TestAccGlueConnection_basic (20.70s)
--- PASS: TestAccGlueWorkflow_maxConcurrentRuns (49.55s)
--- PASS: TestAccGluePartitionIndex_disappears (68.09s)
--- PASS: TestAccGlueConnection_network (29.37s)
--- PASS: TestAccGlueConnection_description (31.53s)
--- PASS: TestAccGlueCrawler_tags (40.39s)
--- PASS: TestAccGlueConnection_matchCriteria (44.65s)
--- PASS: TestAccGlueUserDefinedFunction_disappears (16.96s)
--- PASS: TestAccGlueSecurityConfiguration_basic (19.39s)
--- PASS: TestAccGlueConnection_tags (45.08s)
--- PASS: TestAccGlueTrigger_disappears (21.50s)
--- PASS: TestAccGlueCrawler_removeTablePrefix (47.73s)
--- PASS: TestAccGlueUserDefinedFunction_basic (36.66s)
--- PASS: TestAccGlueCrawler_lakeformation (52.94s)
--- PASS: TestAccGlueCrawler_security (47.66s)
--- PASS: TestAccGlueUserDefinedFunction_Resource_uri (45.54s)
--- PASS: TestAccGlueCrawler_reCrawlPolicy (64.78s)
--- PASS: TestAccGlueTrigger_crawler (73.68s)
--- PASS: TestAccGlueCrawler_lineage (58.62s)
--- PASS: TestAccGlueSecurityConfiguration_S3EncryptionS3EncryptionMode_sseS3 (11.36s)
--- PASS: TestAccGlueTrigger_eventBatchingCondition (51.40s)
--- PASS: TestAccGlueTrigger_workflowName (46.40s)
--- PASS: TestAccGlueSecurityConfiguration_S3EncryptionS3EncryptionMode_sseKMS (14.46s)
--- PASS: TestAccGlueSecurityConfiguration_JobBookmarksEncryptionJobBookmarksEncryptionMode_cseKMS (14.01s)
--- PASS: TestAccGlueTrigger_Actions_notify (62.30s)
--- PASS: TestAccGlueSecurityConfiguration_CloudWatchEncryptionCloudWatchEncryptionMode_sseKMS (14.31s)
--- PASS: TestAccGlueTrigger_basic (39.45s)
--- PASS: TestAccGlueTrigger_onDemandDisable (77.14s)
--- PASS: TestAccGlueTrigger_Actions_security (86.69s)
--- PASS: TestAccGlueTrigger_description (60.42s)
--- PASS: TestAccGlueCrawler_schedule (43.37s)
--- PASS: TestAccGlueCrawler_schemaChangePolicy (30.70s)
--- PASS: TestAccGlueCrawler_tablePrefix (35.52s)
--- PASS: TestAccGlueJob_glueVersion (35.13s)
--- PASS: TestAccGlueMlTransform_disappears (22.84s)
--- PASS: TestAccGlueTrigger_predicate (91.25s)
--- PASS: TestAccGlueTrigger_startOnCreate (112.97s)
--- PASS: TestAccGlueMlTransform_workerType (35.71s)
--- PASS: TestAccGlueMlTransform_maxCapacity (45.09s)
--- PASS: TestAccGluePartitionIndex_basic (62.42s)
--- PASS: TestAccGlueCatalogDatabase_federatedDatabase (361.49s)
--- PASS: TestAccGlueMlTransform_maxRetries (47.52s)
--- PASS: TestAccGlueJob_rayJob (12.86s)
--- PASS: TestAccGlueJob_maxCapacity (26.41s)
--- PASS: TestAccGlueTrigger_enabled (129.60s)
--- PASS: TestAccGlueTrigger_tags (149.59s)
--- PASS: TestAccGlueMlTransform_timeout (64.81s)
--- PASS: TestAccGlueTrigger_schedule (141.17s)
--- PASS: TestAccGlueMlTransform_basic (47.18s)
--- PASS: TestAccGlueMlTransform_glueVersion (72.01s)
--- PASS: TestAccGlueMlTransform_description (77.56s)
--- PASS: TestAccGlueJob_security (33.58s)
--- PASS: TestAccGlueJob_timeout (33.46s)
--- PASS: TestAccGlueMlTransform_tags (82.65s)
--- PASS: TestAccGlueMlTransform_typeFindMatchesFull (71.50s)
--- PASS: TestAccGlueJob_maintenanceWindow (25.45s)
--- PASS: TestAccGlueJob_streamingTimeout (38.16s)
--- PASS: TestAccGlueScriptDataSource_Language_scala (16.43s)
--- PASS: TestAccGlueJob_pythonShell (62.38s)
--- PASS: TestAccGlueScriptDataSource_Language_python (17.93s)
--- PASS: TestAccGlueJob_notificationProperty (41.83s)
--- PASS: TestAccGlueJob_maxRetries (41.66s)
--- PASS: TestAccGlueSchema_Disappears_registry (23.01s)
--- PASS: TestAccGlueSchema_basic (28.53s)
--- PASS: TestAccGlueSchema_disappears (22.49s)
--- PASS: TestAccGlueJob_tags (56.11s)
--- PASS: TestAccGlueJob_workerType (77.04s)
--- PASS: TestAccGlueJob_executionProperty (45.34s)
--- PASS: TestAccGlueJob_executionClass (46.53s)
--- PASS: TestAccGlueSchema_protobuf (26.96s)
--- PASS: TestAccGluePartition_disappears (22.60s)
--- PASS: TestAccGlueRegistry_disappears (21.90s)
--- PASS: TestAccGlueSchema_json (28.27s)
--- PASS: TestAccGluePartition_Disappears_table (25.07s)
--- PASS: TestAccGlueSchema_schemaDefUpdated (47.21s)
--- PASS: TestAccGlueRegistry_basic (28.54s)
--- PASS: TestAccGlueSchema_compatibility (45.91s)
--- PASS: TestAccGlueClassifier_disappears (23.37s)
--- PASS: TestAccGlueSchema_description (45.98s)
--- PASS: TestAccGlueRegistry_description (44.13s)
--- PASS: TestAccGlueSchema_tags (64.77s)
data_catalog_encryption_settings_test.go:23: Skipping aws_glue_data_catalog_encryption_settings tests due to potential KMS key corruption
data_catalog_encryption_settings_data_source_test.go:15: Skipping aws_glue_data_catalog_encryption_settings tests due to potential KMS key corruption
--- PASS: TestAccGlueClassifier_GrokClassifier_customPatterns (43.65s)
--- PASS: TestAccGlueRegistry_tags (58.23s)
--- PASS: TestAccGlueClassifier_xmlClassifier (41.67s)
--- PASS: TestAccGlueClassifier_jsonClassifier (40.82s)
--- PASS: TestAccGlueJob_disappears (23.33s)
--- PASS: TestAccGlueJob_basicStreaming (29.09s)
--- PASS: TestAccGlueJob_description (41.83s)
--- PASS: TestAccGlueJob_basic (24.46s)
--- PASS: TestAccGlueJob_nonOverridableArguments (41.57s)
--- PASS: TestAccGlueJob_command (39.47s)
--- PASS: TestAccGlueJob_defaultArguments (39.80s)
--- PASS: TestAccGlueClassifier_typeChange (59.54s)
--- PASS: TestAccGlueClassifier_CSVClassifier_quoteSymbol (26.32s)
--- PASS: TestAccGlueClassifier_grokClassifier (24.40s)
--- PASS: TestAccGluePartition_basic (18.25s)
--- PASS: TestAccGluePartition_multipleValues (17.79s)
--- PASS: TestAccGlueClassifier_CSVClassifier_custom (24.58s)
--- PASS: TestAccGlueCrawler_RoleName_path (23.79s)
--- PASS: TestAccGluePartition_parameters (38.54s)
--- PASS: TestAccGlueCrawler_RoleARN_path (25.85s)
--- PASS: TestAccGlueClassifier_csvClassifierCustomSerde (23.10s)
--- PASS: TestAccGluePartitionIndex_Disappears_database (38.68s)
--- PASS: TestAccGlueWorkflow_basic (13.15s)
--- PASS: TestAccGlueCatalogTable_StorageDescriptorSkewedInfo_emptyBlock (12.98s)
--- PASS: TestAccGlueClassifier_csvClassifier (20.00s)
--- PASS: TestAccGluePartitionIndex_Disappears_table (36.47s)
--- PASS: TestAccGlue_serial (98.86s)
--- PASS: TestAccGlue_serial/DataCatalogEncryptionSettings (0.00s)
--- SKIP: TestAccGlue_serial/DataCatalogEncryptionSettings/basic (0.00s)
--- SKIP: TestAccGlue_serial/DataCatalogEncryptionSettings/dataSource (0.00s)
--- PASS: TestAccGlue_serial/ResourcePolicy (98.86s)
--- PASS: TestAccGlue_serial/ResourcePolicy/basic (21.47s)
--- PASS: TestAccGlue_serial/ResourcePolicy/update (24.93s)
--- PASS: TestAccGlue_serial/ResourcePolicy/hybrid (29.72s)
--- PASS: TestAccGlue_serial/ResourcePolicy/disappears (10.09s)
--- PASS: TestAccGlue_serial/ResourcePolicy/equivalent (12.65s)
--- PASS: TestAccGlueDevEndpoint_arguments (571.55s)
--- PASS: TestAccGlueDevEndpoint_basic (624.31s)
--- PASS: TestAccGlueDevEndpoint_extraJarsS3Path (653.75s)
--- PASS: TestAccGlueDevEndpoint_extraPythonLibsS3Path (765.34s)
--- PASS: TestAccGlueDevEndpoint_disappears (415.77s)
--- PASS: TestAccGlueDevEndpoint_glueVersion (935.47s)
--- PASS: TestAccGlueDevEndpoint_security (512.57s)
--- PASS: TestAccGlueDevEndpoint_numberOfWorkers (475.32s)
--- PASS: TestAccGlueDevEndpoint_publicKeys (511.12s)
--- PASS: TestAccGlueDevEndpoint_tags (557.95s)
--- PASS: TestAccGlueDevEndpoint_publicKey (548.65s)
--- PASS: TestAccGlueDevEndpoint_numberOfNodes (777.47s)
--- PASS: TestAccGlueDevEndpoint_workerType (831.93s)
--- PASS: TestAccGlueConnection_physicalConnectionRequirements (1255.43s)
--- PASS: TestAccGlueDevEndpoint_SubnetID_securityGroupIDs (957.99s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/glue 1456.186s
@mattburgess thank you for the contribution! 🎉 |
This functionality has been released in v5.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Relations
Closes #36166
Relates #32976
References
Output from Acceptance Testing