-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ivs: Migrate to AWS SDK v2 #38422
ivs: Migrate to AWS SDK v2 #38422
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc PKG=ivs
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/ivs/... -v -count 1 -parallel 20 -timeout 360m
--- PASS: TestEndpointConfiguration (0.67s)
--- PASS: TestEndpointConfiguration/package_name_endpoint_config (0.04s)
--- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_base_envvar (0.05s)
--- PASS: TestEndpointConfiguration/service_aws_envvar_overrides_service_config_file (0.03s)
--- PASS: TestEndpointConfiguration/base_endpoint_envvar_overrides_service_config_file (0.03s)
--- PASS: TestEndpointConfiguration/use_fips_config_with_package_name_endpoint_config (0.04s)
--- PASS: TestEndpointConfiguration/service_aws_envvar_overrides_base_envvar (0.03s)
--- PASS: TestEndpointConfiguration/base_endpoint_envvar_overrides_base_config_file (0.03s)
--- PASS: TestEndpointConfiguration/no_config (0.03s)
--- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_service_config_file (0.05s)
--- PASS: TestEndpointConfiguration/service_aws_envvar (0.03s)
--- PASS: TestEndpointConfiguration/service_config_file (0.03s)
--- PASS: TestEndpointConfiguration/service_config_file_overrides_base_config_file (0.03s)
--- PASS: TestEndpointConfiguration/base_endpoint_config_file (0.03s)
--- PASS: TestEndpointConfiguration/use_fips_config (0.03s)
--- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_aws_service_envvar (0.04s)
--- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_base_config_file (0.05s)
--- PASS: TestEndpointConfiguration/service_aws_envvar_overrides_base_config_file (0.03s)
--- PASS: TestEndpointConfiguration/base_endpoint_envvar (0.03s)
=== RUN TestAccIVSStreamKeyDataSource_basic
=== PAUSE TestAccIVSStreamKeyDataSource_basic
=== CONT TestAccIVSChannel_basic
=== CONT TestAccIVSRecordingConfiguration_basic
=== CONT TestAccIVSRecordingConfiguration_disappears_S3Bucket
=== CONT TestAccIVSChannel_disappears
=== CONT TestAccIVSStreamKeyDataSource_basic
=== CONT TestAccIVS_serial
=== CONT TestAccIVSRecordingConfiguration_tags
=== CONT TestAccIVSRecordingConfiguration_update
=== CONT TestAccIVSChannel_recordingConfiguration
=== CONT TestAccIVSRecordingConfiguration_disappears
=== CONT TestAccIVSChannel_update
=== CONT TestAccIVSChannel_tags
=== RUN TestAccIVS_serial/PlaybackKeyPair
=== RUN TestAccIVS_serial/PlaybackKeyPair/disappears
=== RUN TestAccIVS_serial/PlaybackKeyPair/basic
--- PASS: TestAccIVSStreamKeyDataSource_basic (16.23s)
--- PASS: TestAccIVSChannel_disappears (17.03s)
--- PASS: TestAccIVSChannel_basic (20.48s)
--- PASS: TestAccIVSRecordingConfiguration_disappears_S3Bucket (27.84s)
--- PASS: TestAccIVSChannel_update (29.99s)
=== RUN TestAccIVS_serial/PlaybackKeyPair/update
--- PASS: TestAccIVSRecordingConfiguration_basic (31.28s)
--- PASS: TestAccIVSRecordingConfiguration_disappears (31.92s)
--- PASS: TestAccIVSChannel_recordingConfiguration (32.07s)
--- PASS: TestAccIVSChannel_tags (36.24s)
--- PASS: TestAccIVSRecordingConfiguration_update (46.85s)
=== RUN TestAccIVS_serial/PlaybackKeyPair/tags
--- PASS: TestAccIVSRecordingConfiguration_tags (61.45s)
--- PASS: TestAccIVS_serial (80.66s)
--- PASS: TestAccIVS_serial/PlaybackKeyPair (80.66s)
--- PASS: TestAccIVS_serial/PlaybackKeyPair/disappears (14.92s)
--- PASS: TestAccIVS_serial/PlaybackKeyPair/basic (16.01s)
--- PASS: TestAccIVS_serial/PlaybackKeyPair/update (19.42s)
--- PASS: TestAccIVS_serial/PlaybackKeyPair/tags (30.31s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ivs 87.352s
Thanks for your contribution, @mattburgess! 🥇 |
This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Relations
Closes #36174
Relates #32976
References
Output from Acceptance Testing