Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ses awssdkv2 migration #38568

Merged
merged 55 commits into from
Aug 6, 2024
Merged

Ses awssdkv2 migration #38568

merged 55 commits into from
Aug 6, 2024

Conversation

HubbardHarvey3
Copy link
Contributor

@HubbardHarvey3 HubbardHarvey3 commented Jul 27, 2024 •
edited by jar-b
Loading

Description

Migrating SES to AWS SDK Go v2

Relations

Closes #36212
Relates #32976

References

Output from Acceptance Testing

make testacc PKG=ses
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/ses/... -v -count 1 -parallel 20   -timeout 360m
=== RUN   TestAccSESActiveReceiptRuleSet_serial
=== PAUSE TestAccSESActiveReceiptRuleSet_serial
=== RUN   TestAccSESConfigurationSet_basic
=== PAUSE TestAccSESConfigurationSet_basic
=== RUN   TestAccSESConfigurationSet_sendingEnabled
=== PAUSE TestAccSESConfigurationSet_sendingEnabled
=== RUN   TestAccSESConfigurationSet_reputationMetricsEnabled
=== PAUSE TestAccSESConfigurationSet_reputationMetricsEnabled
=== RUN   TestAccSESConfigurationSet_deliveryOptions
=== PAUSE TestAccSESConfigurationSet_deliveryOptions
=== RUN   TestAccSESConfigurationSet_Update_deliveryOptions
=== PAUSE TestAccSESConfigurationSet_Update_deliveryOptions
=== RUN   TestAccSESConfigurationSet_emptyDeliveryOptions
=== PAUSE TestAccSESConfigurationSet_emptyDeliveryOptions
=== RUN   TestAccSESConfigurationSet_Update_emptyDeliveryOptions
=== PAUSE TestAccSESConfigurationSet_Update_emptyDeliveryOptions
=== RUN   TestAccSESConfigurationSet_disappears
=== PAUSE TestAccSESConfigurationSet_disappears
=== RUN   TestAccSESDomainDKIM_basic
=== PAUSE TestAccSESDomainDKIM_basic
=== RUN   TestAccSESDomainIdentityDataSource_basic
=== PAUSE TestAccSESDomainIdentityDataSource_basic
=== RUN   TestAccSESDomainIdentity_basic
=== PAUSE TestAccSESDomainIdentity_basic
=== RUN   TestAccSESDomainIdentity_disappears
=== PAUSE TestAccSESDomainIdentity_disappears
=== RUN   TestAccSESDomainIdentity_trailingPeriod
=== PAUSE TestAccSESDomainIdentity_trailingPeriod
=== RUN   TestAccSESDomainIdentityVerification_basic
=== PAUSE TestAccSESDomainIdentityVerification_basic
=== RUN   TestAccSESDomainIdentityVerification_timeout
=== PAUSE TestAccSESDomainIdentityVerification_timeout
=== RUN   TestAccSESDomainIdentityVerification_nonexistent
=== PAUSE TestAccSESDomainIdentityVerification_nonexistent
=== RUN   TestAccSESDomainMailFrom_basic
=== PAUSE TestAccSESDomainMailFrom_basic
=== RUN   TestAccSESDomainMailFrom_disappears
=== PAUSE TestAccSESDomainMailFrom_disappears
=== RUN   TestAccSESDomainMailFrom_Disappears_identity
=== PAUSE TestAccSESDomainMailFrom_Disappears_identity
=== RUN   TestAccSESDomainMailFrom_behaviorOnMxFailure
=== PAUSE TestAccSESDomainMailFrom_behaviorOnMxFailure
=== RUN   TestAccSESEmailIdentityDataSource_basic
=== PAUSE TestAccSESEmailIdentityDataSource_basic
=== RUN   TestAccSESEmailIdentityDataSource_trailingPeriod
=== PAUSE TestAccSESEmailIdentityDataSource_trailingPeriod
=== RUN   TestAccSESEmailIdentity_basic
=== PAUSE TestAccSESEmailIdentity_basic
=== RUN   TestAccSESEmailIdentity_trailingPeriod
=== PAUSE TestAccSESEmailIdentity_trailingPeriod
=== RUN   TestAccSESEventDestination_basic
=== PAUSE TestAccSESEventDestination_basic
=== RUN   TestAccSESEventDestination_disappears
=== PAUSE TestAccSESEventDestination_disappears
=== RUN   TestAccSESIdentityNotificationTopic_basic
=== PAUSE TestAccSESIdentityNotificationTopic_basic
=== RUN   TestAccSESIdentityPolicy_basic
=== PAUSE TestAccSESIdentityPolicy_basic
=== RUN   TestAccSESIdentityPolicy_Identity_email
=== PAUSE TestAccSESIdentityPolicy_Identity_email
=== RUN   TestAccSESIdentityPolicy_policy
=== PAUSE TestAccSESIdentityPolicy_policy
=== RUN   TestAccSESIdentityPolicy_ignoreEquivalent
=== PAUSE TestAccSESIdentityPolicy_ignoreEquivalent
=== RUN   TestAccSESReceiptFilter_basic
=== PAUSE TestAccSESReceiptFilter_basic
=== RUN   TestAccSESReceiptFilter_disappears
=== PAUSE TestAccSESReceiptFilter_disappears
=== RUN   TestAccSESReceiptRuleSet_basic
=== PAUSE TestAccSESReceiptRuleSet_basic
=== RUN   TestAccSESReceiptRuleSet_disappears
=== PAUSE TestAccSESReceiptRuleSet_disappears
=== RUN   TestAccSESReceiptRule_basic
=== PAUSE TestAccSESReceiptRule_basic
=== RUN   TestAccSESReceiptRule_s3Action
=== PAUSE TestAccSESReceiptRule_s3Action
=== RUN   TestAccSESReceiptRule_snsAction
=== PAUSE TestAccSESReceiptRule_snsAction
=== RUN   TestAccSESReceiptRule_snsActionEncoding
=== PAUSE TestAccSESReceiptRule_snsActionEncoding
=== RUN   TestAccSESReceiptRule_lambdaAction
=== PAUSE TestAccSESReceiptRule_lambdaAction
=== RUN   TestAccSESReceiptRule_stopAction
=== PAUSE TestAccSESReceiptRule_stopAction
=== RUN   TestAccSESReceiptRule_order
=== PAUSE TestAccSESReceiptRule_order
=== RUN   TestAccSESReceiptRule_actions
=== PAUSE TestAccSESReceiptRule_actions
=== RUN   TestAccSESReceiptRule_disappears
=== PAUSE TestAccSESReceiptRule_disappears
=== RUN   TestEndpointConfiguration
=== RUN   TestEndpointConfiguration/package_name_endpoint_config
=== RUN   TestEndpointConfiguration/package_name_endpoint_config_overrides_service_config_file
=== RUN   TestEndpointConfiguration/service_aws_envvar_overrides_base_envvar
=== RUN   TestEndpointConfiguration/base_endpoint_envvar
=== RUN   TestEndpointConfiguration/use_fips_config
=== RUN   TestEndpointConfiguration/service_aws_envvar_overrides_service_config_file
=== RUN   TestEndpointConfiguration/service_config_file
=== RUN   TestEndpointConfiguration/base_endpoint_config_file
=== RUN   TestEndpointConfiguration/base_endpoint_envvar_overrides_service_config_file
=== RUN   TestEndpointConfiguration/use_fips_config_with_package_name_endpoint_config
=== RUN   TestEndpointConfiguration/no_config
=== RUN   TestEndpointConfiguration/package_name_endpoint_config_overrides_aws_service_envvar
=== RUN   TestEndpointConfiguration/package_name_endpoint_config_overrides_base_envvar
=== RUN   TestEndpointConfiguration/package_name_endpoint_config_overrides_base_config_file
=== RUN   TestEndpointConfiguration/service_aws_envvar
=== RUN   TestEndpointConfiguration/service_aws_envvar_overrides_base_config_file
=== RUN   TestEndpointConfiguration/base_endpoint_envvar_overrides_base_config_file
=== RUN   TestEndpointConfiguration/service_config_file_overrides_base_config_file
--- PASS: TestEndpointConfiguration (4.86s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config (0.37s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_service_config_file (0.32s)
    --- PASS: TestEndpointConfiguration/service_aws_envvar_overrides_base_envvar (0.24s)
    --- PASS: TestEndpointConfiguration/base_endpoint_envvar (0.21s)
    --- PASS: TestEndpointConfiguration/use_fips_config (0.25s)
    --- PASS: TestEndpointConfiguration/service_aws_envvar_overrides_service_config_file (0.21s)
    --- PASS: TestEndpointConfiguration/service_config_file (0.20s)
    --- PASS: TestEndpointConfiguration/base_endpoint_config_file (0.22s)
    --- PASS: TestEndpointConfiguration/base_endpoint_envvar_overrides_service_config_file (0.19s)
    --- PASS: TestEndpointConfiguration/use_fips_config_with_package_name_endpoint_config (0.33s)
    --- PASS: TestEndpointConfiguration/no_config (0.17s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_aws_service_envvar (0.40s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_base_envvar (0.35s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_base_config_file (0.31s)
    --- PASS: TestEndpointConfiguration/service_aws_envvar (0.21s)
    --- PASS: TestEndpointConfiguration/service_aws_envvar_overrides_base_config_file (0.26s)
    --- PASS: TestEndpointConfiguration/base_endpoint_envvar_overrides_base_config_file (0.27s)
    --- PASS: TestEndpointConfiguration/service_config_file_overrides_base_config_file (0.20s)
=== RUN   TestAccSESTemplate_basic
=== PAUSE TestAccSESTemplate_basic
=== RUN   TestAccSESTemplate_update
=== PAUSE TestAccSESTemplate_update
=== RUN   TestAccSESTemplate_disappears
=== PAUSE TestAccSESTemplate_disappears
=== CONT  TestAccSESActiveReceiptRuleSet_serial
=== CONT  TestAccSESReceiptRule_disappears
=== RUN   TestAccSESActiveReceiptRuleSet_serial/Resource
=== RUN   TestAccSESActiveReceiptRuleSet_serial/Resource/basic
=== CONT  TestAccSESEmailIdentityDataSource_trailingPeriod
=== CONT  TestAccSESDomainMailFrom_Disappears_identity
=== CONT  TestAccSESDomainMailFrom_disappears
=== CONT  TestAccSESDomainMailFrom_basic
=== CONT  TestAccSESDomainIdentityVerification_nonexistent
=== CONT  TestAccSESDomainIdentityVerification_timeout
=== CONT  TestAccSESDomainIdentityVerification_basic
=== CONT  TestAccSESDomainIdentity_trailingPeriod
=== CONT  TestAccSESDomainIdentity_disappears
=== CONT  TestAccSESReceiptRule_actions
=== CONT  TestAccSESDomainIdentity_basic
=== CONT  TestAccSESReceiptRule_order
=== CONT  TestAccSESDomainIdentityDataSource_basic
=== CONT  TestAccSESReceiptRule_stopAction
=== CONT  TestAccSESDomainDKIM_basic
=== CONT  TestAccSESReceiptRule_lambdaAction
=== CONT  TestAccSESEmailIdentityDataSource_basic
=== CONT  TestAccSESDomainMailFrom_behaviorOnMxFailure
--- PASS: TestAccSESDomainIdentity_trailingPeriod (106.78s)
=== CONT  TestAccSESConfigurationSet_disappears
--- PASS: TestAccSESDomainIdentityVerification_nonexistent (304.80s)
=== CONT  TestAccSESConfigurationSet_Update_emptyDeliveryOptions
--- PASS: TestAccSESDomainIdentityVerification_timeout (453.96s)
=== CONT  TestAccSESConfigurationSet_emptyDeliveryOptions
--- PASS: TestAccSESDomainIdentity_basic (770.29s)
=== CONT  TestAccSESConfigurationSet_Update_deliveryOptions
--- PASS: TestAccSESEmailIdentityDataSource_trailingPeriod (770.52s)
=== CONT  TestAccSESConfigurationSet_deliveryOptions
--- PASS: TestAccSESDomainIdentity_disappears (781.72s)
=== CONT  TestAccSESConfigurationSet_reputationMetricsEnabled
--- PASS: TestAccSESDomainDKIM_basic (793.53s)
=== CONT  TestAccSESConfigurationSet_sendingEnabled
--- PASS: TestAccSESDomainIdentityDataSource_basic (801.53s)
=== CONT  TestAccSESConfigurationSet_basic
--- PASS: TestAccSESDomainMailFrom_disappears (809.59s)
=== CONT  TestAccSESIdentityPolicy_ignoreEquivalent
--- PASS: TestAccSESDomainMailFrom_Disappears_identity (809.94s)
=== CONT  TestAccSESReceiptRule_snsActionEncoding
--- PASS: TestAccSESEmailIdentityDataSource_basic (816.50s)
=== CONT  TestAccSESReceiptRule_snsAction
--- PASS: TestAccSESDomainIdentityVerification_basic (877.37s)
=== CONT  TestAccSESReceiptRule_s3Action
--- PASS: TestAccSESConfigurationSet_disappears (800.86s)
=== CONT  TestAccSESReceiptRule_basic
=== RUN   TestAccSESActiveReceiptRuleSet_serial/Resource/disappears
--- PASS: TestAccSESReceiptRule_actions (953.35s)
=== CONT  TestAccSESReceiptRuleSet_disappears
--- PASS: TestAccSESReceiptRule_lambdaAction (965.16s)
=== CONT  TestAccSESReceiptRuleSet_basic
--- PASS: TestAccSESReceiptRule_stopAction (970.50s)
=== CONT  TestAccSESReceiptFilter_disappears
--- PASS: TestAccSESReceiptRule_order (970.85s)
=== CONT  TestAccSESReceiptFilter_basic
--- PASS: TestAccSESConfigurationSet_emptyDeliveryOptions (907.11s)
=== CONT  TestAccSESEventDestination_disappears
--- PASS: TestAccSESReceiptRule_disappears (1383.40s)
=== CONT  TestAccSESIdentityPolicy_policy
--- PASS: TestAccSESDomainMailFrom_basic (1471.83s)
=== CONT  TestAccSESIdentityPolicy_Identity_email
--- PASS: TestAccSESDomainMailFrom_behaviorOnMxFailure (1477.12s)
=== CONT  TestAccSESIdentityPolicy_basic
--- PASS: TestAccSESConfigurationSet_deliveryOptions (907.44s)
=== CONT  TestAccSESIdentityNotificationTopic_basic
=== RUN   TestAccSESActiveReceiptRuleSet_serial/DataSource
=== RUN   TestAccSESActiveReceiptRuleSet_serial/DataSource/basic
--- PASS: TestAccSESConfigurationSet_basic (911.05s)
=== CONT  TestAccSESEmailIdentity_trailingPeriod
--- PASS: TestAccSESReceiptRuleSet_disappears (759.22s)
=== CONT  TestAccSESEventDestination_basic
--- PASS: TestAccSESReceiptRule_snsAction (926.15s)
=== CONT  TestAccSESEmailIdentity_basic
--- PASS: TestAccSESReceiptRule_snsActionEncoding (938.97s)
=== CONT  TestAccSESTemplate_update
--- PASS: TestAccSESReceiptFilter_disappears (782.61s)
=== CONT  TestAccSESTemplate_disappears
--- PASS: TestAccSESReceiptRule_s3Action (948.91s)
=== CONT  TestAccSESTemplate_basic
--- PASS: TestAccSESReceiptRule_basic (918.64s)
--- PASS: TestAccSESReceiptRuleSet_basic (903.74s)
--- PASS: TestAccSESIdentityPolicy_ignoreEquivalent (1086.57s)
--- PASS: TestAccSESReceiptFilter_basic (926.17s)
--- PASS: TestAccSESEventDestination_disappears (782.02s)
--- PASS: TestAccSESIdentityPolicy_Identity_email (820.01s)
--- PASS: TestAccSESIdentityPolicy_basic (823.18s)
=== RUN   TestAccSESActiveReceiptRuleSet_serial/DataSource/noActiveRuleSet
--- PASS: TestAccSESConfigurationSet_Update_emptyDeliveryOptions (2038.36s)
--- PASS: TestAccSESActiveReceiptRuleSet_serial (2385.15s)
    --- PASS: TestAccSESActiveReceiptRuleSet_serial/Resource (1691.32s)
        --- PASS: TestAccSESActiveReceiptRuleSet_serial/Resource/basic (916.29s)
        --- PASS: TestAccSESActiveReceiptRuleSet_serial/Resource/disappears (774.94s)
    --- PASS: TestAccSESActiveReceiptRuleSet_serial/DataSource (693.84s)
        --- PASS: TestAccSESActiveReceiptRuleSet_serial/DataSource/basic (615.55s)
        --- PASS: TestAccSESActiveReceiptRuleSet_serial/DataSource/noActiveRuleSet (78.29s)
--- PASS: TestAccSESTemplate_disappears (638.57s)
--- PASS: TestAccSESEmailIdentity_trailingPeriod (706.95s)
--- PASS: TestAccSESEmailIdentity_basic (679.85s)
--- PASS: TestAccSESTemplate_basic (647.83s)
--- PASS: TestAccSESConfigurationSet_reputationMetricsEnabled (1707.73s)
--- PASS: TestAccSESIdentityPolicy_policy (1120.84s)
--- PASS: TestAccSESConfigurationSet_sendingEnabled (1720.36s)
--- PASS: TestAccSESEventDestination_basic (840.52s)
--- PASS: TestAccSESConfigurationSet_Update_deliveryOptions (1844.71s)
--- PASS: TestAccSESIdentityNotificationTopic_basic (958.57s)
--- PASS: TestAccSESTemplate_update (894.31s)
PASS
...

@HubbardHarvey3
Update names_data.hcl, add endpointID, patch gen
a6b479e
@HubbardHarvey3
r/d/active_receipt_rule_set: Migrate to AWS SDK v2
f70546b
@HubbardHarvey3
Merge branch 'hashicorp:main' into ses-awssdkv2-migration
6f2ce04
@HubbardHarvey3
r/configuration_set.go: Migrate to AWS SDK v2
00dff0f
@HubbardHarvey3
r/domain_dkim.go: Migrate to AWS SDK v2
ddaf310
@HubbardHarvey3
Merge branch 'hashicorp:main' into ses-awssdkv2-migration
2c82b36
@HubbardHarvey3
r/domain_identity.go: Migrate to AWS SDK v2
af0a4de
@HubbardHarvey3
d/domain_identity: Migrate to AWS SDK v2
3ebaf0a
@HubbardHarvey3
r/domain_identity_verification: Migrate to AWS SDK v2
0a600a8
@HubbardHarvey3
Merge branch 'hashicorp:main' into ses-awssdkv2-migration
e7043c0
@HubbardHarvey3
r/domain_mail_from: Migrate to AWS SDK v2
e84ca8f
@HubbardHarvey3
r/d/email_identity: Migrate to AWS SDK v2
f60b2f7
@HubbardHarvey3
Merge branch 'hashicorp:main' into ses-awssdkv2-migration
6da657f
@HubbardHarvey3
r/event_destination: Migrate to AWS SDK v2
598a7af
@HubbardHarvey3
Merge branch 'hashicorp:main' into ses-awssdkv2-migration
77560eb
@HubbardHarvey3
r/identity_notification_topic: Migrate to AWS SDK v2
133d4af
@HubbardHarvey3
r/identity_policy: Migrate to AWS SDK v2
21af40f
@HubbardHarvey3
r/receipt_filter: Migrate to AWS SDK v2
74d1bec
@HubbardHarvey3
Merge branch 'hashicorp:main' into ses-awssdkv2-migration
d9c0dda
@HubbardHarvey3
r/receipt_rule: Migrate to AWS SDK v2
eea5468
@HubbardHarvey3
Merge branch 'hashicorp:main' into ses-awssdkv2-migration
e11be9c
@HubbardHarvey3
r/receipt_rule_set: Migrate to AWS SDK v2
205bd08
@HubbardHarvey3
sweep: Migrate to AWS SDK v2
66eccce
@HubbardHarvey3
generate.go update: Migrate to AWS SDK v2
6b039aa
@HubbardHarvey3
template: Migrate to AWS SDK v2
3e09e6e
@HubbardHarvey3
r/configuration_set: Migrate to AWS SDK v2
606aa78
@HubbardHarvey3
d/domain_identity: Migrate to AWS SDK v2
74316ad
@HubbardHarvey3
go mod tidy: Migrate to AWS SDK v2
d2874e8
@HubbardHarvey3
r/configuration_set_test: Migrate to AWS SDK v2
a6c575e
@HubbardHarvey3
r/domain_dkim_test: Migrate to AWS SDK v2
4c65b8f
@HubbardHarvey3 HubbardHarvey3 requested a review from a team as a code owner July 27, 2024 01:31
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@terraform-aws-provider terraform-aws-provider bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ses Issues and PRs that pertain to the ses service. sweeper Pertains to changes to or issues with the sweeper. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. labels Jul 27, 2024
@HubbardHarvey3

This comment was marked as resolved.

Sign in to view
@ewbankkit ewbankkit added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Jul 31, 2024
@jar-b jar-b self-assigned this Aug 6, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 6, 2024
@jar-b
Merge branch 'main' into ses-awssdkv2-migration
ede7101
@jar-b
r/aws_ses_domain_identity_verification: compare enum types
49a17ab 
```console
% make testacc PKG=ses TESTS=TestAccSESDomainIdentityVerification_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/ses/... -v -count 1 -parallel 20 -run='TestAccSESDomainIdentityVerification_'  -timeout 360m
=== RUN   TestAccSESDomainIdentityVerification_basic
    domain_identity_verification_test.go:27: Environment variable SES_DOMAIN_IDENTITY_ROOT_DOMAIN is not set. For DNS verification requests, this domain must be publicly accessible and configurable via Route53 during the testing.
--- SKIP: TestAccSESDomainIdentityVerification_basic (0.00s)
=== RUN   TestAccSESDomainIdentityVerification_timeout
=== PAUSE TestAccSESDomainIdentityVerification_timeout
=== RUN   TestAccSESDomainIdentityVerification_nonexistent
=== PAUSE TestAccSESDomainIdentityVerification_nonexistent
=== CONT  TestAccSESDomainIdentityVerification_timeout
=== CONT  TestAccSESDomainIdentityVerification_nonexistent
--- PASS: TestAccSESDomainIdentityVerification_nonexistent (4.52s)
--- PASS: TestAccSESDomainIdentityVerification_timeout (11.75s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ses        16.412s
```
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2024

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

jar-b
jar-b approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=ses
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/ses/... -v -count 1 -parallel 20   -timeout 360m

--- PASS: TestAccSESDomainIdentityVerification_nonexistent (12.86s)
=== CONT  TestAccSESDomainIdentity_trailingPeriod
--- PASS: TestAccSESDomainIdentity_trailingPeriod (2.62s)
=== CONT  TestAccSESDomainIdentity_disappears
--- PASS: TestAccSESDomainIdentityVerification_timeout (23.59s)
=== CONT  TestAccSESIdentityPolicy_basic
--- PASS: TestAccSESDomainIdentity_basic (31.98s)
=== CONT  TestAccSESIdentityPolicy_policy
--- PASS: TestAccSESEmailIdentityDataSource_trailingPeriod (32.49s)
=== CONT  TestAccSESIdentityPolicy_Identity_email
--- PASS: TestAccSESEmailIdentityDataSource_basic (32.51s)
=== CONT  TestAccSESReceiptFilter_disappears
--- PASS: TestAccSESTemplate_disappears (33.61s)
=== CONT  TestAccSESReceiptRuleSet_basic
--- PASS: TestAccSESReceiptRuleSet_disappears (33.74s)
=== CONT  TestAccSESConfigurationSet_reputationMetricsEnabled
--- PASS: TestAccSESDomainMailFrom_Disappears_identity (34.07s)
=== CONT  TestAccSESConfigurationSet_Update_deliveryOptions
--- PASS: TestAccSESIdentityPolicy_ignoreEquivalent (36.66s)
=== CONT  TestAccSESConfigurationSet_deliveryOptions
--- PASS: TestAccSESEmailIdentity_trailingPeriod (39.38s)
=== CONT  TestAccSESIdentityNotificationTopic_basic
--- PASS: TestAccSESConfigurationSet_emptyDeliveryOptions (39.71s)
=== CONT  TestAccSESReceiptFilter_basic
--- PASS: TestAccSESTemplate_basic (39.75s)
=== CONT  TestAccSESDomainMailFrom_disappears
=== CONT  TestAccSESEventDestination_disappears
--- PASS: TestAccSESEmailIdentity_basic (39.90s)
=== RUN   TestAccSESActiveReceiptRuleSet_serial/Resource/disappears
--- PASS: TestAccSESReceiptRule_basic (40.10s)
=== CONT  TestAccSESReceiptRule_stopAction
--- PASS: TestAccSESDomainIdentity_disappears (26.82s)
=== CONT  TestAccSESReceiptRule_disappears
=== CONT  TestAccSESReceiptRule_actions
--- PASS: TestAccSESReceiptRule_s3Action (45.17s)
--- PASS: TestAccSESDomainMailFrom_behaviorOnMxFailure (59.56s)
=== CONT  TestAccSESReceiptRule_order
--- PASS: TestAccSESDomainMailFrom_basic (61.31s)
=== CONT  TestAccSESDomainDKIM_basic
--- PASS: TestAccSESIdentityPolicy_basic (38.02s)
=== CONT  TestAccSESConfigurationSet_disappears
--- PASS: TestAccSESReceiptFilter_disappears (30.12s)
=== CONT  TestAccSESDomainIdentityDataSource_basic
--- PASS: TestAccSESIdentityPolicy_Identity_email (35.46s)
=== CONT  TestAccSESConfigurationSet_Update_emptyDeliveryOptions
=== RUN   TestAccSESActiveReceiptRuleSet_serial/DataSource
=== RUN   TestAccSESActiveReceiptRuleSet_serial/DataSource/basic
--- PASS: TestAccSESReceiptRuleSet_basic (38.28s)
=== CONT  TestAccSESReceiptRule_snsAction
--- PASS: TestAccSESDomainMailFrom_disappears (32.33s)
=== CONT  TestAccSESConfigurationSet_sendingEnabled
--- PASS: TestAccSESConfigurationSet_deliveryOptions (36.87s)
=== CONT  TestAccSESConfigurationSet_basic
--- PASS: TestAccSESReceiptFilter_basic (37.68s)
=== CONT  TestAccSESReceiptRule_lambdaAction
--- PASS: TestAccSESReceiptRule_stopAction (40.65s)
=== CONT  TestAccSESReceiptRule_snsActionEncoding
--- PASS: TestAccSESReceiptRule_actions (36.40s)
--- PASS: TestAccSESTemplate_update (82.29s)
--- PASS: TestAccSESDomainIdentityDataSource_basic (27.20s)
--- PASS: TestAccSESConfigurationSet_disappears (28.25s)
--- PASS: TestAccSESIdentityPolicy_policy (57.88s)
--- PASS: TestAccSESDomainDKIM_basic (28.78s)
--- PASS: TestAccSESReceiptRule_order (34.08s)
--- PASS: TestAccSESReceiptRule_disappears (52.02s)
=== RUN   TestAccSESActiveReceiptRuleSet_serial/DataSource/noActiveRuleSet
--- PASS: TestAccSESActiveReceiptRuleSet_serial (99.89s)
    --- PASS: TestAccSESActiveReceiptRuleSet_serial/Resource (71.86s)
        --- PASS: TestAccSESActiveReceiptRuleSet_serial/Resource/basic (40.03s)
        --- PASS: TestAccSESActiveReceiptRuleSet_serial/Resource/disappears (31.83s)
    --- PASS: TestAccSESActiveReceiptRuleSet_serial/DataSource (28.03s)
        --- PASS: TestAccSESActiveReceiptRuleSet_serial/DataSource/basic (25.44s)
        --- PASS: TestAccSESActiveReceiptRuleSet_serial/DataSource/noActiveRuleSet (2.59s)
--- PASS: TestAccSESConfigurationSet_basic (27.66s)
--- PASS: TestAccSESReceiptRule_snsAction (29.76s)
--- PASS: TestAccSESConfigurationSet_reputationMetricsEnabled (68.68s)
--- PASS: TestAccSESReceiptRule_snsActionEncoding (24.23s)
--- PASS: TestAccSESIdentityNotificationTopic_basic (67.53s)
--- PASS: TestAccSESReceiptRule_lambdaAction (35.83s)
--- PASS: TestAccSESConfigurationSet_Update_deliveryOptions (79.69s)
--- PASS: TestAccSESConfigurationSet_sendingEnabled (45.13s)
--- PASS: TestAccSESConfigurationSet_Update_emptyDeliveryOptions (50.01s)
--- PASS: TestAccSESEventDestination_basic (124.22s)
--- PASS: TestAccSESEventDestination_disappears (103.00s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ses        149.762s

@jar-b
Copy link
Member

jar-b commented Aug 6, 2024

Thanks for your contribution, @HubbardHarvey3! 👍

@jar-b jar-b merged commit 9fb9325 into hashicorp:main Aug 6, 2024
41 checks passed
@github-actions github-actions bot added this to the v5.62.0 milestone Aug 6, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

This functionality has been released in v5.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

This was referenced Aug 19, 2024
Closed
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees

@jar-b jar-b

Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. service/ses Issues and PRs that pertain to the ses service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.62.0
Development

Successfully merging this pull request may close these issues.

[AWS SDK for Go Migration] SES (Simple Email) Service
3 participants
@HubbardHarvey3 @jar-b @ewbankkit