-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup leftover v1
references in merged aws-sdk-go-v2
migrations
#38911
Cleanup leftover v1
references in merged aws-sdk-go-v2
migrations
#38911
Conversation
Community NoteVoting for Prioritization
For Submitters
|
aws-sdk-go-v2
migrationsv1
references in merged aws-sdk-go-v2
migrations
…th references to names package
… endpoint id to names reference
…AccCognitoIDPUserGroupDataSource_basic` ServiceID to names reference
…ndpoints from names package and upgrade arn package to v2
…pgrade arn to v2
…nts to the names package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
@DanielRieske Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.63.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
We are currently very close to closing #32976, many maintainers and contributors have been submitting PRs for the past few months.
This PR is one of the first of cleaning up any forgotten references that have
v1
references to migrated services.Because this PR touches a lot of services at once, all tests for every service that was touched regardless of the size of the change have been ran and logging included in the PR.
Relations
Closes #0000
References
Output from Acceptance Testing
Skip is warranted and is what had to be tested given the change in the PR
Test failure unrelated to PR
Test failure unrelated to PR