Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Network Manager resources to AWS SDK v2 #38915

Merged
merged 42 commits into from
Aug 20, 2024
Merged

Migrate Network Manager resources to AWS SDK v2 #38915

merged 42 commits into from
Aug 20, 2024

Conversation

DanielRieske
Copy link
Contributor

@DanielRieske DanielRieske commented Aug 18, 2024 •
edited
Loading

Description

This PR migrates the remaining Network Manager resources to AWS SDKv2.

Relations

Closes #36191
Relates #32976

References

Output from Acceptance Testing

Test failures are pre-migration errors.

% make testacc TESTARGS='-run=TestAcc' PKG=networkmanager
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/networkmanager/... -v -count 1 -parallel 3  -run=TestAcc -timeout 720m
--- PASS: TestAccNetworkManagerGlobalNetwork_disappears (18.23s)
--- PASS: TestAccNetworkManagerDeviceDataSource_basic (19.42s)
--- PASS: TestAccNetworkManagerGlobalNetwork_basic (17.78s)
--- PASS: TestAccNetworkManagerGlobalNetworkDataSource_basic (16.01s)
--- PASS: TestAccNetworkManagerDevicesDataSource_basic (20.00s)
--- PASS: TestAccNetworkManagerDevice_awsLocation (41.68s)
--- PASS: TestAccNetworkManagerDevice_allAttributes (37.83s)
--- PASS: TestAccNetworkManagerDevice_tags (41.91s)
--- PASS: TestAccNetworkManagerDevice_disappears (20.01s)
--- PASS: TestAccNetworkManagerDevice_basic (21.15s)
--- PASS: TestAccNetworkManagerCoreNetwork_basic (322.85s)
--- PASS: TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_whenSentTo (7.53s)
--- PASS: TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_serviceInsertion (7.55s)
=== CONT  TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
    core_network_policy_document_data_source_test.go:16: Step 1/1 error: Check failed: Check 1/1 error: data.aws_networkmanager_core_network_policy_document.test: Attribute "json" value: data.aws_networkmanager_core_network_policy_document.test: Attribute "json" expected
        {
         ... (removed for readability)
        }
--- FAIL: TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic (4.00s)
--- PASS: TestAccNetworkManagerConnection_serial (173.03s)
    --- PASS: TestAccNetworkManagerConnection_serial/descriptionAndLinks (49.26s)
    --- PASS: TestAccNetworkManagerConnection_serial/basic (32.07s)
    --- PASS: TestAccNetworkManagerConnection_serial/disappears (30.89s)
    --- PASS: TestAccNetworkManagerConnection_serial/tags (60.80s)
--- PASS: TestAccNetworkManagerCoreNetworkPolicyAttachment_expectPolicyErrorInvalidASNRange (314.60s)
--- PASS: TestAccNetworkManagerConnectAttachment_basic (1138.80s)
--- PASS: TestAccNetworkManagerCoreNetworkPolicyAttachment_vpcAttachment (1232.08s)
--- PASS: TestAccNetworkManagerConnectionsDataSource_basic (35.61s)
--- PASS: TestAccNetworkManagerCoreNetworkPolicyAttachment_basic (742.42s)
--- PASS: TestAccNetworkManagerConnectionDataSource_basic (31.98s)
--- PASS: TestAccNetworkManagerCoreNetworkPolicyAttachment_vpcAttachmentMultiRegion (2253.99s)
--- PASS: TestAccNetworkManagerConnectPeer_basic (1579.04s)
--- PASS: TestAccNetworkManagerConnectPeer_tags (1708.01s)
--- PASS: TestAccNetworkManagerConnectPeer_subnetARN (1808.67s)
--- PASS: TestAccNetworkManagerConnectAttachment_protocolNoEncap (1129.01s)
--- PASS: TestAccNetworkManagerConnectPeer_noDependsOn (1449.82s)
--- PASS: TestAccNetworkManagerConnectAttachment_tags (1187.86s)
--- PASS: TestAccNetworkManagerSiteToSiteVPNAttachment_disappears (1184.59s)
--- PASS: TestAccNetworkManagerConnectAttachment_disappears (1364.04s)
--- PASS: TestAccNetworkManagerVPCAttachment_tags (862.29s)
--- PASS: TestAccNetworkManagerVPCAttachment_Attached_disappearsAccepter (945.32s)
--- PASS: TestAccNetworkManagerTransitGatewayRouteTableAttachment_tags (1621.06s)
--- PASS: TestAccNetworkManagerTransitGatewayRouteTableAttachment_disappears (1690.65s)
=== NAME  TestAccNetworkManagerTransitGatewayPeering_tags
    acctest.go:1735: skipping test for aws/us-west-2: Error running apply: exit status 1
        
        Error: creating Network Manager Transit Gateway (arn:aws:ec2:us-west-2:170689858638:transit-gateway/tgw-01430d10f9dc79957) Peering (core-network-0af546a36e550ae9a): operation error NetworkManager: CreateTransitGatewayPeering, https response error StatusCode: 400, RequestID: 4040fbca-393b-4ff0-b0ba-df0bce2926d7, ValidationException: Core Network edge location (us-west-2) not available.
        
          with aws_networkmanager_transit_gateway_peering.test,
          on terraform_plugin_test.tf line 62, in resource "aws_networkmanager_transit_gateway_peering" "test":
          62: resource "aws_networkmanager_transit_gateway_peering" "test" {
        
--- PASS: TestAccNetworkManagerTransitGatewayRegistration_serial (671.62s)
    --- PASS: TestAccNetworkManagerTransitGatewayRegistration_serial/disappears (188.78s)
    --- PASS: TestAccNetworkManagerTransitGatewayRegistration_serial/disappears_TransitGateway (177.65s)
    --- PASS: TestAccNetworkManagerTransitGatewayRegistration_serial/crossRegion (154.27s)
    --- PASS: TestAccNetworkManagerTransitGatewayRegistration_serial/basic (150.91s)
=== CONT  TestAccNetworkManagerTransitGatewayPeering_disappears
    acctest.go:1735: skipping test for aws/us-west-2: Error running apply: exit status 1
        
        Error: creating Network Manager Transit Gateway (arn:aws:ec2:us-west-2:170689858638:transit-gateway/tgw-06830ca86c9a70b69) Peering (core-network-048338013d4907762): operation error NetworkManager: CreateTransitGatewayPeering, https response error StatusCode: 400, RequestID: a0d036b6-7c50-41bb-bbcc-c4f93d9f7f1e, ValidationException: Core Network edge location (us-west-2) not available.
        
          with aws_networkmanager_transit_gateway_peering.test,
          on terraform_plugin_test.tf line 62, in resource "aws_networkmanager_transit_gateway_peering" "test":
          62: resource "aws_networkmanager_transit_gateway_peering" "test" {
        
--- SKIP: TestAccNetworkManagerTransitGatewayPeering_tags (599.21s)
--- PASS: TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic (1796.15s)
--- SKIP: TestAccNetworkManagerTransitGatewayPeering_disappears (484.72s)
--- PASS: TestAccNetworkManagerSitesDataSource_basic (20.27s)
=== NAME  TestAccNetworkManagerTransitGatewayPeering_basic
    acctest.go:1735: skipping test for aws/us-west-2: Error running apply: exit status 1
        
        Error: creating Network Manager Transit Gateway (arn:aws:ec2:us-west-2:170689858638:transit-gateway/tgw-0c9e8b8bd37adaf5f) Peering (core-network-0458a4a83657dd667): operation error NetworkManager: CreateTransitGatewayPeering, https response error StatusCode: 400, RequestID: cd3b4453-69e1-472e-9e54-a23f368c5da4, ValidationException: Core Network edge location (us-west-2) not available.
        
          with aws_networkmanager_transit_gateway_peering.test,
          on terraform_plugin_test.tf line 62, in resource "aws_networkmanager_transit_gateway_peering" "test":
          62: resource "aws_networkmanager_transit_gateway_peering" "test" {
        
--- SKIP: TestAccNetworkManagerTransitGatewayPeering_basic (547.86s)
--- PASS: TestAccNetworkManagerCoreNetwork_createBasePolicyDocumentWithRegion (529.78s)
--- PASS: TestAccNetworkManagerSiteToSiteVPNAttachment_tags (1286.04s)
--- PASS: TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial (1777.66s)
    --- PASS: TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial/basic (576.78s)
    --- PASS: TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial/disappears (570.65s)
    --- PASS: TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial/disappears_ConnectPeer (630.23s)
--- PASS: TestAccNetworkManagerCustomerGatewayAssociation_serial (933.80s)
    --- PASS: TestAccNetworkManagerCustomerGatewayAssociation_serial/basic (452.61s)
    --- PASS: TestAccNetworkManagerCustomerGatewayAssociation_serial/disappears (481.18s)
--- PASS: TestAccNetworkManagerCoreNetwork_withoutPolicyDocumentUpdateToCreateBasePolicyDocument (559.52s)
--- PASS: TestAccNetworkManagerLink_allAttributes (38.41s)
--- PASS: TestAccNetworkManagerSiteToSiteVPNAttachment_basic (1057.47s)
--- PASS: TestAccNetworkManagerSite_location (32.61s)
--- PASS: TestAccNetworkManagerSite_description (32.67s)
--- PASS: TestAccNetworkManagerSite_tags (42.59s)
--- PASS: TestAccNetworkManagerSite_disappears (19.53s)
--- PASS: TestAccNetworkManagerSite_basic (21.88s)
--- PASS: TestAccNetworkManagerSiteDataSource_basic (19.67s)
--- PASS: TestAccNetworkManagerLinksDataSource_basic (23.02s)
--- PASS: TestAccNetworkManagerCoreNetwork_createBasePolicyDocumentWithPolicyDocument (1727.28s)
--- PASS: TestAccNetworkManagerCoreNetwork_createBasePolicyDocumentWithMultiRegion (1548.95s)
--- PASS: TestAccNetworkManagerCoreNetwork_description (332.84s)
--- PASS: TestAccNetworkManagerCoreNetwork_tags (343.04s)
--- PASS: TestAccNetworkManagerLinkAssociation_disappears (26.81s)
--- PASS: TestAccNetworkManagerCoreNetwork_createBasePolicyDocumentWithoutRegion (516.93s)
--- PASS: TestAccNetworkManagerLink_disappears (21.90s)
--- PASS: TestAccNetworkManagerLink_tags (47.93s)
--- PASS: TestAccNetworkManagerLink_basic (24.53s)
--- PASS: TestAccNetworkManagerGlobalNetworksDataSource_basic (16.46s)
--- PASS: TestAccNetworkManagerLinkDataSource_basic (22.64s)
--- PASS: TestAccNetworkManagerLinkAssociation_basic (28.51s)
--- PASS: TestAccNetworkManagerGlobalNetwork_description (28.42s)
=== NAME  TestAccNetworkManagerConnectAttachment_basic_NoDependsOn
    connect_attachment_test.go:66: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: deleting Network Manager VPC Attachment (attachment-0a4309f756313b88b): operation error NetworkManager: DeleteAttachment, https response error StatusCode: 400, RequestID: 885fd333-cd49-4d63-af72-d7fc974f747c, ValidationException: VPC attachment (attachment-0a4309f756313b88b) cannot be deleted due to existing Connect attachment (attachment-04318fd91f7e0e1ad).
        
--- FAIL: TestAccNetworkManagerConnectAttachment_basic_NoDependsOn (805.62s)
--- PASS: TestAccNetworkManagerGlobalNetwork_tags (37.72s)
--- PASS: TestAccNetworkManagerCoreNetwork_disappears (319.39s)
--- PASS: TestAccNetworkManagerVPCAttachment_Attached_update (0.00s)
    --- PASS: TestAccNetworkManagerVPCAttachment_Attached_update/acceptance_required (1535.82s)
    --- PASS: TestAccNetworkManagerVPCAttachment_Attached_update/acceptance_not_required (1412.61s)
--- PASS: TestAccNetworkManagerVPCAttachment_update (0.00s)
    --- PASS: TestAccNetworkManagerVPCAttachment_update/acceptance_required (589.99s)
    --- PASS: TestAccNetworkManagerVPCAttachment_update/acceptance_not_required (1405.93s)
--- PASS: TestAccNetworkManagerVPCAttachment_Attached_disappears (0.00s)
    --- PASS: TestAccNetworkManagerVPCAttachment_Attached_disappears/acceptance_required (860.55s)
    --- PASS: TestAccNetworkManagerVPCAttachment_Attached_disappears/acceptance_not_required (851.82s)
--- PASS: TestAccNetworkManagerVPCAttachment_disappears (0.00s)
    --- PASS: TestAccNetworkManagerVPCAttachment_disappears/acceptance_required (626.94s)
    --- PASS: TestAccNetworkManagerVPCAttachment_disappears/acceptance_not_required (862.96s)
--- PASS: TestAccNetworkManagerVPCAttachment_Attached_basic (0.00s)
    --- PASS: TestAccNetworkManagerVPCAttachment_Attached_basic/acceptance_required (943.68s)
    --- PASS: TestAccNetworkManagerVPCAttachment_Attached_basic/acceptance_not_required (945.58s)
--- PASS: TestAccNetworkManagerVPCAttachment_basic (0.00s)
    --- PASS: TestAccNetworkManagerVPCAttachment_basic/acceptance_required (569.86s)
    --- PASS: TestAccNetworkManagerVPCAttachment_basic/acceptance_not_required (1007.73s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	17384.923s
FAIL

Sweepers

% SWEEP=us-west-2 SWEEPERS=aws_networkmanager_global_network,aws_networkmanager_core_network,aws_networkmanager_connect_attachment,aws_networkmanager_site_to_site_vpn_attachment,aws_networkmanager_transit_gateway_peering,aws_networkmanager_transit_gateway_route_table_attachment,aws_networkmanager_vpc_attachment,aws_networkmanager_site,aws_networkmanager_device,aws_networkmanager_link,aws_networkmanager_link_association,aws_networkmanager_connection make sweep
# make sweep SWEEPARGS=-sweep-run=aws_example_thing
# set SWEEPARGS=-sweep-allow-failures to continue after first failure
WARNING: This will destroy infrastructure. Use only in development accounts.
go1.22.6 test ./internal/sweep -v -sweep=us-west-2 -sweep-run='aws_networkmanager_global_network,aws_networkmanager_core_network,aws_networkmanager_connect_attachment,aws_networkmanager_site_to_site_vpn_attachment,aws_networkmanager_transit_gateway_peering,aws_networkmanager_transit_gateway_route_table_attachment,aws_networkmanager_vpc_attachment,aws_networkmanager_site,aws_networkmanager_device,aws_networkmanager_link,aws_networkmanager_link_association,aws_networkmanager_connection' -timeout 360m
2024/08/19 19:06:48 [DEBUG] Running Sweepers for region (us-west-2):
2024/08/19 19:06:48 [DEBUG] Sweeper (aws_networkmanager_core_network) has dependency (aws_networkmanager_connect_attachment), running..
2024/08/19 19:06:48 [DEBUG] Running Sweeper (aws_networkmanager_connect_attachment) in region (us-west-2)
2024/08/19 19:06:48 [DEBUG] sweeper: Configuring Terraform AWS Provider: sweeper_region=us-west-2
2024-08-19T19:06:48.247+0200 [DEBUG] sweeper.aws-base: Resolving credentials provider: sweeper_region=us-west-2
2024-08-19T19:06:48.247+0200 [DEBUG] sweeper.aws-base: Using profile: sweeper_region=us-west-2 tf_aws.profile=default tf_aws.profile.source=envvar
2024-08-19T19:06:48.247+0200 [DEBUG] sweeper.aws-base: Loading configuration: sweeper_region=us-west-2
2024-08-19T19:06:48.269+0200 [DEBUG] sweeper.aws-base: Retrieving credentials: sweeper_region=us-west-2
2024-08-19T19:06:48.269+0200 [DEBUG] sweeper.aws-base: Loading configuration: sweeper_region=us-west-2
2024/08/19 19:06:48 [DEBUG] sweeper: Creating AWS SDK v1 session: sweeper_region=us-west-2
2024/08/19 19:06:48 [DEBUG] sweeper: Retrieving AWS account details: sweeper_region=us-west-2
2024-08-19T19:06:48.271+0200 [DEBUG] sweeper.aws-base: Retrieving caller identity from STS: sweeper_region=us-west-2
2024-08-19T19:06:48.929+0200 [INFO]  sweeper.aws-base: Retrieved caller identity from STS: sweeper_region=us-west-2
2024/08/19 19:06:49 [INFO]  sweeper: No resources to sweep: sweeper_region=us-west-2
2024/08/19 19:06:49 [DEBUG] Completed Sweeper (aws_networkmanager_connect_attachment) in region (us-west-2) in 1.327321875s
2024/08/19 19:06:49 [DEBUG] Sweeper (aws_networkmanager_core_network) has dependency (aws_networkmanager_site_to_site_vpn_attachment), running..
2024/08/19 19:06:49 [DEBUG] Running Sweeper (aws_networkmanager_site_to_site_vpn_attachment) in region (us-west-2)
2024/08/19 19:06:50 [INFO]  sweeper: No resources to sweep: sweeper_region=us-west-2
2024/08/19 19:06:50 [DEBUG] Completed Sweeper (aws_networkmanager_site_to_site_vpn_attachment) in region (us-west-2) in 546.659083ms
2024/08/19 19:06:50 [DEBUG] Sweeper (aws_networkmanager_core_network) has dependency (aws_networkmanager_transit_gateway_peering), running..
2024/08/19 19:06:50 [DEBUG] Sweeper (aws_networkmanager_transit_gateway_peering) has dependency (aws_networkmanager_transit_gateway_route_table_attachment), running..
2024/08/19 19:06:50 [DEBUG] Running Sweeper (aws_networkmanager_transit_gateway_route_table_attachment) in region (us-west-2)
2024/08/19 19:06:50 [INFO]  sweeper: No resources to sweep: sweeper_region=us-west-2
2024/08/19 19:06:50 [DEBUG] Completed Sweeper (aws_networkmanager_transit_gateway_route_table_attachment) in region (us-west-2) in 553.330417ms
2024/08/19 19:06:50 [DEBUG] Running Sweeper (aws_networkmanager_transit_gateway_peering) in region (us-west-2)
2024/08/19 19:06:51 [INFO]  sweeper: No resources to sweep: sweeper_region=us-west-2
2024/08/19 19:06:51 [DEBUG] Completed Sweeper (aws_networkmanager_transit_gateway_peering) in region (us-west-2) in 581.758541ms
2024/08/19 19:06:51 [DEBUG] Sweeper (aws_networkmanager_core_network) has dependency (aws_networkmanager_vpc_attachment), running..
2024/08/19 19:06:51 [DEBUG] Running Sweeper (aws_networkmanager_vpc_attachment) in region (us-west-2)
2024/08/19 19:06:51 [INFO]  sweeper: No resources to sweep: sweeper_region=us-west-2
2024/08/19 19:06:51 [DEBUG] Completed Sweeper (aws_networkmanager_vpc_attachment) in region (us-west-2) in 544.981625ms
2024/08/19 19:06:51 [DEBUG] Running Sweeper (aws_networkmanager_core_network) in region (us-west-2)
2024/08/19 19:06:52 [INFO]  sweeper: No resources to sweep: sweeper_region=us-west-2
2024/08/19 19:06:52 [DEBUG] Completed Sweeper (aws_networkmanager_core_network) in region (us-west-2) in 515.162875ms
2024/08/19 19:06:52 [DEBUG] Sweeper (aws_networkmanager_link) has dependency (aws_networkmanager_link_association), running..
2024/08/19 19:06:52 [DEBUG] Sweeper (aws_networkmanager_link_association) has dependency (aws_networkmanager_connection), running..
2024/08/19 19:06:52 [DEBUG] Running Sweeper (aws_networkmanager_connection) in region (us-west-2)
2024/08/19 19:06:52 [INFO]  sweeper: No resources to sweep: sweeper_region=us-west-2
2024/08/19 19:06:52 [DEBUG] Completed Sweeper (aws_networkmanager_connection) in region (us-west-2) in 635.635917ms
2024/08/19 19:06:52 [DEBUG] Running Sweeper (aws_networkmanager_link_association) in region (us-west-2)
2024/08/19 19:06:53 [INFO]  sweeper: No resources to sweep: sweeper_region=us-west-2
2024/08/19 19:06:53 [DEBUG] Completed Sweeper (aws_networkmanager_link_association) in region (us-west-2) in 615.984542ms
2024/08/19 19:06:53 [DEBUG] Running Sweeper (aws_networkmanager_link) in region (us-west-2)
2024/08/19 19:06:54 [INFO]  sweeper: No resources to sweep: sweeper_region=us-west-2
2024/08/19 19:06:54 [DEBUG] Completed Sweeper (aws_networkmanager_link) in region (us-west-2) in 613.514625ms
2024/08/19 19:06:54 [DEBUG] Sweeper (aws_networkmanager_connection) already ran in region (us-west-2)
2024/08/19 19:06:54 [DEBUG] Sweeper (aws_networkmanager_transit_gateway_route_table_attachment) already ran in region (us-west-2)
2024/08/19 19:06:54 [DEBUG] Sweeper (aws_networkmanager_transit_gateway_peering) has dependency (aws_networkmanager_transit_gateway_route_table_attachment), running..
2024/08/19 19:06:54 [DEBUG] Sweeper (aws_networkmanager_transit_gateway_route_table_attachment) already ran in region (us-west-2)
2024/08/19 19:06:54 [DEBUG] Sweeper (aws_networkmanager_transit_gateway_peering) already ran in region (us-west-2)
2024/08/19 19:06:54 [DEBUG] Sweeper (aws_networkmanager_connect_attachment) already ran in region (us-west-2)
2024/08/19 19:06:54 [DEBUG] Sweeper (aws_networkmanager_global_network) has dependency (aws_networkmanager_core_network), running..
2024/08/19 19:06:54 [DEBUG] Sweeper (aws_networkmanager_core_network) has dependency (aws_networkmanager_connect_attachment), running..
2024/08/19 19:06:54 [DEBUG] Sweeper (aws_networkmanager_connect_attachment) already ran in region (us-west-2)
2024/08/19 19:06:54 [DEBUG] Sweeper (aws_networkmanager_core_network) has dependency (aws_networkmanager_site_to_site_vpn_attachment), running..
2024/08/19 19:06:54 [DEBUG] Sweeper (aws_networkmanager_site_to_site_vpn_attachment) already ran in region (us-west-2)
2024/08/19 19:06:54 [DEBUG] Sweeper (aws_networkmanager_core_network) has dependency (aws_networkmanager_transit_gateway_peering), running..
2024/08/19 19:06:54 [DEBUG] Sweeper (aws_networkmanager_transit_gateway_peering) has dependency (aws_networkmanager_transit_gateway_route_table_attachment), running..
2024/08/19 19:06:54 [DEBUG] Sweeper (aws_networkmanager_transit_gateway_route_table_attachment) already ran in region (us-west-2)
2024/08/19 19:06:54 [DEBUG] Sweeper (aws_networkmanager_transit_gateway_peering) already ran in region (us-west-2)
2024/08/19 19:06:54 [DEBUG] Sweeper (aws_networkmanager_core_network) has dependency (aws_networkmanager_vpc_attachment), running..
2024/08/19 19:06:54 [DEBUG] Sweeper (aws_networkmanager_vpc_attachment) already ran in region (us-west-2)
2024/08/19 19:06:54 [DEBUG] Sweeper (aws_networkmanager_core_network) already ran in region (us-west-2)
2024/08/19 19:06:54 [DEBUG] Sweeper (aws_networkmanager_global_network) has dependency (aws_networkmanager_site), running..
2024/08/19 19:06:54 [DEBUG] Sweeper (aws_networkmanager_site) has dependency (aws_networkmanager_device), running..
2024/08/19 19:06:54 [DEBUG] Sweeper (aws_networkmanager_device) has dependency (aws_networkmanager_link_association), running..
2024/08/19 19:06:54 [DEBUG] Sweeper (aws_networkmanager_link_association) has dependency (aws_networkmanager_connection), running..
2024/08/19 19:06:54 [DEBUG] Sweeper (aws_networkmanager_connection) already ran in region (us-west-2)
2024/08/19 19:06:54 [DEBUG] Sweeper (aws_networkmanager_link_association) already ran in region (us-west-2)
2024/08/19 19:06:54 [DEBUG] Running Sweeper (aws_networkmanager_device) in region (us-west-2)
2024/08/19 19:06:54 [INFO]  sweeper: No resources to sweep: sweeper_region=us-west-2
2024/08/19 19:06:54 [DEBUG] Completed Sweeper (aws_networkmanager_device) in region (us-west-2) in 613.711833ms
2024/08/19 19:06:54 [DEBUG] Sweeper (aws_networkmanager_site) has dependency (aws_networkmanager_link), running..
2024/08/19 19:06:54 [DEBUG] Sweeper (aws_networkmanager_link) has dependency (aws_networkmanager_link_association), running..
2024/08/19 19:06:54 [DEBUG] Sweeper (aws_networkmanager_link_association) has dependency (aws_networkmanager_connection), running..
2024/08/19 19:06:54 [DEBUG] Sweeper (aws_networkmanager_connection) already ran in region (us-west-2)
2024/08/19 19:06:54 [DEBUG] Sweeper (aws_networkmanager_link_association) already ran in region (us-west-2)
2024/08/19 19:06:54 [DEBUG] Sweeper (aws_networkmanager_link) already ran in region (us-west-2)
2024/08/19 19:06:54 [DEBUG] Running Sweeper (aws_networkmanager_site) in region (us-west-2)
2024/08/19 19:06:55 [INFO]  sweeper: No resources to sweep: sweeper_region=us-west-2
2024/08/19 19:06:55 [DEBUG] Completed Sweeper (aws_networkmanager_site) in region (us-west-2) in 718.167792ms
2024/08/19 19:06:55 [DEBUG] Running Sweeper (aws_networkmanager_global_network) in region (us-west-2)
2024/08/19 19:06:55 [INFO]  sweeper: No resources to sweep: sweeper_region=us-west-2
2024/08/19 19:06:55 [DEBUG] Completed Sweeper (aws_networkmanager_global_network) in region (us-west-2) in 249.580666ms
2024/08/19 19:06:55 [DEBUG] Sweeper (aws_networkmanager_site) has dependency (aws_networkmanager_device), running..
2024/08/19 19:06:55 [DEBUG] Sweeper (aws_networkmanager_device) has dependency (aws_networkmanager_link_association), running..
2024/08/19 19:06:55 [DEBUG] Sweeper (aws_networkmanager_link_association) has dependency (aws_networkmanager_connection), running..
2024/08/19 19:06:55 [DEBUG] Sweeper (aws_networkmanager_connection) already ran in region (us-west-2)
2024/08/19 19:06:55 [DEBUG] Sweeper (aws_networkmanager_link_association) already ran in region (us-west-2)
2024/08/19 19:06:55 [DEBUG] Sweeper (aws_networkmanager_device) already ran in region (us-west-2)
2024/08/19 19:06:55 [DEBUG] Sweeper (aws_networkmanager_site) has dependency (aws_networkmanager_link), running..
2024/08/19 19:06:55 [DEBUG] Sweeper (aws_networkmanager_link) has dependency (aws_networkmanager_link_association), running..
2024/08/19 19:06:55 [DEBUG] Sweeper (aws_networkmanager_link_association) has dependency (aws_networkmanager_connection), running..
2024/08/19 19:06:55 [DEBUG] Sweeper (aws_networkmanager_connection) already ran in region (us-west-2)
2024/08/19 19:06:55 [DEBUG] Sweeper (aws_networkmanager_link_association) already ran in region (us-west-2)
2024/08/19 19:06:55 [DEBUG] Sweeper (aws_networkmanager_link) already ran in region (us-west-2)
2024/08/19 19:06:55 [DEBUG] Sweeper (aws_networkmanager_site) already ran in region (us-west-2)
2024/08/19 19:06:55 [DEBUG] Sweeper (aws_networkmanager_device) has dependency (aws_networkmanager_link_association), running..
2024/08/19 19:06:55 [DEBUG] Sweeper (aws_networkmanager_link_association) has dependency (aws_networkmanager_connection), running..
2024/08/19 19:06:55 [DEBUG] Sweeper (aws_networkmanager_connection) already ran in region (us-west-2)
2024/08/19 19:06:55 [DEBUG] Sweeper (aws_networkmanager_link_association) already ran in region (us-west-2)
2024/08/19 19:06:55 [DEBUG] Sweeper (aws_networkmanager_device) already ran in region (us-west-2)
2024/08/19 19:06:55 [DEBUG] Sweeper (aws_networkmanager_link_association) has dependency (aws_networkmanager_connection), running..
2024/08/19 19:06:55 [DEBUG] Sweeper (aws_networkmanager_connection) already ran in region (us-west-2)
2024/08/19 19:06:55 [DEBUG] Sweeper (aws_networkmanager_link_association) already ran in region (us-west-2)
2024/08/19 19:06:55 [DEBUG] Sweeper (aws_networkmanager_vpc_attachment) already ran in region (us-west-2)
2024/08/19 19:06:55 [DEBUG] Sweeper (aws_networkmanager_site_to_site_vpn_attachment) already ran in region (us-west-2)
2024/08/19 19:06:55 Completed Sweepers for region (us-west-2) in 7.518701084s
2024/08/19 19:06:55 Sweeper Tests for region (us-west-2) ran successfully:
2024/08/19 19:06:55     - aws_networkmanager_connect_attachment
2024/08/19 19:06:55     - aws_networkmanager_transit_gateway_route_table_attachment
2024/08/19 19:06:55     - aws_networkmanager_transit_gateway_peering
2024/08/19 19:06:55     - aws_networkmanager_vpc_attachment
2024/08/19 19:06:55     - aws_networkmanager_core_network
2024/08/19 19:06:55     - aws_networkmanager_device
2024/08/19 19:06:55     - aws_networkmanager_site
2024/08/19 19:06:55     - aws_networkmanager_global_network
2024/08/19 19:06:55     - aws_networkmanager_site_to_site_vpn_attachment
2024/08/19 19:06:55     - aws_networkmanager_connection
2024/08/19 19:06:55     - aws_networkmanager_link_association
2024/08/19 19:06:55     - aws_networkmanager_link
ok      github.com/hashicorp/terraform-provider-aws/internal/sweep      12.123s

@DanielRieske
feat: generate v2 client
9eb409b
@DanielRieske
feat: migrate r/attachment_accepter to sdkv2
b456d7c
@DanielRieske
feat: migrate r/connect_attachment to sdkv2
35ad479
@DanielRieske
feat: migrate r/connect_peer to sdkv2
2d1998f
@DanielRieske
feat: migrate r/connection to sdkv2
3390fe3
@DanielRieske
feat: migrate d/connection to sdkv2
ef8222e
@DanielRieske
feat: migrate d/connections to sdkv2
1de1526
@DanielRieske
feat: migrate r/core_network_policy_attachment to sdkv2
c481575
@DanielRieske
feat: migrate d/core_network_policy_document to sdkv2
1fcc1d1
@DanielRieske
feat: migrate r/core_network to sdkv2
2fd2e59
@DanielRieske
feat: migrate r/customer_gateway_association to sdkv2
7bea7c5
@DanielRieske
feat: migrate r/device to sdkv2
5fea1a8
@DanielRieske
feat: migrate d/device to sdkv2
55ce508
@DanielRieske
feat: migrate d/devices to sdkv2
06502ae
@DanielRieske
feat: migrate r/global_network to sdkv2
6fa95cf
@DanielRieske
feat: migrate d/global_network to sdkv2
67a7b9b
@DanielRieske
feat: migrate d/global_networks to sdkv2
730f983
@DanielRieske
feat: migrate r/link_association to sdkv2
3589778
@DanielRieske
feat: migrate r/link to sdkv2
102e0ca
@DanielRieske
feat: migrate d/link to sdkv2
8e79c77
@DanielRieske
feat: migrate d/links to sdkv2
c6843c2
@DanielRieske
feat: migrate r/core_network_policy_attachment to sdkv2
b5e1fe4
@DanielRieske
feat: migrate d/site to sdkv2
5e39da6
@DanielRieske
feat: migrate r/site to sdkv2
058fa3d
@DanielRieske
feat: migrate r/site_to_site_vpn_attachment to sdkv2
3a16139
@DanielRieske
feat: migrate d/sites to sdkv2
8a70d9f
@DanielRieske
feat: migrate r/transit_gateway_connect_peer_association to sdkv2
8f54208
@DanielRieske
feat: migrate r/transit_gateway_peering to sdkv2
d25cbba
@DanielRieske
feat: migrate r/transit_gateway_registration to sdkv2
21f31f2
@DanielRieske
feat: migrate r/transit_gateway_route_table_attachment to sdkv2
4c3eb1f
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/networkmanager Issues and PRs that pertain to the networkmanager service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Aug 18, 2024
@ewbankkit ewbankkit added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Aug 18, 2024
@DanielRieske DanielRieske marked this pull request as ready for review August 19, 2024 12:32
@DanielRieske DanielRieske requested a review from a team as a code owner August 19, 2024 12:32
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Aug 19, 2024
@ewbankkit
Merge branch 'main' into HEAD
5b4ebab 
# Conflicts:
#	internal/conns/awsclient_gen.go
@ewbankkit ewbankkit self-assigned this Aug 19, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 19, 2024
ewbankkit
ewbankkit approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccNetworkManager' PKG=networkmanager ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/networkmanager/... -v -count 1 -parallel 4  -run=TestAccNetworkManager -timeout 720m
=== RUN   TestAccNetworkManagerConnectAttachment_basic
=== PAUSE TestAccNetworkManagerConnectAttachment_basic
=== RUN   TestAccNetworkManagerConnectAttachment_basic_NoDependsOn
=== PAUSE TestAccNetworkManagerConnectAttachment_basic_NoDependsOn
=== RUN   TestAccNetworkManagerConnectAttachment_disappears
=== PAUSE TestAccNetworkManagerConnectAttachment_disappears
=== RUN   TestAccNetworkManagerConnectAttachment_protocolNoEncap
=== PAUSE TestAccNetworkManagerConnectAttachment_protocolNoEncap
=== RUN   TestAccNetworkManagerConnectAttachment_tags
=== PAUSE TestAccNetworkManagerConnectAttachment_tags
=== RUN   TestAccNetworkManagerConnectPeer_basic
=== PAUSE TestAccNetworkManagerConnectPeer_basic
=== RUN   TestAccNetworkManagerConnectPeer_noDependsOn
=== PAUSE TestAccNetworkManagerConnectPeer_noDependsOn
=== RUN   TestAccNetworkManagerConnectPeer_subnetARN
=== PAUSE TestAccNetworkManagerConnectPeer_subnetARN
=== RUN   TestAccNetworkManagerConnectPeer_tags
=== PAUSE TestAccNetworkManagerConnectPeer_tags
=== RUN   TestAccNetworkManagerConnectionDataSource_basic
=== PAUSE TestAccNetworkManagerConnectionDataSource_basic
=== RUN   TestAccNetworkManagerConnection_serial
=== PAUSE TestAccNetworkManagerConnection_serial
=== RUN   TestAccNetworkManagerConnectionsDataSource_basic
=== PAUSE TestAccNetworkManagerConnectionsDataSource_basic
=== RUN   TestAccNetworkManagerCoreNetworkPolicyAttachment_basic
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyAttachment_basic
=== RUN   TestAccNetworkManagerCoreNetworkPolicyAttachment_vpcAttachment
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyAttachment_vpcAttachment
=== RUN   TestAccNetworkManagerCoreNetworkPolicyAttachment_vpcAttachmentMultiRegion
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyAttachment_vpcAttachmentMultiRegion
=== RUN   TestAccNetworkManagerCoreNetworkPolicyAttachment_expectPolicyErrorInvalidASNRange
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyAttachment_expectPolicyErrorInvalidASNRange
=== RUN   TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== RUN   TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_serviceInsertion
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_serviceInsertion
=== RUN   TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_whenSentTo
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_whenSentTo
=== RUN   TestAccNetworkManagerCoreNetwork_basic
=== PAUSE TestAccNetworkManagerCoreNetwork_basic
=== RUN   TestAccNetworkManagerCoreNetwork_disappears
=== PAUSE TestAccNetworkManagerCoreNetwork_disappears
=== RUN   TestAccNetworkManagerCoreNetwork_tags
=== PAUSE TestAccNetworkManagerCoreNetwork_tags
=== RUN   TestAccNetworkManagerCoreNetwork_description
=== PAUSE TestAccNetworkManagerCoreNetwork_description
=== RUN   TestAccNetworkManagerCoreNetwork_createBasePolicyDocumentWithoutRegion
=== PAUSE TestAccNetworkManagerCoreNetwork_createBasePolicyDocumentWithoutRegion
=== RUN   TestAccNetworkManagerCoreNetwork_createBasePolicyDocumentWithRegion
=== PAUSE TestAccNetworkManagerCoreNetwork_createBasePolicyDocumentWithRegion
=== RUN   TestAccNetworkManagerCoreNetwork_createBasePolicyDocumentWithMultiRegion
=== PAUSE TestAccNetworkManagerCoreNetwork_createBasePolicyDocumentWithMultiRegion
=== RUN   TestAccNetworkManagerCoreNetwork_createBasePolicyDocumentWithPolicyDocument
=== PAUSE TestAccNetworkManagerCoreNetwork_createBasePolicyDocumentWithPolicyDocument
=== RUN   TestAccNetworkManagerCoreNetwork_withoutPolicyDocumentUpdateToCreateBasePolicyDocument
=== PAUSE TestAccNetworkManagerCoreNetwork_withoutPolicyDocumentUpdateToCreateBasePolicyDocument
=== RUN   TestAccNetworkManagerCustomerGatewayAssociation_serial
=== PAUSE TestAccNetworkManagerCustomerGatewayAssociation_serial
=== RUN   TestAccNetworkManagerDeviceDataSource_basic
=== PAUSE TestAccNetworkManagerDeviceDataSource_basic
=== RUN   TestAccNetworkManagerDevice_basic
=== PAUSE TestAccNetworkManagerDevice_basic
=== RUN   TestAccNetworkManagerDevice_disappears
=== PAUSE TestAccNetworkManagerDevice_disappears
=== RUN   TestAccNetworkManagerDevice_tags
=== PAUSE TestAccNetworkManagerDevice_tags
=== RUN   TestAccNetworkManagerDevice_allAttributes
=== PAUSE TestAccNetworkManagerDevice_allAttributes
=== RUN   TestAccNetworkManagerDevice_awsLocation
=== PAUSE TestAccNetworkManagerDevice_awsLocation
=== RUN   TestAccNetworkManagerDevicesDataSource_basic
=== PAUSE TestAccNetworkManagerDevicesDataSource_basic
=== RUN   TestAccNetworkManagerGlobalNetworkDataSource_basic
=== PAUSE TestAccNetworkManagerGlobalNetworkDataSource_basic
=== RUN   TestAccNetworkManagerGlobalNetwork_basic
=== PAUSE TestAccNetworkManagerGlobalNetwork_basic
=== RUN   TestAccNetworkManagerGlobalNetwork_disappears
=== PAUSE TestAccNetworkManagerGlobalNetwork_disappears
=== RUN   TestAccNetworkManagerGlobalNetwork_tags
=== PAUSE TestAccNetworkManagerGlobalNetwork_tags
=== RUN   TestAccNetworkManagerGlobalNetwork_description
=== PAUSE TestAccNetworkManagerGlobalNetwork_description
=== RUN   TestAccNetworkManagerGlobalNetworksDataSource_basic
=== PAUSE TestAccNetworkManagerGlobalNetworksDataSource_basic
=== RUN   TestAccNetworkManagerLinkAssociation_basic
=== PAUSE TestAccNetworkManagerLinkAssociation_basic
=== RUN   TestAccNetworkManagerLinkAssociation_disappears
=== PAUSE TestAccNetworkManagerLinkAssociation_disappears
=== RUN   TestAccNetworkManagerLinkDataSource_basic
=== PAUSE TestAccNetworkManagerLinkDataSource_basic
=== RUN   TestAccNetworkManagerLink_basic
=== PAUSE TestAccNetworkManagerLink_basic
=== RUN   TestAccNetworkManagerLink_disappears
=== PAUSE TestAccNetworkManagerLink_disappears
=== RUN   TestAccNetworkManagerLink_tags
=== PAUSE TestAccNetworkManagerLink_tags
=== RUN   TestAccNetworkManagerLink_allAttributes
=== PAUSE TestAccNetworkManagerLink_allAttributes
=== RUN   TestAccNetworkManagerLinksDataSource_basic
=== PAUSE TestAccNetworkManagerLinksDataSource_basic
=== RUN   TestAccNetworkManagerSiteDataSource_basic
=== PAUSE TestAccNetworkManagerSiteDataSource_basic
=== RUN   TestAccNetworkManagerSite_basic
=== PAUSE TestAccNetworkManagerSite_basic
=== RUN   TestAccNetworkManagerSite_disappears
=== PAUSE TestAccNetworkManagerSite_disappears
=== RUN   TestAccNetworkManagerSite_tags
=== PAUSE TestAccNetworkManagerSite_tags
=== RUN   TestAccNetworkManagerSite_description
=== PAUSE TestAccNetworkManagerSite_description
=== RUN   TestAccNetworkManagerSite_location
=== PAUSE TestAccNetworkManagerSite_location
=== RUN   TestAccNetworkManagerSiteToSiteVPNAttachment_basic
=== PAUSE TestAccNetworkManagerSiteToSiteVPNAttachment_basic
=== RUN   TestAccNetworkManagerSiteToSiteVPNAttachment_disappears
=== PAUSE TestAccNetworkManagerSiteToSiteVPNAttachment_disappears
=== RUN   TestAccNetworkManagerSiteToSiteVPNAttachment_tags
=== PAUSE TestAccNetworkManagerSiteToSiteVPNAttachment_tags
=== RUN   TestAccNetworkManagerSitesDataSource_basic
=== PAUSE TestAccNetworkManagerSitesDataSource_basic
=== RUN   TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial
=== PAUSE TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial
=== RUN   TestAccNetworkManagerTransitGatewayPeering_basic
=== PAUSE TestAccNetworkManagerTransitGatewayPeering_basic
=== RUN   TestAccNetworkManagerTransitGatewayPeering_disappears
=== PAUSE TestAccNetworkManagerTransitGatewayPeering_disappears
=== RUN   TestAccNetworkManagerTransitGatewayPeering_tags
=== PAUSE TestAccNetworkManagerTransitGatewayPeering_tags
=== RUN   TestAccNetworkManagerTransitGatewayRegistration_serial
=== PAUSE TestAccNetworkManagerTransitGatewayRegistration_serial
=== RUN   TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic
=== PAUSE TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic
=== RUN   TestAccNetworkManagerTransitGatewayRouteTableAttachment_disappears
=== PAUSE TestAccNetworkManagerTransitGatewayRouteTableAttachment_disappears
=== RUN   TestAccNetworkManagerTransitGatewayRouteTableAttachment_tags
=== PAUSE TestAccNetworkManagerTransitGatewayRouteTableAttachment_tags
=== RUN   TestAccNetworkManagerVPCAttachment_basic
=== PAUSE TestAccNetworkManagerVPCAttachment_basic
=== RUN   TestAccNetworkManagerVPCAttachment_Attached_basic
=== PAUSE TestAccNetworkManagerVPCAttachment_Attached_basic
=== RUN   TestAccNetworkManagerVPCAttachment_disappears
=== PAUSE TestAccNetworkManagerVPCAttachment_disappears
=== RUN   TestAccNetworkManagerVPCAttachment_Attached_disappears
=== PAUSE TestAccNetworkManagerVPCAttachment_Attached_disappears
=== RUN   TestAccNetworkManagerVPCAttachment_Attached_disappearsAccepter
=== PAUSE TestAccNetworkManagerVPCAttachment_Attached_disappearsAccepter
=== RUN   TestAccNetworkManagerVPCAttachment_tags
=== PAUSE TestAccNetworkManagerVPCAttachment_tags
=== RUN   TestAccNetworkManagerVPCAttachment_update
=== PAUSE TestAccNetworkManagerVPCAttachment_update
=== RUN   TestAccNetworkManagerVPCAttachment_Attached_update
=== PAUSE TestAccNetworkManagerVPCAttachment_Attached_update
=== CONT  TestAccNetworkManagerConnectAttachment_basic
=== CONT  TestAccNetworkManagerLink_tags
=== CONT  TestAccNetworkManagerVPCAttachment_Attached_update
=== CONT  TestAccNetworkManagerTransitGatewayPeering_disappears
=== RUN   TestAccNetworkManagerVPCAttachment_Attached_update/acceptance_not_required
=== PAUSE TestAccNetworkManagerVPCAttachment_Attached_update/acceptance_not_required
=== RUN   TestAccNetworkManagerVPCAttachment_Attached_update/acceptance_required
=== PAUSE TestAccNetworkManagerVPCAttachment_Attached_update/acceptance_required
=== CONT  TestAccNetworkManagerVPCAttachment_Attached_basic
=== RUN   TestAccNetworkManagerVPCAttachment_Attached_basic/acceptance_required
=== PAUSE TestAccNetworkManagerVPCAttachment_Attached_basic/acceptance_required
=== RUN   TestAccNetworkManagerVPCAttachment_Attached_basic/acceptance_not_required
=== PAUSE TestAccNetworkManagerVPCAttachment_Attached_basic/acceptance_not_required
=== CONT  TestAccNetworkManagerVPCAttachment_update
=== RUN   TestAccNetworkManagerVPCAttachment_update/acceptance_required
=== PAUSE TestAccNetworkManagerVPCAttachment_update/acceptance_required
=== RUN   TestAccNetworkManagerVPCAttachment_update/acceptance_not_required
=== PAUSE TestAccNetworkManagerVPCAttachment_update/acceptance_not_required
=== CONT  TestAccNetworkManagerVPCAttachment_tags
--- PASS: TestAccNetworkManagerLink_tags (34.89s)
=== CONT  TestAccNetworkManagerVPCAttachment_Attached_disappearsAccepter
=== NAME  TestAccNetworkManagerTransitGatewayPeering_disappears
    acctest.go:1735: skipping test for aws/us-west-2: Error running apply: exit status 1
        
        Error: creating Network Manager Transit Gateway (arn:aws:ec2:us-west-2:067819342479:transit-gateway/tgw-0c99d16de518bf428) Peering (core-network-0ce46cc1a29fddf4f): operation error NetworkManager: CreateTransitGatewayPeering, https response error StatusCode: 400, RequestID: 54e4f8f4-f025-4b0c-af05-7bf9207c0e8d, ValidationException: Core Network edge location (us-west-2) not available.
        
          with aws_networkmanager_transit_gateway_peering.test,
          on terraform_plugin_test.tf line 62, in resource "aws_networkmanager_transit_gateway_peering" "test":
          62: resource "aws_networkmanager_transit_gateway_peering" "test" {
        
--- SKIP: TestAccNetworkManagerTransitGatewayPeering_disappears (586.65s)
=== CONT  TestAccNetworkManagerVPCAttachment_Attached_disappears
=== RUN   TestAccNetworkManagerVPCAttachment_Attached_disappears/acceptance_required
=== PAUSE TestAccNetworkManagerVPCAttachment_Attached_disappears/acceptance_required
=== RUN   TestAccNetworkManagerVPCAttachment_Attached_disappears/acceptance_not_required
=== PAUSE TestAccNetworkManagerVPCAttachment_Attached_disappears/acceptance_not_required
=== CONT  TestAccNetworkManagerVPCAttachment_disappears
=== RUN   TestAccNetworkManagerVPCAttachment_disappears/acceptance_required
=== PAUSE TestAccNetworkManagerVPCAttachment_disappears/acceptance_required
=== RUN   TestAccNetworkManagerVPCAttachment_disappears/acceptance_not_required
=== PAUSE TestAccNetworkManagerVPCAttachment_disappears/acceptance_not_required
=== CONT  TestAccNetworkManagerCoreNetwork_createBasePolicyDocumentWithRegion
--- PASS: TestAccNetworkManagerVPCAttachment_tags (1008.37s)
=== CONT  TestAccNetworkManagerLink_disappears
--- PASS: TestAccNetworkManagerLink_disappears (15.15s)
=== CONT  TestAccNetworkManagerLink_basic
--- PASS: TestAccNetworkManagerLink_basic (16.73s)
=== CONT  TestAccNetworkManagerLinkDataSource_basic
--- PASS: TestAccNetworkManagerVPCAttachment_Attached_disappearsAccepter (1019.26s)
=== CONT  TestAccNetworkManagerLinkAssociation_disappears
--- PASS: TestAccNetworkManagerLinkDataSource_basic (14.86s)
=== CONT  TestAccNetworkManagerLinkAssociation_basic
--- PASS: TestAccNetworkManagerCoreNetwork_createBasePolicyDocumentWithRegion (483.08s)
=== CONT  TestAccNetworkManagerGlobalNetworksDataSource_basic
--- PASS: TestAccNetworkManagerLinkAssociation_disappears (17.58s)
=== CONT  TestAccNetworkManagerGlobalNetwork_description
--- PASS: TestAccNetworkManagerLinkAssociation_basic (18.69s)
=== CONT  TestAccNetworkManagerGlobalNetwork_tags
--- PASS: TestAccNetworkManagerGlobalNetworksDataSource_basic (10.91s)
=== CONT  TestAccNetworkManagerGlobalNetwork_disappears
--- PASS: TestAccNetworkManagerGlobalNetwork_description (19.48s)
=== CONT  TestAccNetworkManagerGlobalNetwork_basic
--- PASS: TestAccNetworkManagerGlobalNetwork_disappears (12.23s)
=== CONT  TestAccNetworkManagerGlobalNetworkDataSource_basic
--- PASS: TestAccNetworkManagerGlobalNetwork_tags (32.01s)
=== CONT  TestAccNetworkManagerDevicesDataSource_basic
--- PASS: TestAccNetworkManagerGlobalNetworkDataSource_basic (17.90s)
=== CONT  TestAccNetworkManagerDevice_awsLocation
--- PASS: TestAccNetworkManagerGlobalNetwork_basic (21.14s)
=== CONT  TestAccNetworkManagerDevice_allAttributes
--- PASS: TestAccNetworkManagerDevicesDataSource_basic (20.02s)
=== CONT  TestAccNetworkManagerDevice_tags
--- PASS: TestAccNetworkManagerDevice_allAttributes (35.50s)
=== CONT  TestAccNetworkManagerDevice_disappears
--- PASS: TestAccNetworkManagerDevice_awsLocation (38.11s)
=== CONT  TestAccNetworkManagerDevice_basic
--- PASS: TestAccNetworkManagerDevice_disappears (17.29s)
=== CONT  TestAccNetworkManagerDeviceDataSource_basic
--- PASS: TestAccNetworkManagerDevice_tags (39.73s)
=== CONT  TestAccNetworkManagerCustomerGatewayAssociation_serial
=== RUN   TestAccNetworkManagerCustomerGatewayAssociation_serial/basic
--- PASS: TestAccNetworkManagerDevice_basic (19.21s)
=== CONT  TestAccNetworkManagerCoreNetwork_withoutPolicyDocumentUpdateToCreateBasePolicyDocument
--- PASS: TestAccNetworkManagerDeviceDataSource_basic (15.57s)
=== CONT  TestAccNetworkManagerCoreNetwork_createBasePolicyDocumentWithPolicyDocument
--- PASS: TestAccNetworkManagerConnectAttachment_basic (1253.15s)
=== CONT  TestAccNetworkManagerCoreNetwork_createBasePolicyDocumentWithMultiRegion
=== RUN   TestAccNetworkManagerCustomerGatewayAssociation_serial/disappears
--- PASS: TestAccNetworkManagerCoreNetwork_withoutPolicyDocumentUpdateToCreateBasePolicyDocument (584.06s)
=== CONT  TestAccNetworkManagerSite_location
--- PASS: TestAccNetworkManagerSite_location (25.96s)
=== CONT  TestAccNetworkManagerTransitGatewayPeering_basic
    acctest.go:1735: skipping test for aws/us-west-2: Error running apply: exit status 1
        
        Error: creating Network Manager Transit Gateway (arn:aws:ec2:us-west-2:067819342479:transit-gateway/tgw-06d7c7e7313599bd6) Peering (core-network-0a674ed91844f4f00): operation error NetworkManager: CreateTransitGatewayPeering, https response error StatusCode: 400, RequestID: 5c5fd676-6912-4445-a8c4-3c8f6d1b5166, ValidationException: Core Network edge location (us-west-2) not available.
        
          with aws_networkmanager_transit_gateway_peering.test,
          on terraform_plugin_test.tf line 62, in resource "aws_networkmanager_transit_gateway_peering" "test":
          62: resource "aws_networkmanager_transit_gateway_peering" "test" {
        
--- PASS: TestAccNetworkManagerCustomerGatewayAssociation_serial (938.74s)
    --- PASS: TestAccNetworkManagerCustomerGatewayAssociation_serial/basic (503.17s)
    --- PASS: TestAccNetworkManagerCustomerGatewayAssociation_serial/disappears (435.57s)
=== CONT  TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial
=== RUN   TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial/basic
--- SKIP: TestAccNetworkManagerTransitGatewayPeering_basic (536.32s)
=== CONT  TestAccNetworkManagerSitesDataSource_basic
--- PASS: TestAccNetworkManagerSitesDataSource_basic (13.11s)
=== CONT  TestAccNetworkManagerSiteToSiteVPNAttachment_tags
--- PASS: TestAccNetworkManagerCoreNetwork_createBasePolicyDocumentWithPolicyDocument (1597.56s)
=== CONT  TestAccNetworkManagerSiteToSiteVPNAttachment_disappears
--- PASS: TestAccNetworkManagerCoreNetwork_createBasePolicyDocumentWithMultiRegion (1617.83s)
=== CONT  TestAccNetworkManagerSiteToSiteVPNAttachment_basic
=== RUN   TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial/disappears
--- PASS: TestAccNetworkManagerSiteToSiteVPNAttachment_tags (1153.46s)
=== CONT  TestAccNetworkManagerSite_basic
--- PASS: TestAccNetworkManagerSite_basic (18.18s)
=== CONT  TestAccNetworkManagerSite_description
--- PASS: TestAccNetworkManagerSite_description (23.37s)
=== CONT  TestAccNetworkManagerSite_tags
--- PASS: TestAccNetworkManagerSite_tags (30.52s)
=== CONT  TestAccNetworkManagerSite_disappears
=== RUN   TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial/disappears_ConnectPeer
--- PASS: TestAccNetworkManagerSite_disappears (13.70s)
=== CONT  TestAccNetworkManagerCoreNetworkPolicyAttachment_basic
--- PASS: TestAccNetworkManagerSiteToSiteVPNAttachment_basic (1041.36s)
=== CONT  TestAccNetworkManagerCoreNetwork_createBasePolicyDocumentWithoutRegion
--- PASS: TestAccNetworkManagerSiteToSiteVPNAttachment_disappears (1163.42s)
=== CONT  TestAccNetworkManagerCoreNetwork_description
--- PASS: TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial (2138.38s)
    --- PASS: TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial/basic (769.92s)
    --- PASS: TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial/disappears (686.94s)
    --- PASS: TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial/disappears_ConnectPeer (681.52s)
=== CONT  TestAccNetworkManagerCoreNetwork_tags
--- PASS: TestAccNetworkManagerCoreNetwork_description (322.75s)
=== CONT  TestAccNetworkManagerCoreNetwork_disappears
--- PASS: TestAccNetworkManagerCoreNetworkPolicyAttachment_basic (730.23s)
=== CONT  TestAccNetworkManagerCoreNetwork_basic
--- PASS: TestAccNetworkManagerCoreNetwork_createBasePolicyDocumentWithoutRegion (525.87s)
=== CONT  TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_whenSentTo
--- PASS: TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_whenSentTo (5.83s)
=== CONT  TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_serviceInsertion
--- PASS: TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_serviceInsertion (5.70s)
=== CONT  TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
--- PASS: TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic (6.70s)
=== CONT  TestAccNetworkManagerCoreNetworkPolicyAttachment_expectPolicyErrorInvalidASNRange
--- PASS: TestAccNetworkManagerCoreNetwork_tags (329.80s)
=== CONT  TestAccNetworkManagerCoreNetworkPolicyAttachment_vpcAttachmentMultiRegion
--- PASS: TestAccNetworkManagerCoreNetwork_disappears (313.08s)
=== CONT  TestAccNetworkManagerCoreNetworkPolicyAttachment_vpcAttachment
--- PASS: TestAccNetworkManagerCoreNetwork_basic (314.99s)
=== CONT  TestAccNetworkManagerConnectAttachment_protocolNoEncap
--- PASS: TestAccNetworkManagerCoreNetworkPolicyAttachment_expectPolicyErrorInvalidASNRange (309.38s)
=== CONT  TestAccNetworkManagerConnectPeer_basic
--- PASS: TestAccNetworkManagerConnectAttachment_protocolNoEncap (1159.57s)
=== CONT  TestAccNetworkManagerConnectAttachment_tags
--- PASS: TestAccNetworkManagerCoreNetworkPolicyAttachment_vpcAttachment (1223.06s)
=== CONT  TestAccNetworkManagerTransitGatewayRouteTableAttachment_disappears
--- PASS: TestAccNetworkManagerConnectPeer_basic (1521.50s)
=== CONT  TestAccNetworkManagerVPCAttachment_basic
=== RUN   TestAccNetworkManagerVPCAttachment_basic/acceptance_required
=== PAUSE TestAccNetworkManagerVPCAttachment_basic/acceptance_required
=== RUN   TestAccNetworkManagerVPCAttachment_basic/acceptance_not_required
=== PAUSE TestAccNetworkManagerVPCAttachment_basic/acceptance_not_required
=== CONT  TestAccNetworkManagerTransitGatewayRouteTableAttachment_tags
--- PASS: TestAccNetworkManagerCoreNetworkPolicyAttachment_vpcAttachmentMultiRegion (1870.98s)
=== CONT  TestAccNetworkManagerLinksDataSource_basic
--- PASS: TestAccNetworkManagerLinksDataSource_basic (15.87s)
=== CONT  TestAccNetworkManagerSiteDataSource_basic
--- PASS: TestAccNetworkManagerSiteDataSource_basic (14.28s)
=== CONT  TestAccNetworkManagerConnectPeer_noDependsOn
--- PASS: TestAccNetworkManagerConnectAttachment_tags (1002.29s)
=== CONT  TestAccNetworkManagerConnectAttachment_disappears
--- PASS: TestAccNetworkManagerTransitGatewayRouteTableAttachment_disappears (1246.52s)
=== CONT  TestAccNetworkManagerConnectionsDataSource_basic
--- PASS: TestAccNetworkManagerConnectionsDataSource_basic (22.55s)
=== CONT  TestAccNetworkManagerTransitGatewayRegistration_serial
=== RUN   TestAccNetworkManagerTransitGatewayRegistration_serial/basic
=== RUN   TestAccNetworkManagerTransitGatewayRegistration_serial/disappears
--- PASS: TestAccNetworkManagerTransitGatewayRouteTableAttachment_tags (918.48s)
=== CONT  TestAccNetworkManagerConnection_serial
=== RUN   TestAccNetworkManagerConnection_serial/basic
=== RUN   TestAccNetworkManagerConnection_serial/disappears
=== RUN   TestAccNetworkManagerConnection_serial/tags
=== RUN   TestAccNetworkManagerConnection_serial/descriptionAndLinks
=== RUN   TestAccNetworkManagerTransitGatewayRegistration_serial/disappears_TransitGateway
--- PASS: TestAccNetworkManagerConnection_serial (117.30s)
    --- PASS: TestAccNetworkManagerConnection_serial/basic (22.17s)
    --- PASS: TestAccNetworkManagerConnection_serial/disappears (20.25s)
    --- PASS: TestAccNetworkManagerConnection_serial/tags (40.27s)
    --- PASS: TestAccNetworkManagerConnection_serial/descriptionAndLinks (34.61s)
=== CONT  TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic
=== RUN   TestAccNetworkManagerTransitGatewayRegistration_serial/crossRegion
--- PASS: TestAccNetworkManagerConnectPeer_noDependsOn (1149.63s)
=== CONT  TestAccNetworkManagerConnectionDataSource_basic
--- PASS: TestAccNetworkManagerConnectionDataSource_basic (25.18s)
=== CONT  TestAccNetworkManagerConnectPeer_tags
--- PASS: TestAccNetworkManagerTransitGatewayRegistration_serial (617.03s)
    --- PASS: TestAccNetworkManagerTransitGatewayRegistration_serial/basic (92.82s)
    --- PASS: TestAccNetworkManagerTransitGatewayRegistration_serial/disappears (153.08s)
    --- PASS: TestAccNetworkManagerTransitGatewayRegistration_serial/disappears_TransitGateway (170.30s)
    --- PASS: TestAccNetworkManagerTransitGatewayRegistration_serial/crossRegion (200.82s)
=== CONT  TestAccNetworkManagerConnectPeer_subnetARN
--- PASS: TestAccNetworkManagerConnectAttachment_disappears (1005.23s)
=== CONT  TestAccNetworkManagerConnectAttachment_basic_NoDependsOn
    connect_attachment_test.go:66: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: deleting Network Manager VPC Attachment (attachment-02858220f12787517): operation error NetworkManager: DeleteAttachment, https response error StatusCode: 400, RequestID: a07a71d6-a029-498a-9c0d-7294f2c98ea4, ValidationException: VPC attachment (attachment-02858220f12787517) cannot be deleted due to existing Connect attachment (attachment-06ec52846fe55e835).
        
--- FAIL: TestAccNetworkManagerConnectAttachment_basic_NoDependsOn (315.00s)
=== CONT  TestAccNetworkManagerLink_allAttributes
--- PASS: TestAccNetworkManagerLink_allAttributes (29.65s)
=== CONT  TestAccNetworkManagerTransitGatewayPeering_tags
    acctest.go:1735: skipping test for aws/us-west-2: Error running apply: exit status 1
        
        Error: creating Network Manager Transit Gateway (arn:aws:ec2:us-west-2:123456789012:transit-gateway/tgw-06b1d57aaf5ee1362) Peering (core-network-0743a550fc7d82d25): operation error NetworkManager: CreateTransitGatewayPeering, https response error StatusCode: 400, RequestID: 7e98f390-3605-43de-aa6a-b53330661f4c, ValidationException: Core Network edge location (us-west-2) not available.
        
          with aws_networkmanager_transit_gateway_peering.test,
          on terraform_plugin_test.tf line 62, in resource "aws_networkmanager_transit_gateway_peering" "test":
          62: resource "aws_networkmanager_transit_gateway_peering" "test" {
        
--- PASS: TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic (1019.17s)
=== CONT  TestAccNetworkManagerVPCAttachment_Attached_update/acceptance_not_required
--- PASS: TestAccNetworkManagerConnectPeer_subnetARN (864.67s)
=== CONT  TestAccNetworkManagerVPCAttachment_Attached_update/acceptance_required
--- SKIP: TestAccNetworkManagerTransitGatewayPeering_tags (434.14s)
=== CONT  TestAccNetworkManagerVPCAttachment_Attached_basic/acceptance_required
--- PASS: TestAccNetworkManagerConnectPeer_tags (1004.39s)
=== CONT  TestAccNetworkManagerVPCAttachment_Attached_basic/acceptance_not_required
=== CONT  TestAccNetworkManagerVPCAttachment_update/acceptance_required
--- PASS: TestAccNetworkManagerVPCAttachment_Attached_basic (0.00s)
    --- PASS: TestAccNetworkManagerVPCAttachment_Attached_basic/acceptance_required (846.31s)
    --- PASS: TestAccNetworkManagerVPCAttachment_Attached_basic/acceptance_not_required (968.06s)
=== CONT  TestAccNetworkManagerVPCAttachment_update/acceptance_not_required
=== CONT  TestAccNetworkManagerVPCAttachment_Attached_disappears/acceptance_required
=== CONT  TestAccNetworkManagerVPCAttachment_Attached_disappears/acceptance_not_required
--- PASS: TestAccNetworkManagerVPCAttachment_Attached_update (0.00s)
    --- PASS: TestAccNetworkManagerVPCAttachment_Attached_update/acceptance_not_required (1323.65s)
    --- PASS: TestAccNetworkManagerVPCAttachment_Attached_update/acceptance_required (1386.73s)
=== CONT  TestAccNetworkManagerVPCAttachment_disappears/acceptance_required
=== CONT  TestAccNetworkManagerVPCAttachment_disappears/acceptance_not_required
=== CONT  TestAccNetworkManagerVPCAttachment_basic/acceptance_required
--- PASS: TestAccNetworkManagerVPCAttachment_Attached_disappears (0.00s)
    --- PASS: TestAccNetworkManagerVPCAttachment_Attached_disappears/acceptance_required (640.11s)
    --- PASS: TestAccNetworkManagerVPCAttachment_Attached_disappears/acceptance_not_required (731.16s)
=== CONT  TestAccNetworkManagerVPCAttachment_basic/acceptance_not_required
--- PASS: TestAccNetworkManagerVPCAttachment_update (0.00s)
    --- PASS: TestAccNetworkManagerVPCAttachment_update/acceptance_required (420.62s)
    --- PASS: TestAccNetworkManagerVPCAttachment_update/acceptance_not_required (1173.48s)
--- PASS: TestAccNetworkManagerVPCAttachment_disappears (0.00s)
    --- PASS: TestAccNetworkManagerVPCAttachment_disappears/acceptance_required (432.69s)
    --- PASS: TestAccNetworkManagerVPCAttachment_disappears/acceptance_not_required (631.26s)
--- PASS: TestAccNetworkManagerVPCAttachment_basic (0.00s)
    --- PASS: TestAccNetworkManagerVPCAttachment_basic/acceptance_required (433.29s)
    --- PASS: TestAccNetworkManagerVPCAttachment_basic/acceptance_not_required (694.74s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	11255.888s
FAIL
make: *** [testacc] Error 1

Failure is unrelated to this change.

@ewbankkit
Copy link
Contributor

@DanielRieske Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit ac8c7bc into hashicorp:main Aug 20, 2024
39 checks passed
@github-actions github-actions bot added this to the v5.64.0 milestone Aug 20, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.63.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 20, 2024
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. service/networkmanager Issues and PRs that pertain to the networkmanager service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.63.1
Development

Successfully merging this pull request may close these issues.

[AWS SDK for Go Migration] Network Manager Service
3 participants
@DanielRieske @ewbankkit @justinretzolk