Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change for recipe ARN should not force new pipeline #39117

Conversation

dex4er
Copy link
Contributor

@dex4er dex4er commented Sep 2, 2024

Description

Currently provider forces to recreate a pipeline if version of recipe changes:

  # module.base_ami.aws_imagebuilder_image_pipeline.this must be replaced
-/+ resource "aws_imagebuilder_image_pipeline" "this" {
      ~ arn                              = "arn:aws:imagebuilder:eu-central-1:123456789012:image-pipeline/ubuntu-noble-24-04-base" -> (known after apply)
      ~ date_created                     = "2024-09-02T16:17:51.955Z" -> (known after apply)
      ~ date_updated                     = "2024-09-02T18:24:04.622Z" -> (known after apply)
      + description                      = "AMI image based on ubuntu-noble-24.04 20240810"
      + distribution_configuration_arn   = "arn:aws:imagebuilder:eu-central-1:123456789012:distribution-configuration/ubuntu-noble-24-04-base"
      ~ id                               = "arn:aws:imagebuilder:eu-central-1:123456789012:image-pipeline/ubuntu-noble-24-04-base" -> (known after apply)
      ~ image_recipe_arn                 = "arn:aws:imagebuilder:eu-central-1:123456789012:image-recipe/ubuntu-noble-24-04-base/1.0.20240801" -> "arn:aws:imagebuilder:eu-central-1:123456789012:image-recipe/ubuntu-noble-24-04-base/1.0.20240810" # forces replacement
        name                             = "ubuntu-noble-24_04-base"
      ~ platform                         = "Linux" -> (known after apply)
        tags                             = {
            "Variant"      = "base"
        }

      ~ image_tests_configuration {
          ~ timeout_minutes     = 720 -> 60
        }
    }

It is possible to change recipe ARN in the builder pipeline without recreating it:

Example:

aws imagebuilder update-image-pipeline --image-pipeline-arn arn:aws:imagebuilder:eu-central-1:123456789012:image-pipeline/ubuntu-noble-24-04-base --image-recipe-arn arn:aws:imagebuilder:eu-central-1:123456789012:image-recipe/ubuntu-noble-24-04-base/1.0.20240801 --infrastructure-configuration-arn arn:aws:imagebuilder:eu-central-1:123456789012:infrastructure-configuration/ubuntu-noble-24-04-base

Result:

requestId: 240f939c-d9d6-4516-8bde-fb0d38ab211e
imagePipelineArn: arn:aws:imagebuilder:eu-central-1:123456789012:image-pipeline/ubuntu-noble-24-04-base

Relations

Closes #39803.

References

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/imagebuilder_image_pipeline#image_recipe_arn

https://docs.aws.amazon.com/imagebuilder/latest/APIReference/API_UpdateImagePipeline.html

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2
=== NAME  TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMapping_deviceName
    container_recipe_test.go:215: Step 2/2 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.
        
          map[string]string{
        +       "instance_configuration.0.block_device_mapping.0.no_device": "false",
          }
--- FAIL: TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMapping_deviceName (66.11s)
=== NAME  TestAccImageBuilderContainerRecipe_InstanceConfiguration_Image
    container_recipe_test.go:545: Step 1/2 error: Error running pre-apply plan: exit status 1
        
        Error: Your query returned no results. Please change your search criteria and try again.
        
          with data.aws_ami.test,
          on terraform_plugin_test.tf line 21, in data "aws_ami" "test":
          21: data "aws_ami" "test" {
        
--- FAIL: TestAccImageBuilderContainerRecipe_InstanceConfiguration_Image (5.99s)
...

Failures are not related to the change.

@dex4er dex4er requested a review from a team as a code owner September 2, 2024 19:19
Copy link

github-actions bot commented Sep 2, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/imagebuilder Issues and PRs that pertain to the imagebuilder service. needs-triage Waiting for first response or review from a maintainer. labels Sep 2, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @dex4er 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 3, 2024
@dex4er
Copy link
Contributor Author

dex4er commented Sep 4, 2024

FYI, as I see, awscc provider behaves correctly:

  # module.base_ami.awscc_imagebuilder_image_pipeline.this will be updated in-place
  ~ resource "awscc_imagebuilder_image_pipeline" "this" {
        id                               = "arn:aws:imagebuilder:eu-central-1:123456789012:image-pipeline/ubuntu-noble-24-04-amd64"
      ~ image_recipe_arn                 = "arn:aws:imagebuilder:eu-central-1:123456789012:image-recipe/ubuntu-noble-24-04-amd64/1.0.20240827" -> (known after apply)
      ~ image_scanning_configuration     = {
        }
        name                             = "ubuntu-noble-24_04-amd64"
        tags                             = {
            "Arch"         = "amd64"
            "Name"         = "ubuntu-noble-24_04-amd64"
        }
    }

@ewbankkit ewbankkit self-assigned this Oct 29, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 29, 2024
…`, `component.parameter.value`, `target_repository.repository_name`, and `target_repository.service` to ForceNew.
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccImageBuilderImagePipeline_' PKG=imagebuilder ACCTEST_PARALLELISM=4 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/imagebuilder/... -v -count 1 -parallel 4  -run=TestAccImageBuilderImagePipeline_ -timeout 360m
2024/10/29 11:33:38 Initializing Terraform AWS Provider...
=== RUN   TestAccImageBuilderImagePipeline_basic
=== PAUSE TestAccImageBuilderImagePipeline_basic
=== RUN   TestAccImageBuilderImagePipeline_disappears
=== PAUSE TestAccImageBuilderImagePipeline_disappears
=== RUN   TestAccImageBuilderImagePipeline_description
=== PAUSE TestAccImageBuilderImagePipeline_description
=== RUN   TestAccImageBuilderImagePipeline_distributionARN
=== PAUSE TestAccImageBuilderImagePipeline_distributionARN
=== RUN   TestAccImageBuilderImagePipeline_enhancedImageMetadataEnabled
=== PAUSE TestAccImageBuilderImagePipeline_enhancedImageMetadataEnabled
=== RUN   TestAccImageBuilderImagePipeline_imageRecipeARN
=== PAUSE TestAccImageBuilderImagePipeline_imageRecipeARN
=== RUN   TestAccImageBuilderImagePipeline_containerRecipeARN
=== PAUSE TestAccImageBuilderImagePipeline_containerRecipeARN
=== RUN   TestAccImageBuilderImagePipeline_ImageScanning_imageScanningEnabled
=== PAUSE TestAccImageBuilderImagePipeline_ImageScanning_imageScanningEnabled
=== RUN   TestAccImageBuilderImagePipeline_ImageScanning_imageScanningEnabledAdvanced
=== PAUSE TestAccImageBuilderImagePipeline_ImageScanning_imageScanningEnabledAdvanced
=== RUN   TestAccImageBuilderImagePipeline_ImageTests_imageTestsEnabled
=== PAUSE TestAccImageBuilderImagePipeline_ImageTests_imageTestsEnabled
=== RUN   TestAccImageBuilderImagePipeline_ImageTests_timeoutMinutes
=== PAUSE TestAccImageBuilderImagePipeline_ImageTests_timeoutMinutes
=== RUN   TestAccImageBuilderImagePipeline_infrastructureARN
=== PAUSE TestAccImageBuilderImagePipeline_infrastructureARN
=== RUN   TestAccImageBuilderImagePipeline_Schedule_pipelineExecutionStartCondition
=== PAUSE TestAccImageBuilderImagePipeline_Schedule_pipelineExecutionStartCondition
=== RUN   TestAccImageBuilderImagePipeline_Schedule_scheduleExpression
=== PAUSE TestAccImageBuilderImagePipeline_Schedule_scheduleExpression
=== RUN   TestAccImageBuilderImagePipeline_Schedule_timezone
=== PAUSE TestAccImageBuilderImagePipeline_Schedule_timezone
=== RUN   TestAccImageBuilderImagePipeline_status
=== PAUSE TestAccImageBuilderImagePipeline_status
=== RUN   TestAccImageBuilderImagePipeline_tags
=== PAUSE TestAccImageBuilderImagePipeline_tags
=== RUN   TestAccImageBuilderImagePipeline_workflow
=== PAUSE TestAccImageBuilderImagePipeline_workflow
=== RUN   TestAccImageBuilderImagePipeline_workflowParameter
=== PAUSE TestAccImageBuilderImagePipeline_workflowParameter
=== CONT  TestAccImageBuilderImagePipeline_basic
=== CONT  TestAccImageBuilderImagePipeline_ImageTests_timeoutMinutes
=== CONT  TestAccImageBuilderImagePipeline_status
=== CONT  TestAccImageBuilderImagePipeline_workflow
--- PASS: TestAccImageBuilderImagePipeline_basic (26.71s)
=== CONT  TestAccImageBuilderImagePipeline_Schedule_scheduleExpression
--- PASS: TestAccImageBuilderImagePipeline_ImageTests_timeoutMinutes (36.68s)
=== CONT  TestAccImageBuilderImagePipeline_Schedule_timezone
--- PASS: TestAccImageBuilderImagePipeline_status (37.44s)
=== CONT  TestAccImageBuilderImagePipeline_workflowParameter
--- PASS: TestAccImageBuilderImagePipeline_workflow (39.39s)
=== CONT  TestAccImageBuilderImagePipeline_Schedule_pipelineExecutionStartCondition
--- PASS: TestAccImageBuilderImagePipeline_Schedule_scheduleExpression (35.92s)
=== CONT  TestAccImageBuilderImagePipeline_tags
--- PASS: TestAccImageBuilderImagePipeline_Schedule_pipelineExecutionStartCondition (35.42s)
=== CONT  TestAccImageBuilderImagePipeline_infrastructureARN
=== CONT  TestAccImageBuilderImagePipeline_imageRecipeARN
--- PASS: TestAccImageBuilderImagePipeline_Schedule_timezone (38.14s)
--- PASS: TestAccImageBuilderImagePipeline_workflowParameter (44.08s)
=== CONT  TestAccImageBuilderImagePipeline_ImageTests_imageTestsEnabled
--- PASS: TestAccImageBuilderImagePipeline_infrastructureARN (40.03s)
=== CONT  TestAccImageBuilderImagePipeline_ImageScanning_imageScanningEnabledAdvanced
--- PASS: TestAccImageBuilderImagePipeline_ImageTests_imageTestsEnabled (34.20s)
=== CONT  TestAccImageBuilderImagePipeline_ImageScanning_imageScanningEnabled
=== NAME  TestAccImageBuilderImagePipeline_ImageScanning_imageScanningEnabledAdvanced
    acctest.go:1679: skipping test for aws/us-west-2: Error running apply: exit status 1
        
        Error: creating Image Builder Image Pipeline: operation error imagebuilder: CreateImagePipeline, https response error StatusCode: 400, RequestID: 937924bf-a89c-4245-a971-b35880e176a3, api error ResourceDependencyException: Resource dependency error: Amazon Inspector is not enabled for 'ecr' resources in account '187416307283'.
        
          with aws_imagebuilder_image_pipeline.test,
          on terraform_plugin_test.tf line 105, in resource "aws_imagebuilder_image_pipeline" "test":
         105: resource "aws_imagebuilder_image_pipeline" "test" {
        
--- PASS: TestAccImageBuilderImagePipeline_tags (68.54s)
=== CONT  TestAccImageBuilderImagePipeline_containerRecipeARN
--- SKIP: TestAccImageBuilderImagePipeline_ImageScanning_imageScanningEnabledAdvanced (16.69s)
=== CONT  TestAccImageBuilderImagePipeline_distributionARN
--- PASS: TestAccImageBuilderImagePipeline_imageRecipeARN (62.12s)
=== CONT  TestAccImageBuilderImagePipeline_enhancedImageMetadataEnabled
=== NAME  TestAccImageBuilderImagePipeline_ImageScanning_imageScanningEnabled
    acctest.go:1679: skipping test for aws/us-west-2: Error running apply: exit status 1
        
        Error: updating Image Builder Image Pipeline (arn:aws:imagebuilder:us-west-2:187416307283:image-pipeline/tf-acc-test-6675496076042225490): operation error imagebuilder: UpdateImagePipeline, https response error StatusCode: 400, RequestID: bf226de9-7307-4de2-b2e6-9d95c60bd006, api error ResourceDependencyException: Resource dependency error: Amazon Inspector is not enabled for 'ec2' resources in account '187416307283'.
        
          with aws_imagebuilder_image_pipeline.test,
          on terraform_plugin_test.tf line 105, in resource "aws_imagebuilder_image_pipeline" "test":
         105: resource "aws_imagebuilder_image_pipeline" "test" {
        
--- SKIP: TestAccImageBuilderImagePipeline_ImageScanning_imageScanningEnabled (29.60s)
=== CONT  TestAccImageBuilderImagePipeline_description
--- PASS: TestAccImageBuilderImagePipeline_distributionARN (35.30s)
=== CONT  TestAccImageBuilderImagePipeline_disappears
--- PASS: TestAccImageBuilderImagePipeline_containerRecipeARN (37.48s)
--- PASS: TestAccImageBuilderImagePipeline_enhancedImageMetadataEnabled (37.60s)
--- PASS: TestAccImageBuilderImagePipeline_description (36.70s)
--- PASS: TestAccImageBuilderImagePipeline_disappears (23.87s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder	195.814s
% make testacc TESTARGS='-run=TestAccImageBuilderContainerRecipe_' PKG=imagebuilder ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/imagebuilder/... -v -count 1 -parallel 4  -run=TestAccImageBuilderContainerRecipe_ -timeout 360m
2024/10/29 11:41:55 Initializing Terraform AWS Provider...
=== RUN   TestAccImageBuilderContainerRecipe_basic
=== PAUSE TestAccImageBuilderContainerRecipe_basic
=== RUN   TestAccImageBuilderContainerRecipe_disappears
=== PAUSE TestAccImageBuilderContainerRecipe_disappears
=== RUN   TestAccImageBuilderContainerRecipe_component
=== PAUSE TestAccImageBuilderContainerRecipe_component
=== RUN   TestAccImageBuilderContainerRecipe_componentParameter
=== PAUSE TestAccImageBuilderContainerRecipe_componentParameter
=== RUN   TestAccImageBuilderContainerRecipe_description
=== PAUSE TestAccImageBuilderContainerRecipe_description
=== RUN   TestAccImageBuilderContainerRecipe_dockerfileTemplateURI
=== PAUSE TestAccImageBuilderContainerRecipe_dockerfileTemplateURI
=== RUN   TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMapping_deviceName
=== PAUSE TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMapping_deviceName
=== RUN   TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_deleteOnTermination
=== PAUSE TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_deleteOnTermination
=== RUN   TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_encrypted
=== PAUSE TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_encrypted
=== RUN   TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_iops
=== PAUSE TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_iops
=== RUN   TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_kmsKeyID
=== PAUSE TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_kmsKeyID
=== RUN   TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_snapshotID
=== PAUSE TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_snapshotID
=== RUN   TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_throughput
=== PAUSE TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_throughput
=== RUN   TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_volumeSize
=== PAUSE TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_volumeSize
=== RUN   TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_volumeType
=== PAUSE TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_volumeType
=== RUN   TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMapping_noDevice
=== PAUSE TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMapping_noDevice
=== RUN   TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMapping_virtualName
=== PAUSE TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMapping_virtualName
=== RUN   TestAccImageBuilderContainerRecipe_InstanceConfiguration_Image
=== PAUSE TestAccImageBuilderContainerRecipe_InstanceConfiguration_Image
=== RUN   TestAccImageBuilderContainerRecipe_kmsKeyID
=== PAUSE TestAccImageBuilderContainerRecipe_kmsKeyID
=== RUN   TestAccImageBuilderContainerRecipe_tags
=== PAUSE TestAccImageBuilderContainerRecipe_tags
=== RUN   TestAccImageBuilderContainerRecipe_workingDirectory
=== PAUSE TestAccImageBuilderContainerRecipe_workingDirectory
=== RUN   TestAccImageBuilderContainerRecipe_platformOverride
=== PAUSE TestAccImageBuilderContainerRecipe_platformOverride
=== CONT  TestAccImageBuilderContainerRecipe_basic
=== CONT  TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_snapshotID
=== CONT  TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMapping_deviceName
=== CONT  TestAccImageBuilderContainerRecipe_InstanceConfiguration_Image
--- PASS: TestAccImageBuilderContainerRecipe_basic (17.81s)
=== CONT  TestAccImageBuilderContainerRecipe_platformOverride
--- PASS: TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMapping_deviceName (17.90s)
=== CONT  TestAccImageBuilderContainerRecipe_workingDirectory
--- PASS: TestAccImageBuilderContainerRecipe_platformOverride (16.39s)
=== CONT  TestAccImageBuilderContainerRecipe_tags
--- PASS: TestAccImageBuilderContainerRecipe_workingDirectory (17.37s)
=== CONT  TestAccImageBuilderContainerRecipe_kmsKeyID
--- PASS: TestAccImageBuilderContainerRecipe_kmsKeyID (18.03s)
=== CONT  TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_volumeSize
--- PASS: TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_volumeSize (16.96s)
=== CONT  TestAccImageBuilderContainerRecipe_componentParameter
--- PASS: TestAccImageBuilderContainerRecipe_tags (36.44s)
=== CONT  TestAccImageBuilderContainerRecipe_dockerfileTemplateURI
--- PASS: TestAccImageBuilderContainerRecipe_InstanceConfiguration_Image (72.61s)
=== CONT  TestAccImageBuilderContainerRecipe_description
--- PASS: TestAccImageBuilderContainerRecipe_componentParameter (18.21s)
=== CONT  TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMapping_virtualName
--- PASS: TestAccImageBuilderContainerRecipe_description (17.29s)
=== CONT  TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_throughput
--- PASS: TestAccImageBuilderContainerRecipe_dockerfileTemplateURI (20.56s)
=== CONT  TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMapping_noDevice
--- PASS: TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMapping_virtualName (16.39s)
=== CONT  TestAccImageBuilderContainerRecipe_component
--- PASS: TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMapping_noDevice (17.03s)
=== CONT  TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_iops
--- PASS: TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_throughput (18.82s)
=== CONT  TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_kmsKeyID
--- PASS: TestAccImageBuilderContainerRecipe_component (17.89s)
=== CONT  TestAccImageBuilderContainerRecipe_disappears
--- PASS: TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_iops (17.05s)
=== CONT  TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_encrypted
--- PASS: TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_kmsKeyID (19.12s)
=== CONT  TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_deleteOnTermination
--- PASS: TestAccImageBuilderContainerRecipe_disappears (14.68s)
=== CONT  TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_volumeType
--- PASS: TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_snapshotID (137.87s)
--- PASS: TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_encrypted (17.35s)
--- PASS: TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_deleteOnTermination (17.20s)
--- PASS: TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_volumeType (17.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder	160.317s

@ewbankkit
Copy link
Contributor

@dex4er Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit b4ada46 into hashicorp:main Oct 29, 2024
37 checks passed
@github-actions github-actions bot added this to the v5.74.0 milestone Oct 29, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 31, 2024
Copy link

This functionality has been released in v5.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/imagebuilder Issues and PRs that pertain to the imagebuilder service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Image Builder Container Recipe Resource Does not Update Target Repository Name
3 participants