Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed boolEquals to boolvalidator.Equals package and removed custom validator #39860

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

rainkwan
Copy link
Contributor

@rainkwan rainkwan commented Oct 23, 2024

Description

Closes #39817

Replaced custom validator with BoolEquals from #39180 .

  • Removed custom validator
  • Replaced with boolvalidator.Equals
  • Ran acceptance tests for the data source utilizing this validator

Relations

Closes #39817
Depends on #39790
Relates #39180
Relates hashicorp/terraform-plugin-framework-validators#232

@rainkwan rainkwan requested a review from a team as a code owner October 23, 2024 17:09
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/synthetics Issues and PRs that pertain to the synthetics service. labels Oct 23, 2024
Copy link

Hey @rainkwan 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.)

@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 23, 2024
@rainkwan rainkwan requested a review from jar-b October 23, 2024 17:16
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @rainkwan 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@rainkwan rainkwan changed the title Changed boolEquals to boolvalidator.Equals package and rm custom validator Changed boolEquals to boolvalidator.Equals package and removed custom validator Oct 23, 2024
@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Oct 23, 2024
@jar-b jar-b self-assigned this Oct 23, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 23, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=synthetics TESTS=TestAccSyntheticsRuntimeVersionDataSource_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/synthetics/... -v -count 1 -parallel 20 -run='TestAccSyntheticsRuntimeVersionDataSource_'  -timeout 360m
2024/10/23 13:35:46 Initializing Terraform AWS Provider...

--- PASS: TestAccSyntheticsRuntimeVersionDataSource_deprecatedVersion (9.37s)
--- PASS: TestAccSyntheticsRuntimeVersionDataSource_basic (9.37s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/synthetics 15.698s

@jar-b
Copy link
Member

jar-b commented Oct 23, 2024

Thanks for your contribution, @rainkwan! 👍

@jar-b jar-b merged commit bcc1577 into main Oct 23, 2024
86 checks passed
@jar-b jar-b deleted the td-boolequals branch October 23, 2024 17:41
@github-actions github-actions bot added this to the v5.73.0 milestone Oct 23, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Oct 23, 2024
Copy link

This functionality has been released in v5.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/synthetics Issues and PRs that pertain to the synthetics service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TechDebt]: Replace internal BoolEquals validator with boolvalidator.Equals
2 participants