Remove use of sort functions that take sort.Interface

[gdavison]

Description

Removes use of sort functions that take sort.Interface

Includes fixes from #39938

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPCSecurityGroupRule_' PKG=ec2 ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ec2/... -v -count 1 -parallel 4  -run=TestAccVPCSecurityGroupRule_ -timeout 360m
2024/10/30 08:15:30 Initializing Terraform AWS Provider...
=== RUN   TestAccVPCSecurityGroupRule_Ingress_vpc
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_vpc
=== RUN   TestAccVPCSecurityGroupRule_IngressSourceWithAccount_id
=== PAUSE TestAccVPCSecurityGroupRule_IngressSourceWithAccount_id
=== RUN   TestAccVPCSecurityGroupRule_Ingress_protocol
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_protocol
=== RUN   TestAccVPCSecurityGroupRule_Ingress_icmpv6
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_icmpv6
=== RUN   TestAccVPCSecurityGroupRule_Ingress_ipv6
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_ipv6
=== RUN   TestAccVPCSecurityGroupRule_egress
=== PAUSE TestAccVPCSecurityGroupRule_egress
=== RUN   TestAccVPCSecurityGroupRule_disappears
=== PAUSE TestAccVPCSecurityGroupRule_disappears
=== RUN   TestAccVPCSecurityGroupRule_selfReference
=== PAUSE TestAccVPCSecurityGroupRule_selfReference
=== RUN   TestAccVPCSecurityGroupRule_expectInvalidTypeError
=== PAUSE TestAccVPCSecurityGroupRule_expectInvalidTypeError
=== RUN   TestAccVPCSecurityGroupRule_expectInvalidCIDR
=== PAUSE TestAccVPCSecurityGroupRule_expectInvalidCIDR
=== RUN   TestAccVPCSecurityGroupRule_PartialMatching_basic
=== PAUSE TestAccVPCSecurityGroupRule_PartialMatching_basic
=== RUN   TestAccVPCSecurityGroupRule_PartialMatching_source
=== PAUSE TestAccVPCSecurityGroupRule_PartialMatching_source
=== RUN   TestAccVPCSecurityGroupRule_issue5310
=== PAUSE TestAccVPCSecurityGroupRule_issue5310
=== RUN   TestAccVPCSecurityGroupRule_race
=== PAUSE TestAccVPCSecurityGroupRule_race
=== RUN   TestAccVPCSecurityGroupRule_selfSource
=== PAUSE TestAccVPCSecurityGroupRule_selfSource
=== RUN   TestAccVPCSecurityGroupRule_prefixListEgress
=== PAUSE TestAccVPCSecurityGroupRule_prefixListEgress
=== RUN   TestAccVPCSecurityGroupRule_prefixListEmptyString
=== PAUSE TestAccVPCSecurityGroupRule_prefixListEmptyString
=== RUN   TestAccVPCSecurityGroupRule_ingressDescription
=== PAUSE TestAccVPCSecurityGroupRule_ingressDescription
=== RUN   TestAccVPCSecurityGroupRule_egressDescription
=== PAUSE TestAccVPCSecurityGroupRule_egressDescription
=== RUN   TestAccVPCSecurityGroupRule_IngressDescription_updates
=== PAUSE TestAccVPCSecurityGroupRule_IngressDescription_updates
=== RUN   TestAccVPCSecurityGroupRule_EgressDescription_updates
=== PAUSE TestAccVPCSecurityGroupRule_EgressDescription_updates
=== RUN   TestAccVPCSecurityGroupRule_Description_allPorts
=== PAUSE TestAccVPCSecurityGroupRule_Description_allPorts
=== RUN   TestAccVPCSecurityGroupRule_DescriptionAllPorts_nonZeroPorts
=== PAUSE TestAccVPCSecurityGroupRule_DescriptionAllPorts_nonZeroPorts
=== RUN   TestAccVPCSecurityGroupRule_MultipleRuleSearching_allProtocolCrash
=== PAUSE TestAccVPCSecurityGroupRule_MultipleRuleSearching_allProtocolCrash
=== RUN   TestAccVPCSecurityGroupRule_multiDescription
=== PAUSE TestAccVPCSecurityGroupRule_multiDescription
=== RUN   TestAccVPCSecurityGroupRule_Ingress_multipleIPv6
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_multipleIPv6
=== RUN   TestAccVPCSecurityGroupRule_Ingress_multiplePrefixLists
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_multiplePrefixLists
=== RUN   TestAccVPCSecurityGroupRule_Ingress_peeredVPC
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_peeredVPC
=== RUN   TestAccVPCSecurityGroupRule_Ingress_ipv4AndIPv6
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_ipv4AndIPv6
=== RUN   TestAccVPCSecurityGroupRule_Ingress_prefixListAndSelf
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_prefixListAndSelf
=== RUN   TestAccVPCSecurityGroupRule_Ingress_prefixListAndSource
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_prefixListAndSource
=== RUN   TestAccVPCSecurityGroupRule_protocolChange
=== PAUSE TestAccVPCSecurityGroupRule_protocolChange
=== CONT  TestAccVPCSecurityGroupRule_Ingress_vpc
=== CONT  TestAccVPCSecurityGroupRule_prefixListEmptyString
=== CONT  TestAccVPCSecurityGroupRule_multiDescription
=== CONT  TestAccVPCSecurityGroupRule_Ingress_ipv4AndIPv6
--- PASS: TestAccVPCSecurityGroupRule_prefixListEmptyString (1.68s)
=== CONT  TestAccVPCSecurityGroupRule_protocolChange
--- PASS: TestAccVPCSecurityGroupRule_Ingress_vpc (18.01s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_prefixListAndSource
=== CONT  TestAccVPCSecurityGroupRule_Ingress_prefixListAndSelf
--- PASS: TestAccVPCSecurityGroupRule_Ingress_ipv4AndIPv6 (22.09s)
--- PASS: TestAccVPCSecurityGroupRule_Ingress_prefixListAndSource (27.78s)
=== CONT  TestAccVPCSecurityGroupRule_DescriptionAllPorts_nonZeroPorts
--- PASS: TestAccVPCSecurityGroupRule_Ingress_prefixListAndSelf (27.70s)
=== CONT  TestAccVPCSecurityGroupRule_EgressDescription_updates
--- PASS: TestAccVPCSecurityGroupRule_protocolChange (48.49s)
=== CONT  TestAccVPCSecurityGroupRule_MultipleRuleSearching_allProtocolCrash
--- PASS: TestAccVPCSecurityGroupRule_multiDescription (65.47s)
=== CONT  TestAccVPCSecurityGroupRule_Description_allPorts
--- PASS: TestAccVPCSecurityGroupRule_MultipleRuleSearching_allProtocolCrash (20.53s)
=== CONT  TestAccVPCSecurityGroupRule_expectInvalidTypeError
--- PASS: TestAccVPCSecurityGroupRule_expectInvalidTypeError (0.76s)
=== CONT  TestAccVPCSecurityGroupRule_egressDescription
--- PASS: TestAccVPCSecurityGroupRule_DescriptionAllPorts_nonZeroPorts (25.91s)
=== CONT  TestAccVPCSecurityGroupRule_prefixListEgress
--- PASS: TestAccVPCSecurityGroupRule_EgressDescription_updates (26.16s)
=== CONT  TestAccVPCSecurityGroupRule_IngressDescription_updates
--- PASS: TestAccVPCSecurityGroupRule_egressDescription (17.12s)
=== CONT  TestAccVPCSecurityGroupRule_selfSource
--- PASS: TestAccVPCSecurityGroupRule_Description_allPorts (26.37s)
=== CONT  TestAccVPCSecurityGroupRule_race
--- PASS: TestAccVPCSecurityGroupRule_IngressDescription_updates (25.52s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_multiplePrefixLists
--- PASS: TestAccVPCSecurityGroupRule_prefixListEgress (31.76s)
=== CONT  TestAccVPCSecurityGroupRule_issue5310
--- PASS: TestAccVPCSecurityGroupRule_selfSource (21.44s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_peeredVPC
    vpc_security_group_rule_test.go:1373: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccVPCSecurityGroupRule_Ingress_peeredVPC (0.00s)
=== CONT  TestAccVPCSecurityGroupRule_PartialMatching_source
--- PASS: TestAccVPCSecurityGroupRule_issue5310 (17.26s)
=== CONT  TestAccVPCSecurityGroupRule_expectInvalidCIDR
--- PASS: TestAccVPCSecurityGroupRule_expectInvalidCIDR (1.26s)
=== CONT  TestAccVPCSecurityGroupRule_PartialMatching_basic
--- PASS: TestAccVPCSecurityGroupRule_Ingress_multiplePrefixLists (27.45s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_ipv6
--- PASS: TestAccVPCSecurityGroupRule_PartialMatching_source (25.96s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_multipleIPv6
--- PASS: TestAccVPCSecurityGroupRule_PartialMatching_basic (29.23s)
=== CONT  TestAccVPCSecurityGroupRule_selfReference
--- PASS: TestAccVPCSecurityGroupRule_Ingress_ipv6 (22.73s)
=== CONT  TestAccVPCSecurityGroupRule_egress
--- PASS: TestAccVPCSecurityGroupRule_Ingress_multipleIPv6 (22.02s)
=== CONT  TestAccVPCSecurityGroupRule_disappears
--- PASS: TestAccVPCSecurityGroupRule_egress (17.95s)
=== CONT  TestAccVPCSecurityGroupRule_ingressDescription
--- PASS: TestAccVPCSecurityGroupRule_selfReference (22.15s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_protocol
--- PASS: TestAccVPCSecurityGroupRule_disappears (15.69s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_icmpv6
--- PASS: TestAccVPCSecurityGroupRule_ingressDescription (16.97s)
=== CONT  TestAccVPCSecurityGroupRule_IngressSourceWithAccount_id
--- PASS: TestAccVPCSecurityGroupRule_Ingress_protocol (21.34s)
--- PASS: TestAccVPCSecurityGroupRule_Ingress_icmpv6 (21.90s)
--- PASS: TestAccVPCSecurityGroupRule_IngressSourceWithAccount_id (20.07s)
--- PASS: TestAccVPCSecurityGroupRule_race (160.81s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	258.045s

% make testacc TESTARGS='-run=TestAccNetworkManagerCoreNetworkPolicyAttachment_' PKG=networkmanager ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/networkmanager/... -v -count 1 -parallel 3  -run=TestAccNetworkManagerCoreNetworkPolicyAttachment_ -timeout 360m
2024/10/30 08:22:35 Initializing Terraform AWS Provider...
=== RUN   TestAccNetworkManagerCoreNetworkPolicyAttachment_basic
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyAttachment_basic
=== RUN   TestAccNetworkManagerCoreNetworkPolicyAttachment_vpcAttachment
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyAttachment_vpcAttachment
=== RUN   TestAccNetworkManagerCoreNetworkPolicyAttachment_vpcAttachmentMultiRegion
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyAttachment_vpcAttachmentMultiRegion
=== RUN   TestAccNetworkManagerCoreNetworkPolicyAttachment_expectPolicyErrorInvalidASNRange
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyAttachment_expectPolicyErrorInvalidASNRange
=== CONT  TestAccNetworkManagerCoreNetworkPolicyAttachment_basic
=== CONT  TestAccNetworkManagerCoreNetworkPolicyAttachment_vpcAttachmentMultiRegion
=== CONT  TestAccNetworkManagerCoreNetworkPolicyAttachment_vpcAttachment
--- PASS: TestAccNetworkManagerCoreNetworkPolicyAttachment_basic (718.81s)
=== CONT  TestAccNetworkManagerCoreNetworkPolicyAttachment_expectPolicyErrorInvalidASNRange
--- PASS: TestAccNetworkManagerCoreNetworkPolicyAttachment_expectPolicyErrorInvalidASNRange (308.81s)
--- PASS: TestAccNetworkManagerCoreNetworkPolicyAttachment_vpcAttachment (1142.32s)
--- PASS: TestAccNetworkManagerCoreNetworkPolicyAttachment_vpcAttachmentMultiRegion (1843.64s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	1848.710s

[github-actions]

This functionality has been released in v5.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!