Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix constants #39938

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Fix constants #39938

merged 1 commit into from
Oct 30, 2024

Conversation

gdavison
Copy link
Contributor

Description

The PR #36331 introduced a number of constant errors.

@gdavison gdavison requested a review from a team as a code owner October 30, 2024 00:29
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/keyspaces Issues and PRs that pertain to the keyspaces service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Oct 30, 2024
This was referenced Oct 30, 2024
Merged
Merged
ewbankkit
ewbankkit approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@jar-b jar-b mentioned this pull request Oct 30, 2024
Merged
@gdavison gdavison merged commit 08cfa75 into main Oct 30, 2024
41 checks passed
@gdavison gdavison deleted the td-fix-constants branch October 30, 2024 17:16
@github-actions github-actions bot added this to the v5.74.0 milestone Oct 30, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
service/keyspaces Issues and PRs that pertain to the keyspaces service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.74.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @ewbankkit