[sfn/state_machine] fix logging_configuration

[kuredev]

According to AWS specifications, the default is set to OFF if not specified https://docs.aws.amazon.com/step-functions/latest/apireference/API_CreateStateMachine.html

Description

In the aws_sfn_state_machine resource, if logging_configuration is specified but level is not, applying it once succeeds, but trying to apply it again results in a failure.

logging_configuration {
  include_execution_data = false
}

This is likely because, in AWS, the default value for level is "OFF," so "OFF" is recorded in the deployed environment and tfstate. However, since no default value was set in the Terraform provider, it is mistakenly detected as a change.

~ logging_configuration {
  - level                  = "OFF" -> null
	# (2 unchanged attributes hidden)
}

https://docs.aws.amazon.com/step-functions/latest/apireference/API_CreateStateMachine.html

Therefore, I set a default value for level in the schema of the Terraform provider. After testing, I confirmed that no changes are detected upon reapplying.

Relations

Closes #34697

References

Output from Acceptance Testing

make testacc PKG=sfn TESTS='TestAccSFNStateMachine_expressLogging'
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sfn/... -v -count 1 -parallel 20 -run='TestAccSFNStateMachine_expressLogging'  -timeout 360m
2024/10/31 11:12:33 Initializing Terraform AWS Provider...
=== RUN   TestAccSFNStateMachine_expressLogging
=== PAUSE TestAccSFNStateMachine_expressLogging
=== CONT  TestAccSFNStateMachine_expressLogging
--- PASS: TestAccSFNStateMachine_expressLogging (101.32s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sfn        101.441s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.