Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypass iops check on unknown ebs volume types #39974

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

willgorman
Copy link

Description

This change will allow aws_ebs_volume resources to be created with iops regardless of the volume type, whenever the volume type is not one of awstypes.VolumeType. This allows the provider to be used to create volumes in AWS-compatible backends that offer additional volume types not found in AWS. It also allows the aws_ebs_resource to support any potential new AWS volume types that would allow iops.

Relations

Closes #39838

References

Output from Acceptance Testing

I don't think it's possible to run acceptance tests for this since it would involve using a volume type that AWS doesn't consider valid. I didn't see any unit tests for aws_ebs_volume but if unit tests are needed for this I can add them.

@willgorman willgorman requested a review from a team as a code owner October 31, 2024 21:05
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/ec2ebs Issues and PRs that pertain to the ec2ebs service. needs-triage Waiting for first response or review from a maintainer. labels Oct 31, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @willgorman 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Waiting for first response or review from a maintainer. service/ec2ebs Issues and PRs that pertain to the ec2ebs service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Option to skip iops validation for unknown ebs volume types
1 participant