Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add task_mode attr for aws_datasync_task #39979

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented Nov 1, 2024

Description

This PR is to add the recently released (enhanced) task mode feature to the aws_datasync_task resource. Note that enhanced task mode currently only supports transfer between S3 locations, and once set it cannot be changed (hence force new on this new argument).

Relations

Closes #39965

References

Referred to CreateTask for specs and wordings. Also referred to Choosing a task mode for your data transfer to confirm that task mode can only be set during task creation and not update.

Output from Acceptance Testing

$ make testacc TESTS="TestAccDataSyncTask_basic|TestAccDataSyncTask_taskMode" PKG=datasync
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/datasync/... -v -count 1 -parallel 20 -run='TestAccDataSyncTask_basic|TestAccDataSyncTask_taskMode'  -timeout 360m
2024/10/31 22:09:26 Initializing Terraform AWS Provider...
=== RUN   TestAccDataSyncTask_basic
=== PAUSE TestAccDataSyncTask_basic
=== RUN   TestAccDataSyncTask_taskMode
=== PAUSE TestAccDataSyncTask_taskMode
=== CONT  TestAccDataSyncTask_basic
=== CONT  TestAccDataSyncTask_taskMode
--- PASS: TestAccDataSyncTask_taskMode (46.89s)
--- PASS: TestAccDataSyncTask_basic (171.48s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/datasync   171.704s

$

@acwwat acwwat requested a review from a team as a code owner November 1, 2024 02:18
Copy link

github-actions bot commented Nov 1, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/datasync Issues and PRs that pertain to the datasync service. needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Nov 1, 2024
@acwwat acwwat force-pushed the f-aws_datasync_task-add_task_mode_attr branch from b9eff74 to ec7ea27 Compare November 1, 2024 02:19
@acwwat acwwat force-pushed the f-aws_datasync_task-add_task_mode_attr branch from ec7ea27 to 5e87f65 Compare November 1, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. needs-triage Waiting for first response or review from a maintainer. service/datasync Issues and PRs that pertain to the datasync service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: DataSync Task Enhanced mode
1 participant