Draft: Deprecates health_check_custom_config.failure_threshold

[Bexanderthebex]

Description

This PR will try to resolve the issue with the aws_service_discovery_service resource where setting the health_check_custom_config.failure_threshold to a value other than 1 results into the following behaviors:

• During resource creation, the value is getting ignored as the AWS SDK overrides it to 1
• After the initial resource creation, the resource always gets recreated as terraform detects that the value written in the terraform file is not on par with the setting in the AWS Cloudformation Stack. This causes uninteded terraform apply failures since terraform will try to destroy and then recreate the resource again even with tight depedencies that terraform won't simply allow.

Relations

Closes #37955

References

#35559

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.