Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"restart_policy" is wrongly documented at least for kubernetes_deployment resource #2591

Closed
daniel-dona opened this issue Sep 25, 2024 · 1 comment · Fixed by #2595
Closed
Assignees
Labels

Comments

@daniel-dona
Copy link

Terraform Version, Provider Version and Kubernetes Version

Terraform version: -
Kubernetes provider version: 2.32.0
Kubernetes version: -

Affected Resource(s)

  • documentation

Important Factoids

This seems to start in a pretty old ticket kubernetes/kubernetes#24725 as not all restart policies are supported depending on the resource kind. But this is not clear in the documentation, that just list the options but not if they apply to that resource type.

People then are facing a confusing error message like this one:
Unsupported value: "OnFailure": supported values: "Always"

For me doesn't make a lot of sense to have an option that only have one valid value. But I think is more critical to proper document that. Lot's of frustrated people with this...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@daniel-dona daniel-dona changed the title "restart_policy" is wrongly documented at least for kuberneted_deployment resource "restart_policy" is wrongly documented at least for kubernetes_deployment resource Sep 25, 2024
@alexsomesan
Copy link
Member

Thanks for catching this. A fix is on the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants