Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add force_update field to kubernetes_manifest schema #2401

Closed
wants to merge 1 commit into from

Conversation

BBBmau
Copy link
Contributor

@BBBmau BBBmau commented Jan 12, 2024

Description

kubernetes_manifest would now give users the option to override the destroy and recreate action with just a replacement in cases where a value in CRD is marked as x-kubernetes-preserve-unknown-fields

It should be documented that this field should only be turned on in very specific use cases since DynamicTypes can cause some issues.

Fixes #2371
Fixes #2375
Fixes #1928

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@BBBmau
Copy link
Contributor Author

BBBmau commented Jan 12, 2024

Let me know your thoughts on this @alexsomesan

@BBBmau BBBmau changed the title add force_update field to schema add force_update field to kubernetes_manifest schema Jan 13, 2024
@BBBmau
Copy link
Contributor Author

BBBmau commented Feb 1, 2024

closing this since a more robust method for dealing with the listed issues is in the works.

@BBBmau BBBmau closed this Feb 1, 2024
@RafalKorepta
Copy link

Hi, @BBBmau What you mean by

more robust method for dealing with the listed issues is in the works

I'm interested in exactly your proposal to have option to output from the recreation process. Is there any PR or GH issue that I could follow? Maybe you expect any dates when such feature could land?

Thank you and whole Hashicorp team for trying to merit terraform with Kubernetes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants