Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse multiple certificates from single data source #356

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ropnop
Copy link

@ropnop ropnop commented May 10, 2023

Hello! This addresses the enhancement I raised in #352

This moves the decoding into a loop, which breaks when there are no more PEM blocks in the provided content.

I also added a test using the same test data CA chain.

Let me know if you think this is a valid approach. I think this should be fine to be backwards compatible since the data source returned a list (of always length 1) anyway

@ropnop ropnop requested a review from a team as a code owner May 10, 2023 15:25
@hashicorp-cla
Copy link

hashicorp-cla commented May 10, 2023

CLA assistant check
All committers have signed the CLA.

@clintmiller
Copy link

Any update on this? Sure would be great to have this merged.

@LudovicTOURMAN
Copy link

I'm also looking for this to be fixed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants