Adding support for specifying hashing algorithm #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Brough <edward.brough@gmail.com>
Signed-off-by: Edward Brough <edward.brough@gmail.com>
|
|
|
@austinvalle would you be free to review this and some of the other community submitted PRs? Many thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to specify the hashing algorithm that the certificate should use in its signatures.
Rather than specifying the full signature algorithm, we instead specify only the hashing algorithm as we can infer the remainder from the type of certificate supplied. This allows us the flexibility to customize the output without introducing too much complexity for the end user to manage.
This addresses #57