Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate annotations per service #588

Closed
velkovb opened this issue Aug 13, 2021 · 8 comments · Fixed by #896
Closed

Separate annotations per service #588

velkovb opened this issue Aug 13, 2021 · 8 comments · Fixed by #896
Labels
enhancement New feature or request

Comments

@velkovb
Copy link

velkovb commented Aug 13, 2021

Is your feature request related to a problem? Please describe.
Currently, the chart can accept only a single configuration for service annotations. My use case is that in AWS I want to present the active service via an NLB and that happens with the service annotations but as it set on all services, I get 3 NLBs deployed which is not what I want.

Describe the solution you'd like
Ability to specify annotations for specific service - active, standby, headless...

Describe alternatives you've considered
Present the service with an ingress.

@csabakollar
Copy link

csabakollar commented Aug 19, 2021

enable ui, which creates a new service and you have the option: https://github.com/hashicorp/vault-helm/blob/master/values.yaml#L693 active vault pod only. It will add an extra label to the label selector, so that ui will always go to the active pod.

edit:
ui service template relevant line(s): https://github.com/hashicorp/vault-helm/blob/master/templates/ui-service.yaml#L21

@velkovb
Copy link
Author

velkovb commented Aug 19, 2021

Thanks, that seems to be what I have been looking for but the UI part is what confused me. I assumed it is used only for exposing the UI and I was looking for the api and actually never looked into it.

@csabakollar
Copy link

np :)

@jamesgoodhouse
Copy link

I opened a PR for this 3 months ago but never got any traction -> #546 (comment)

@chris-ng-scmp
Copy link

This is an important feature, hope the PR can be reviewed soon...

@peikk0
Copy link

peikk0 commented May 31, 2022

Same issue with the labels, which makes it impossible to use label selectors to select only one service.

@chris-ng-scmp
Copy link

I opened a PR for this 3 months ago but never got any traction -> #546 (comment)

Seems they got some comments on the PR

@netflash
Copy link

This is related to my support ticket 101566, hopefully the ticket reference gives this issue an extra vote to get resolved faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants