Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow scale to zero #943

Merged
merged 4 commits into from
Aug 15, 2023
Merged

Allow scale to zero #943

merged 4 commits into from
Aug 15, 2023

Conversation

therealjsie
Copy link
Contributor

@therealjsie therealjsie commented Aug 14, 2023 •
edited by kschoche
Loading

Fixes #918

@therealjsie therealjsie requested a review from a team August 14, 2023 13:07
@hashicorp-cla
Copy link

hashicorp-cla commented Aug 14, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@therealjsie therealjsie mentioned this pull request Aug 14, 2023
Closed
@therealjsie
Copy link
Contributor Author

Fixes #918

tomhjp
tomhjp reviewed Aug 14, 2023
View reviewed changes
Copy link
Contributor

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this - it seems like an elegant solution while maintaining backwards compatibility. Just one question mark for me around whether we can safely rely on "invalid" as documented behaviour?

templates/_helpers.tpl Outdated Show resolved Hide resolved
test/unit/server-ha-statefulset.bats Show resolved Hide resolved
tomhjp
tomhjp approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this! LGTM. I've triggered the CI tests and I'll merge once they pass (which I'm certain they will as the unit tests have already passed).

@tomhjp tomhjp merged commit ec964a3 into hashicorp:main Aug 15, 2023
8 checks passed
@therealjsie
Copy link
Contributor Author

@tomhjp Thanks for merging! Out of curiosity, is there a regular release cadence, or when will a new release of the helm chart be triggered?

@swenson
Copy link
Contributor

swenson commented Aug 15, 2023

@therealjsie we typically aim to release every month

This was referenced Oct 3, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomhjp tomhjp tomhjp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to scale replicas to zero
4 participants
@therealjsie @hashicorp-cla @swenson @tomhjp