Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check if server.ha.replicas is a number when set in values.yaml #960

Closed
wants to merge 1 commit into from

Conversation

wtfloris
Copy link
Contributor

@wtfloris wtfloris commented Oct 3, 2023

The commits merged in #943 only work when using --set 'server.ha.replicas=2' from the CLI, not when server.ha.replicas is defined in values.yaml. This behaviour is expected and described in helm/helm#12084. You can see this in action on this playground.

This passes the unit tests because they don't use values.yaml, so only the CLI behaviour is tested and this passed without raising issues.

By checking if the value is either int64 or float64, both cases work. There are no other cases where a value is checked if it's int64, so this should not occur anywhere else in this chart.

@wtfloris wtfloris requested a review from a team as a code owner October 3, 2023 14:22
@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


Floris Heringa seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@wtfloris wtfloris closed this Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants