Make framework.WALPrefix a local path #164
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WAL rollback process for plugins is a way to have plugins cleanup external state from any failed requests. The intention is that, whenever a request comes in, the plugin is responsible for writing to
framework.PutWAL()
with some data, and then end a request by callingframework.DeleteWAL()
to delete the data. If the request fails partway through, thenDeleteWAL
never gets called.This PR makes
framework.WALPrefix
to be a local path so that performance secondaries wouldn't end up with the WAL data getting replicated.WAL logs before the change:
After the change:
Azure Auth PR: hashicorp/vault-plugin-auth-azure#137