Skip to content

Commit

Permalink
ci: always trigger slack notification for any failure (#25244)
Browse files Browse the repository at this point in the history
Don't rely on the pass/fail result of the CI workflow for notifications.
We do this to ensure we notify Slack on failures but still allow for
merging.

Signed-off-by: Ryan Cragun <me@ryan.ec>
  • Loading branch information
ryancragun authored Feb 6, 2024
1 parent b736b85 commit 3b970f5
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,13 @@ jobs:
- if: |
always() &&
needs.setup.outputs.workflow-trigger == 'push' &&
steps.status.outputs.result != 'success'
(
needs.test-go.result == 'failure' ||
needs.test-go-race.result == 'failure' ||
needs.test-go-race.outputs.data-race-result == 'failure' ||
needs.test-go-testonly.result == 'failure' ||
needs.test-ui.result == 'failure'
)
name: Notify build failures in Slack
uses: slackapi/slack-github-action@6c661ce58804a1a20f6dc5fbee7f0381b469e001 # v1.25.0
# We intentionally aren't using the following here since it's from an internal repo
Expand Down

0 comments on commit 3b970f5

Please sign in to comment.