Bump consul-template 0.32.0 -> 0.33.0 #22322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhjp
added
agent
dependencies
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
|
CI Results: |
VioletHynes
approved these changes
Aug 14, 2023
| secretIDPath := makeTempFile(t, "secret_id.txt", secretID+"\n") | ||
| defer os.Remove(roleIDPath) | ||
| defer os.Remove(secretIDPath) | ||
| roleIDPath, secretIDPath := setupAppRole(t, serverClient) |
There was a problem hiding this comment.
Love to see this kind of refactoring!
tomhjp
added a commit
that referenced
this pull request
Aug 15, 2023
Also adds a test to ensure the new VAULT_CACERT_BYTES functionality works. Conflicts: go.mod go.sum
tomhjp
added a commit
that referenced
this pull request
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps consul-template to v0.33.0. Changelog
In particular this pulls in hashicorp/consul-template#1782 to ensure the environment variable
VAULT_CACERT_BYTESworks equally well in both Vault Agent auto auth and Vault Agent templating, whereas previously it only worked for the former.I've added a test for VAULT_CACERT_BYTES, and while it used a lot of copy-paste from the test
TestAgent_Template_Basic, I also took some time to extract some common AppRole + KV setup from other tests into one consolidated function to reduce duplication.