Backport of Remove SetConfig from setDefaultRetentionMonthsInConfig into release/1.16.x #27181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/setDefaultRetentionMonthsSetConfig/currently-next-python
branch
from
8990d0e
to
4958105
Compare
github-actions
bot
added
the
hashicorp-contributed-pr
akshya96
approved these changes
May 22, 2024
|
CI Results: |
…SetConfig/currently-next-python
|
Build Results: |
akshya96
deleted the
backport/setDefaultRetentionMonthsSetConfig/currently-next-python
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #27169 to be assessed for backporting due to the inclusion of the label backport/1.16.x.
The below text is copied from the body of the original PR.
While creating CE PR for retention months bug PR https://github.com/hashicorp/vault-enterprise/pull/5869, removing SetConfig from setDefaultRetentionMonthsInConfig was missed.
We do not need this, we call SetConfigInit immediately after setDefaultRetentionMonthsInConfig is called in NewActivityLog()
vault/vault/activity_log.go
Line 286 in 1884267
Overview of commits