Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.16: VAULT-25848 replace mholt/archiver with native go calls (#27228) #27250

Merged

Conversation

VioletHynes
Copy link
Contributor

Manual backport of #27228

There were conflicts in the go.mod/go.sum. I fixed them.

* VAULT-25848 update product code to remove mholt/archiver dependency

* VAULT-25848 replace tests, still WIP while I figure out if there's a bug caught by TestDebugCommand_PartialPermissions

* VAULT-25848 actually remove the dep

* VAULT-25848 add headers for directories, improve test

* Comment cleanup

* Typo

* Use %w

* Typo
Copy link

github-actions bot commented May 28, 2024

Build Results:
All builds succeeded! ✅

Copy link

CI Results:
All Go tests succeeded! ✅

@VioletHynes VioletHynes changed the title VAULT-25848 replace mholt/archiver with native go calls (#27228) 1.16: VAULT-25848 replace mholt/archiver with native go calls (#27228) May 28, 2024
@VioletHynes VioletHynes merged commit 2c9fcfd into release/1.16.x Jun 3, 2024
75 of 76 checks passed
@VioletHynes VioletHynes deleted the violethynes/backport-remove-mholt-archiver-1.16 branch June 3, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants