Backport UI: improve DR Operation Token flow with PGP (#26993) #27252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
| @@ -27,6 +27,7 @@ | |||
| @textToCopy={{this.pgpKey}} | |||
| @color="secondary" | |||
| @onError={{(fn (set-flash-message "Clipboard copy failed. The Clipboard API requires a secure context." "danger"))}} | |||
| @isTruncated={{true}} | |||
There was a problem hiding this comment.
I think adding this arg makes things less accessible - is it necessary?
There was a problem hiding this comment.
Yes, this was sort of the point of the original -- letting it overflow means the copy button is only clickable if you scroll. The data shown is also something the user already has (they uploaded it) so the contents are less than critical IMO
hellobontempo
approved these changes
May 28, 2024
|
Build Results: |
|
CI Results: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #26993