Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember data remove deprecation Ember Promise Many Array behaviors #28652

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Monkeychip
Copy link
Contributor

@Monkeychip Monkeychip commented Oct 9, 2024

Description

Removes any of the no longer supported methods on PromiseManyArray's. There was only one remaining use case left—we we're using slice() in an MFA methods workflow.

Here are the deprecation notes
Here is an RFC mentioning that slice() is no longer supported.

  • Ent tests pass (I ran with the throw flag).

@Monkeychip Monkeychip added this to the 1.19.0-rc milestone Oct 9, 2024
@Monkeychip Monkeychip requested a review from a team as a code owner October 9, 2024 16:01
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

Build Results:
All builds succeeded! ✅

Copy link

github-actions bot commented Oct 9, 2024

CI Results:
All Go tests succeeded! ✅

Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants