From 3977fd4cc4f2b6bba346ed86b449f50ca1f89621 Mon Sep 17 00:00:00 2001 From: Angel Garbarino Date: Wed, 9 Oct 2024 09:42:56 -0600 Subject: [PATCH 1/2] fix --- .../controllers/vault/cluster/access/mfa/methods/create.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ui/app/controllers/vault/cluster/access/mfa/methods/create.js b/ui/app/controllers/vault/cluster/access/mfa/methods/create.js index 4f5eea0d093a..806f92365f11 100644 --- a/ui/app/controllers/vault/cluster/access/mfa/methods/create.js +++ b/ui/app/controllers/vault/cluster/access/mfa/methods/create.js @@ -96,8 +96,9 @@ export default class MfaMethodCreateController extends Controller { // first save method yield this.method.save(); if (this.enforcement) { - // mfa_methods is type PromiseManyArray so slice in necessary to convert it to an Array - this.enforcement.mfa_methods = addToArray(this.enforcement.mfa_methods.slice(), this.method); + // mfa_methods is type PromiseManyArray. Array methods like slice are no longer allowed on PromiseManyArray. We must yield the promise first, then call the method. + const mfaMethods = yield this.enforcement.mfa_methods; + this.enforcement.mfa_methods = addToArray(mfaMethods.slice(), this.method); try { // now save enforcement and catch error separately yield this.enforcement.save(); From 344becc7f7ab150b208e530dd5bf26b55da76740 Mon Sep 17 00:00:00 2001 From: Angel Garbarino Date: Wed, 9 Oct 2024 09:57:15 -0600 Subject: [PATCH 2/2] remove deprecation from config --- ui/config/deprecation-workflow.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/ui/config/deprecation-workflow.js b/ui/config/deprecation-workflow.js index 113a40887371..90516f7ad170 100644 --- a/ui/config/deprecation-workflow.js +++ b/ui/config/deprecation-workflow.js @@ -11,8 +11,5 @@ self.deprecationWorkflow.config = { self.deprecationWorkflow.config = { // current output from deprecationWorkflow.flushDeprecations(); - workflow: [ - // ember-data - { handler: 'silence', matchId: 'ember-data:deprecate-promise-many-array-behaviors' }, // MFA - ], + workflow: [], };