Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ember data remove deprecation Ember Promise Many Array behaviors #28652

Merged
merged 3 commits into from
Oct 9, 2024
+4 −6
Merged

Ember data remove deprecation Ember Promise Many Array behaviors #28652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3977fd4
fix
Monkeychip Oct 9, 2024
344becc
remove deprecation from config
Monkeychip Oct 9, 2024
f0b06f7
Merge branch 'main' into ui/VAULT-31216/promise-many-array-behaviors
Monkeychip Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ui/app/controllers/vault/cluster/access/mfa/methods/create.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,9 @@ export default class MfaMethodCreateController extends Controller {
// first save method
yield this.method.save();
if (this.enforcement) {
// mfa_methods is type PromiseManyArray so slice in necessary to convert it to an Array
this.enforcement.mfa_methods = addToArray(this.enforcement.mfa_methods.slice(), this.method);
// mfa_methods is type PromiseManyArray. Array methods like slice are no longer allowed on PromiseManyArray. We must yield the promise first, then call the method.
const mfaMethods = yield this.enforcement.mfa_methods;
this.enforcement.mfa_methods = addToArray(mfaMethods.slice(), this.method);
try {
// now save enforcement and catch error separately
yield this.enforcement.save();
Expand Down
5 changes: 1 addition & 4 deletions ui/config/deprecation-workflow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,5 @@ self.deprecationWorkflow.config = {

self.deprecationWorkflow.config = {
// current output from deprecationWorkflow.flushDeprecations();
workflow: [
// ember-data
{ handler: 'silence', matchId: 'ember-data:deprecate-promise-many-array-behaviors' }, // MFA
],
workflow: [],
};
Loading