-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try Apple AArch64 again #10363
try Apple AArch64 again #10363
Conversation
0263ffe
to
4c98ddb
Compare
It'd be great to have this working and add it to the set of pre-release binaries. Many people are using ARM silicon from Apple these days. Godspeed! |
If you look at it, adding it to the prerelease (and adding support for archs other than x86_64 in the process) is part of what this PR does. |
It's a good sign that it's now the Windows jobs that are slowest. (That one someone like jasagredo will have to figure out.) |
4c98ddb
to
d484e38
Compare
Question: a large part of my objective here was to speed up the Mac builds, but in the process all the Intel builds were lost. Do we want to support those some other way (e.g. overnight builds), or re-add them for the ghcs that only work on Intel, or something else? |
03e73d9
to
e6874b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Let's see if the runner has stabilized yet. Also, fixed the arch issues (validate no longer assumes everything is x86_64).
e6874b7
to
f66eb28
Compare
@mergify backport 3.12 |
✅ Backports have been created
|
@mergify backport 3.14 |
✅ Backports have been created
|
I think, given the complexity of our CI and how often it breaks (including due to external reasons), optimizing for CI maintenance should be the priority and compromises are fine (e.g., only running some tests on Intel Macs). It's better to have less exhaustive CI that works and doesn't consume all out maintenance budget than the other way around. So I support your approach. |
Let's see if the runner has stabilized yet. Also, fixed the arch issues (validate no longer assumes everything is x86_64).
Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: