Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch validate to 22.04 for now #10445

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

geekosaur
Copy link
Collaborator

validate-old-ghcs doesn't work on 24.04, which GHA just updated to; and it uses build artifacts from the earlier steps, so for now the whole thing needs to be downgraded to get thinsg working. We must address this properly later.

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

`validate-old-ghcs` doesn't work on 24.04, which GHA just updated
to; and it uses build artifacts from the earlier steps, so for now
the whole thing needs to be downgraded to get thinsg working. We
must address this properly later.
@geekosaur
Copy link
Collaborator Author

Yep, that fixed it.

@geekosaur geekosaur added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Oct 11, 2024
@geekosaur
Copy link
Collaborator Author

I'm not sure how we deal with this beyond using the Lucid images; about the only possibility other than leaving things as this makes them is hoping builds on Noble will run on Lucid and having only validate-old-ghcs use the older image until either it goes away or ghcs that require tinfo5 roll out of support.

@geekosaur
Copy link
Collaborator Author

8.4.4: tinfo6
8.2.2: fails to install on 24.04, probably tinfo5

@geekosaur geekosaur added the merge me Tell Mergify Bot to merge label Oct 11, 2024
@geekosaur
Copy link
Collaborator Author

geekosaur commented Oct 11, 2024

Also, there's no rush to abandon 22.04. A 20.04 image is still available, and is unlikely to go away for 2 years (Ubuntu 26.04 unless Canonical changes their LTS versioning and/or release timing) so 22.04 should still be around when ghc 8.2 rolls off of support.

@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Oct 11, 2024
@mergify mergify bot merged commit 6548697 into haskell:master Oct 11, 2024
48 checks passed
@geekosaur
Copy link
Collaborator Author

@mergify backport 3.14

@geekosaur
Copy link
Collaborator Author

@mergify backport 3.12

Copy link
Contributor

mergify bot commented Oct 11, 2024

backport 3.14

✅ Backports have been created

Copy link
Contributor

mergify bot commented Oct 11, 2024

backport 3.12

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous-integration merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge priority: high 🔥 ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants