Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kill a continue-on-error #10462

Merged
merged 1 commit into from
Oct 15, 2024
Merged

kill a continue-on-error #10462

merged 1 commit into from
Oct 15, 2024

Conversation

geekosaur
Copy link
Collaborator

It doesn't do what we really want, nor really does anything else that isn't an unwieldy-at-best stack of conditions.

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@geekosaur geekosaur added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Oct 13, 2024
@geekosaur
Copy link
Collaborator Author

geekosaur commented Oct 13, 2024 •
edited
Loading

I'll hold off on the backports until I sort out the current mess with validate.yml. (It won't even apply currently, they don't have the "keep going" PR in any form iirc.)

@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Oct 13, 2024
@geekosaur
kill a continue-on-error
b5ad3c4 
It doesn't do what we really want, nor really does anything else
that isn't an unwieldy-at-best stack of conditions.
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Oct 15, 2024
@mergify mergify bot merged commit 5124e8a into haskell:master Oct 15, 2024
48 checks passed
@geekosaur
Copy link
Collaborator Author

@mergify backport 3.12

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 16, 2024 •
edited
Loading

backport 3.12

✅ Backports have been created

@mergify mergify bot mentioned this pull request Oct 16, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulysses4ever ulysses4ever ulysses4ever approved these changes

@ffaf1 ffaf1 ffaf1 approved these changes

Assignees
No one assigned
Labels
attention: needs-backport 3.14 continuous-integration merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geekosaur @ulysses4ever @ffaf1