Add a note for contributors installing fourmolu #10473
Open
+35
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philderbeast
force-pushed
the
doc/install-fourmolu-10472
branch
from
9ca9d0f
to
9e9abe5
Compare
philderbeast
force-pushed
the
doc/install-fourmolu-10472
branch
from
9e9abe5
to
e2f28ea
Compare
geekosaur
requested changes
Oct 23, 2024
ulysses4ever
approved these changes
Oct 23, 2024
- Redundant "that". - Use indefinite article. - Assume ghc version installed via ghcup - Use `--with-compiler` option - Grammar, "its requirement" Co-Authored-By: brandon s allbery kf8nh <allbery.b@gmail.com>
philderbeast
force-pushed
the
doc/install-fourmolu-10472
branch
from
b57438f
to
dab2b48
Compare
philderbeast
force-pushed
the
doc/install-fourmolu-10472
branch
from
dab2b48
to
85ba5b8
Compare
philderbeast
force-pushed
the
doc/install-fourmolu-10472
branch
from
85ba5b8
to
2493075
Compare
|
@geekosaur I've squashed your suggestions and moved the |
| > ``` | ||
| > [!Tip] | ||
| > If you have multiple versions of GHC installed with `ghcup`, a series specific |
There was a problem hiding this comment.
Suggested change
| > If you have multiple versions of GHC installed with `ghcup`, a series specific | |
| > If you have multiple versions of GHC installed with `ghcup`, a series-specific |
Hyphens strike again...
jasagredo
reviewed
Oct 23, 2024
geekosaur
reviewed
Oct 23, 2024
| > installing it this way is: | ||
| > | ||
| > ``` | ||
| > $ cabal install fourmolu-0.12.0.0 --overwrite-policy=always --ignore-project |
There was a problem hiding this comment.
A different worry here is that people may have other versions of fourmolu installed, and may need them for other projects. Sadly, there is no good solution to this at present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10472.
Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: