Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cabal-install 3.14.1.1 release notes #10709

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

Kleidukos
Copy link
Member

No description provided.

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ulysses4ever
Copy link
Collaborator

We should probably put priority: high to skip the delay

@Kleidukos
Copy link
Member Author

@ulysses4ever oh, I hadn't realise this label could do that, I usually apply "delay passed".

@ulysses4ever
Copy link
Collaborator

Yeah, it's a fairly recent development from @geekosaur. I didn't follow very closely but maybe the idea is that putting the "delay passed" label isn't fair since the delay actually hasn't passed. The effect of either one is (I hope) the same: skipping the delay.

@geekosaur
Copy link
Collaborator

The idea was that setting "delay passed" gives nobody a chance to butt in; setting "high priority" immediately sends a a notification to Matrix as a warning for people to review it quickly before they lose their chance.

@geekosaur
Copy link
Collaborator

See #10353 for more details.

@Kleidukos Kleidukos requested review from geekosaur and fgaz January 5, 2025 13:07
@ffaf1
Copy link
Collaborator

ffaf1 commented Jan 16, 2025

We are checking review-needed PRs in the forthnightly call, does this need any help?

@ulysses4ever ulysses4ever added the merge me Tell Mergify Bot to merge label Jan 19, 2025
@ulysses4ever ulysses4ever force-pushed the cabal-3.14.1.1-release-notes branch from 0895ce7 to c465f97 Compare January 19, 2025 14:05
@ulysses4ever
Copy link
Collaborator

@ffaf1 answering your question above: please, provide a second approval. We need to get this done ASAP because it was lingering for far too lang and people are starting to notice the missing release notes...

Copy link
Collaborator

@ffaf1 ffaf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

@mergify mergify bot added merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days ready and waiting Mergify is waiting out the cooldown period labels Jan 19, 2025
@mergify mergify bot merged commit 54d364d into haskell:master Jan 19, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attention: needs-backport 3.14 merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge priority: high 🔥 ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants